From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71912C38142 for ; Tue, 31 Jan 2023 19:02:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E02A6B0074; Tue, 31 Jan 2023 14:02:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 069886B007B; Tue, 31 Jan 2023 14:02:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E26B16B007D; Tue, 31 Jan 2023 14:02:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CE7AC6B0074 for ; Tue, 31 Jan 2023 14:02:11 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B143F120C82 for ; Tue, 31 Jan 2023 19:02:11 +0000 (UTC) X-FDA: 80416014462.24.1349AFF Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by imf15.hostedemail.com (Postfix) with ESMTP id 2E591A0036 for ; Tue, 31 Jan 2023 19:02:08 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YUleBjQD; spf=pass (imf15.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675191729; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=njgLhJzeDdAc0gMdbdqYyGExvQqOhYrpiMsVMjpoO90=; b=riyOrhrmNpwBuIxjTIE1AceXrA0wDHTJpdIFVJSr43Tm8FTUbvt0B9Hi1RYd2SiTAaEmMQ fbNKb82myvUCPClrqvxkNjy0BbmGBa74tCNtiF1yYg8hHXT7XSnd8ASuJfi0Oqrc/ekuT6 f7bRf0ju5zhNKqgNfAyg98j3c9yBN20= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=YUleBjQD; spf=pass (imf15.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.176 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675191729; a=rsa-sha256; cv=none; b=cYNpynrVcCj+Lay9/smmHOmFldRimq0IdDby5gxXODI+yq/TVmBSAgZ/IT6lis0eA27d3b rgKAvoAsS7mtsbVy8LkD1NAttfOwVVL8Eyru/MQRjRD9HbDXtTNMvfPNoLPG3SU5/EI61v 0pcmszdia8Ukv6HBpBmhfXm8s8lr/Qw= Received: by mail-pf1-f176.google.com with SMTP id 144so10909877pfv.11 for ; Tue, 31 Jan 2023 11:02:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=njgLhJzeDdAc0gMdbdqYyGExvQqOhYrpiMsVMjpoO90=; b=YUleBjQD2fhU1By6PsZqxi2pk6KNzePhS+WBhWuRbmUCtEeFwt13ANkAU2icWb0VqH g1czBs4EN8kYMj6FSi3v5wN0qvFRfBwmBUMYiknyympByZYaZpSSZei0Rdu2fVpNCNmc NQFvumne5jMbTIGM3mhe0MvbRBx18jJpYlFz3vD5C3Yr6ptRq2ff508ZNzA92MF705rk FtkVbVx2SkUXaiRT3Y4LGqcl6EAofQ7IgHvHsYMKNUi+b9En8WpEAdiZojavA3Qt9IZe v1FliX9FkJazPv+R/tswWQQcKmLYK2by6ip84XHKv9BJaQ3lAzIKAqI6NWuSoFIpFK69 ENBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=njgLhJzeDdAc0gMdbdqYyGExvQqOhYrpiMsVMjpoO90=; b=Rj+P2uR7WZCuSibz60yXRh+O1MYgFF8ymG31+4aRyHIbh5Mj8ZPhgL4LmphXyEWrbM ucBdofaQBneqIcxu9B3EdPWBTx8epY2i1bT75+YnCTu74/UMWoCQ5BIF2aq84E97l0R+ BY3fu31ztuTPfUogwhxnrwinecT+0pCkfVHFDgAGg2oCzzdnNKQG8+3lObaCdpREGXHI fmbLQpAQwqvVgpKvvLkuS4l/PAb27mZm8wEhale9JtWDUNHIzmCVgzwVVdqF1tpXxSfk Cb04iO53NR/+fBx0HziG/hZQ86TGVtokgRJLkpnb2CbuadWSfYZH740BvxC2wRREC553 D1XA== X-Gm-Message-State: AO0yUKVP+dyO27ZjsudtfVYZbcNlQPVaZiUHNVbeX779w4F7yY21KPrn w7LLfovtVNnw0iTwIHaSYSbsGRyhpWwV18dXq1U= X-Google-Smtp-Source: AK7set/lesTXQEGlXe0l4epZ1hEzkSuCaKIJMqD4LcpRzLOpkOmJ6IoTCfquvJZck0OJAsKR8xdKdNEGspHp53MJqSk= X-Received: by 2002:a05:6a00:9aa:b0:593:e0ce:fc20 with SMTP id u42-20020a056a0009aa00b00593e0cefc20mr1063609pfg.28.1675191728068; Tue, 31 Jan 2023 11:02:08 -0800 (PST) MIME-Version: 1.0 References: <5456286e2c9f3cd5abf25ad2e7e60dc997c71f66.1675111415.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 31 Jan 2023 20:01:57 +0100 Message-ID: Subject: Re: [PATCH 09/18] lib/stackdepot: rename hash table constants and variables To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ww6z5o3hkemcjnrhfms8w71naek7gfi4 X-Rspamd-Queue-Id: 2E591A0036 X-HE-Tag: 1675191728-637936 X-HE-Meta: U2FsdGVkX19Y8nD6q1SUS1ePzo/v8ZE/eHuaeZ9YszhR0V5AvnFYbo0ct6S7ep2GAOenp8ekQrpDSkkt8C1f8BPiTda0lXskQVXbRgLIIgK3jJRd0AomlcJyLRhWpi3PWjvg4HDM+tBgktyJMCeWBuKlSN5Dm1+lySvNsaq5Ls/76u5n3cBq4PuS2rWHc85CMixv9SWp4cXdB8IacWgsuTjM7frtk7R9fpR3SdJnYuBjKJdZ55wmJhwRMfd0b5B8c8+ERxDHbUb/12/aUTHmb4iq42pBdVJezaWxefnjPmIAjrepTXH52lH+HMsT+3+1eUIx8EizSPwUHDecXNK3KhkLlndqCCYsvlmh645J5BjY1MCTSvQrX9D639OvfcN6o/5rjFBh/J1bK8/262+mZsMKSV7KYDwhoz9F3Ni7CJnhQCca8o956I00HJA1IyO9B6EORiUi/2Osbpk67bBZm8HuWvIWx540eHapYcyI17OU0LD9mjQ9abNLlv+aFw+Pr3T9DsCJYTYxC085Ja/76sZZOYgL578G73Al+gtFfMapZvUrVRWHQ14SKZpn9c7+UZpRIpePzF+aPVjVT2aiHIeJZe7tY0vJyrjajPx4v1AmP+XyCcgOJrnLt7g6luh7I1devijVZ+bq1GwNibJpeburO9iHH7ZeznSw4Zrgi52MhHQdNRwvM1uYF8Lzxz5yX3W9HWNvQAbsjiltu6uDulZ5ggvBnvYxzo2XKTGyS53Ogi2BNnir8pr/yAiHn5iorFajdjR4tHzg5di/L4jYRZa/utW+unsrdOBo7qjldYfWZ1D7GrD+S5QjXKK1qigY1ohnOBYq7iFoVzJRI/QExOnw1mcq5GVAP2aRTkTPV5mynkH6qHts1swKR1BZ3LWbfp95xF0PLocbwh8F/5gBbxwfXDiRX0B/KeJwdslTiq8DD2y2jx8QHlJhCsdjssqhbEoNf4r5HDMQCwnyx26 FfzsJ1xx GNPTSFvGA9kzGhv210KIrNlJtOXfU3T0Q9uxGDbwmqNTvL/bS2zF2KksJ/LOJmX5CgT0GrCBvw5XiHbGtXWaX1yofzfz4q3Yt35C3XFQtpY/F37WuoB8T6y4a14dXLQtpXYsxqZPkACtLYkvvoqeovjkC9y4KgKa+X7uvEwgOsPDOfiKy9ygenSC3nMUMgVGegYjg/ASTo4pQbTuSqKhticrDUqKrBcqT0O8c6P+OK6mwppmRSgMhsU2fMBnEx1WEDVxpiXGwhM1fonkYXMPa3KclpUKwyiSlxSUzSnUGIdywuDH2V8ATchJYWrAsfS0lVcKxMNAEQJp6JPxc8xRWSn6EeS0vsv0kgDSo5qZ9WZcYRbtke58sNXfVf8rySV2YXWdZl5Ad+qPAHvY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 12:34 PM Alexander Potapenko wrote: > > On Mon, Jan 30, 2023 at 9:50 PM wrote: > > > > From: Andrey Konovalov > > > > Give more meaningful names to hash table-related constants and variables: > > > > 1. Rename STACK_HASH_SCALE to STACK_TABLE_SCALE to point out that it is > > related to scaling the hash table. > > It's only used twice, and in short lines, maybe make it > STACK_HASH_TABLE_SCALE to point that out? :) Sure, sounds good :) > > 2. Rename STACK_HASH_ORDER_MIN/MAX to STACK_BUCKET_NUMBER_ORDER_MIN/MAX > > to point out that it is related to the number of hash table buckets. > > How about DEPOT_BUCKET_... or STACKDEPOT_BUCKET_...? > (just bikeshedding, I don't have any strong preference). This is what I had initially actually but then decided to keep the prefix as STACK_ to match the stack_slabs and stack_table variables. However, I can also rename those variables to depot_slabs and depot_table. Do you think it makes sense?