From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7B81C021B1 for ; Thu, 20 Feb 2025 16:32:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37ECF280300; Thu, 20 Feb 2025 11:32:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 32F122802FF; Thu, 20 Feb 2025 11:32:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CF79280300; Thu, 20 Feb 2025 11:32:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id F3FE52802FF for ; Thu, 20 Feb 2025 11:32:28 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9163EA4D6B for ; Thu, 20 Feb 2025 16:32:28 +0000 (UTC) X-FDA: 83140865976.21.CDBB1C7 Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by imf09.hostedemail.com (Postfix) with ESMTP id 887D3140026 for ; Thu, 20 Feb 2025 16:32:26 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vh54G6NJ; spf=pass (imf09.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740069146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=djJ6cJLCBX31nVMQXMRyTslZq1heGpJZhHxgGn2SThg=; b=oLs4toxrT4LT0lXCNYZr4OF6AduvEx8wGJwjRaXp3gwff5xLA9ctEf2OmGgkPaGu3VMhCL EcX27B4LlLffVdh8o+qWbaR53nAN5Q7vzBPbuUEKwn2q9P8+h+xEND38WLxduPxT9klVgB 7KCoeSqECLcKNfP+RgDfFmIBZdTBTLI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Vh54G6NJ; spf=pass (imf09.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.43 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740069146; a=rsa-sha256; cv=none; b=geAM6wQ8HjJtobJ16c8QClMxP8OrYGazl7RVVJDhODRr8RD5b1gW5az7fTzryCXYmrExD2 q8cwEEV2ksS22GFG8nFHSAjIqVye60iqa5Vhtp6jILghwNEKOS9k0WJD1plpXqjfRnlzj4 kR4cmIANYyjxo9KJIBCdro6tEMyhthg= Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-38f6287649eso874959f8f.3 for ; Thu, 20 Feb 2025 08:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740069145; x=1740673945; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=djJ6cJLCBX31nVMQXMRyTslZq1heGpJZhHxgGn2SThg=; b=Vh54G6NJJfzybmFq5aUBcDo3+cQhdXVv04YQkHtmsVlAWr9Hxf/8rMhpOgyxK8MWkA HOT/WqS7CUb4cbxgeNbD16N3BzK8/8Nk1bNR99actlUSOqSrUrzB4NzHly+VnLnHK7k0 mQC1jxCRjVTnQU/Hz+sgWDB6Ppc6f08pgJRRWd4egSKMgZa1tn179ygSGQW9tk9SpZKl omUWW+vwrht/5ny4f/PB/jmPrtoQ9ifLMAeOwxJtVelAuJLCOvPpfHP16FYsgas58KYs HYcoWpBnTPF/xJDqPMqbF+Hn+UqXEG5BxYx4v+TSHsz5svWIuZCfgmu5enzal3dAG1Zs 8rjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740069145; x=1740673945; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=djJ6cJLCBX31nVMQXMRyTslZq1heGpJZhHxgGn2SThg=; b=wp8ccUAGh1Z7mgAeSdYBLFQyNl8bg5MYg80eVev8miat0J/sXynsgkG4jAzy94XZqW 0yX1NiLaCEnhJCe/oRItw1OhRSduw+wenBhy127Luc1gzoAxmb+N7JM6P+/Ux7qeP9ht hO6EFl4fAhmY4FCzrRjXpWnIF2hqy15t/G9MrWm+mAq7K7KQ2iSNJyzoToDITuIjjURk vh1L8yHgjNrHu0RshUCh3qMkUpC3madaxw3GebphI+stI9+7Jd4qRqobUKOzno/iohCi qCBz2JC5abkYrsC0meO09/WrCURiYLuJeKUKHvwvUw+lKLbh7sFXcDcU+x4Yqx/tWquW AV5w== X-Forwarded-Encrypted: i=1; AJvYcCXLR6qxGLb3TsRaEy4jx0JFaci6SUS372WoLAyjOTgCQf8cHR+ixpo0Jifu1+rjHqHY5v6zhJXL7Q==@kvack.org X-Gm-Message-State: AOJu0YySHRnG1cxO/fRn31qEOByrK6xuFrgrMA9v3v9S+acnE056+J7E sfX26mfXpTQlQcOLcKMFAL9bUbPUr20q80GEPJZGYvq6RnH0WlKtLmoRvjh+uNfA1WYixeDRx2f QDwzsvcw/pNi9SX+qBkspyJS6fho= X-Gm-Gg: ASbGncvMEQjpZTmD/v0t3Ujs0INE0TMWKU604CyZ3A4A7uvjpmlip/pbNgyI/cIfy3k nXEZALBXcK+YYnj/RSga4+eppmgYmA4cqKVGgBpcH3vEjdPqukh40JvltjP/IG7G9uEt7LLx2e6 Q= X-Google-Smtp-Source: AGHT+IE+fb/qSiQgDRutZeDBlmq5JYRBHFh6IjwYk9fKzL4B9g9ZxsaVzW96bSH5p8ymUhr7jbVsfdyuK+pmPd2y9mA= X-Received: by 2002:a05:6000:10c:b0:38f:2111:f5ac with SMTP id ffacd0b85a97d-38f33f51088mr18279347f8f.31.1740069144731; Thu, 20 Feb 2025 08:32:24 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Thu, 20 Feb 2025 17:32:12 +0100 X-Gm-Features: AWEUYZlJk8i1PGeryrJoWL6O3cLwlGsfEZG1iYKTI3r7jC586Nd1JaZw47VvF2U Message-ID: Subject: Re: [PATCH v2 14/14] x86: Make software tag-based kasan available To: Maciej Wieczor-Retman Cc: kees@kernel.org, julian.stecklina@cyberus-technology.de, kevinloughlin@google.com, peterz@infradead.org, tglx@linutronix.de, justinstitt@google.com, catalin.marinas@arm.com, wangkefeng.wang@huawei.com, bhe@redhat.com, ryabinin.a.a@gmail.com, kirill.shutemov@linux.intel.com, will@kernel.org, ardb@kernel.org, jason.andryuk@amd.com, dave.hansen@linux.intel.com, pasha.tatashin@soleen.com, ndesaulniers@google.com, guoweikang.kernel@gmail.com, dwmw@amazon.co.uk, mark.rutland@arm.com, broonie@kernel.org, apopple@nvidia.com, bp@alien8.de, rppt@kernel.org, kaleshsingh@google.com, richard.weiyang@gmail.com, luto@kernel.org, glider@google.com, pankaj.gupta@amd.com, pawan.kumar.gupta@linux.intel.com, kuan-ying.lee@canonical.com, tony.luck@intel.com, tj@kernel.org, jgross@suse.com, dvyukov@google.com, baohua@kernel.org, samuel.holland@sifive.com, dennis@kernel.org, akpm@linux-foundation.org, thomas.weissschuh@linutronix.de, surenb@google.com, kbingham@kernel.org, ankita@nvidia.com, nathan@kernel.org, ziy@nvidia.com, xin@zytor.com, rafael.j.wysocki@intel.com, andriy.shevchenko@linux.intel.com, cl@linux.com, jhubbard@nvidia.com, hpa@zytor.com, scott@os.amperecomputing.com, david@redhat.com, jan.kiszka@siemens.com, vincenzo.frascino@arm.com, corbet@lwn.net, maz@kernel.org, mingo@redhat.com, arnd@arndb.de, ytcoode@gmail.com, xur@google.com, morbo@google.com, thiago.bauermann@linaro.org, linux-doc@vger.kernel.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 1awhmrbjm89x1z8szmpycd55qfrcy7xf X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 887D3140026 X-HE-Tag: 1740069146-492636 X-HE-Meta: U2FsdGVkX19YKzq9pzCdvsIAsnJB8cMLlpCXH75PUhwmrVgvDXRpO73jpeu+4hVGJ+/AxMKpLKGgpb++o5SlDYuX3baQtzNACUcLqB1kzVnzidvHRzXM1kfvcRxKJMqfsRCV+EX7xSI3IHZimQ3Z0mQe9psjWtFqI9aVfHKnEwNtLXIW2OkagmH7Tag2iOWYTQB8F8d7g8243lapNaVHDWt0n6u+JLeXtA59UW9LzqV8oC9maBhT5ndS2cWZS+4/hClEjgM1wOuMYPvjPOMzFTYOB+gLqySPKOHaQswFW2FzTNFNx+79gb4LOmslZ3ifDFiq+lCZzNiamghAOjrEdtnkri7XJKVvg85Ih5RFdUTQkVeF2VzNHmo1EFkComfs5m4yxFCbtslkbkX32WW6kZ7vt00oWG7U8h6e9AQ3ytWt6oExadv1btNxXtM6W4q6xlm0CVoFMSwfHJPuKeJWZI8duJ/eLXNK+CTLaQ2Jx9dTLHWSr9T3MG9RwNNnZKgYCDBCDuW4ETnNaLwie8lC+Jk9Wf/pfFFDWmfygTXoSIRLawRm97uj6Es0npuRiax8pEBAJpnt/LDOmqK9OiSowkTimG5SgyGV+oRn7TtJZFsUUs49tsavDY6zreFiF/VqLWLRSFOab/UTDObYCoI+uPPiA/X4JmbDPHHTg4nH/o01ez+s+kRfqZoZYQ7Q6bP6akm+kYhh3M/Ms9R/5FMXtbXhCD5DT5uZV6ff239pln3NmRauziDHPZK1DkDR63BzJgzyKW0vLbzHt0DeQ4dO3COgZL+60VCKvhfyuqSS1GO8XpOlepZpZlhzUMvcQHPMu8ERRVmQyHfjp/YoPm++/LriFllHr0SIaY4JuObwpO2QwzD1DQbwp1FQLwnyY26gLeWeD7na+mIM9oyTIuWa3OgnP0Wkuf2fo4hl79pdOjmylstCX29TWI3Ll3HD1y3EvkINbOOb/7O8ypPv9MB xcsWVff4 Ys5vAy4kLhReuLgfTWNTGsH+ILDAtHmzRVi0HDZ12aM027J822pSxVgrMBeG56FUKTYmqtVnYV+4PJosQn73zXRDTzuh48BdOXUzKGrKJSI7X/388DRvTewfcz4B40rD2VhYgepc+yebe3Juzxm1DPHpZGW9TWHiSwSCmX4BvUGfYSkZ46hEIQcKMmo/84psH4+6Iz6zWuHhvectjoN09FkpAc4ACZTbv0NvgPxzJxskvv4p+hmlCzaycwORN+qfXzy8K/jQNIORNPDklYWNG8PIMSeHluhjqzix/3hKD9V+SrnmqwdRV3QeF37kVkZMc8nLbNbAl7HdAwLFllYkU5pG8rapHhmbP5UKY5FHNI3p1EwtOfoULlHSn+nBelobLJJNq9nn0NdUlOa8Wgf5Gs12dgYywKiKwO4l1L6pJw+TLJIYk3FSQIVfQSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Feb 20, 2025 at 12:31=E2=80=AFAM Andrey Konovalov wrote: > > On Tue, Feb 18, 2025 at 9:20=E2=80=AFAM Maciej Wieczor-Retman > wrote: > > > > Make CONFIG_KASAN_SW_TAGS available for x86 machines if they have > > ADDRESS_MASKING enabled (LAM) as that works similarly to Top-Byte Ignor= e > > (TBI) that allows the software tag-based mode on arm64 platform. > > > > Set scale macro based on KASAN mode: in software tag-based mode 32 byte= s > > of memory map to one shadow byte and 16 in generic mode. > > These should be 16 and 8. > > > > > Signed-off-by: Maciej Wieczor-Retman > > --- > > Changelog v2: > > - Remove KASAN dense code. > > > > arch/x86/Kconfig | 6 ++++++ > > arch/x86/boot/compressed/misc.h | 1 + > > arch/x86/include/asm/kasan.h | 2 +- > > arch/x86/kernel/setup.c | 2 ++ > > 4 files changed, 10 insertions(+), 1 deletion(-) > > > > diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig > > index f4ef64bf824a..dc48eb5b664f 100644 > > --- a/arch/x86/Kconfig > > +++ b/arch/x86/Kconfig > > @@ -195,6 +195,7 @@ config X86 > > select HAVE_ARCH_JUMP_LABEL_RELATIVE > > select HAVE_ARCH_KASAN if X86_64 > > select HAVE_ARCH_KASAN_VMALLOC if X86_64 > > + select HAVE_ARCH_KASAN_SW_TAGS if ADDRESS_MASKING > > select HAVE_ARCH_KFENCE > > select HAVE_ARCH_KMSAN if X86_64 > > select HAVE_ARCH_KGDB > > @@ -402,6 +403,11 @@ config KASAN_SHADOW_OFFSET > > hex > > default 0xdffffc0000000000 if KASAN_GENERIC > > > > +config KASAN_SHADOW_SCALE_SHIFT > > + int > > + default 4 if KASAN_SW_TAGS > > + default 3 > > What's the purpose of this config option? I think we can just change > the value of the KASAN_SHADOW_SCALE_SHIFT define when KASAN_SW_TAGS is > enabled. > > > > + > > config HAVE_INTEL_TXT > > def_bool y > > depends on INTEL_IOMMU && ACPI > > diff --git a/arch/x86/boot/compressed/misc.h b/arch/x86/boot/compressed= /misc.h > > index dd8d1a85f671..f6a87e9ad200 100644 > > --- a/arch/x86/boot/compressed/misc.h > > +++ b/arch/x86/boot/compressed/misc.h > > @@ -13,6 +13,7 @@ > > #undef CONFIG_PARAVIRT_SPINLOCKS > > #undef CONFIG_KASAN > > #undef CONFIG_KASAN_GENERIC > > +#undef CONFIG_KASAN_SW_TAGS > > > > #define __NO_FORTIFY > > > > diff --git a/arch/x86/include/asm/kasan.h b/arch/x86/include/asm/kasan.= h > > index 4bfd3641af84..cfc31e4a2f70 100644 > > --- a/arch/x86/include/asm/kasan.h > > +++ b/arch/x86/include/asm/kasan.h > > @@ -6,7 +6,7 @@ > > #include > > #include > > > > -#define KASAN_SHADOW_SCALE_SHIFT 3 > > +#define KASAN_SHADOW_SCALE_SHIFT CONFIG_KASAN_SHADOW_SCALE_SHIFT > > > > /* > > * Compiler uses shadow offset assuming that addresses start > > diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c > > index cebee310e200..768990c573ea 100644 > > --- a/arch/x86/kernel/setup.c > > +++ b/arch/x86/kernel/setup.c > > @@ -1124,6 +1124,8 @@ void __init setup_arch(char **cmdline_p) > > > > kasan_init(); > > > > + kasan_init_sw_tags(); > > + > > /* > > * Sync back kernel address range. > > * > > -- > > 2.47.1 > > Also please update the descriptions of all related options in lib/Kconfig.k= asan.