From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92636CD37AF for ; Fri, 15 Sep 2023 23:42:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED37E6B03FD; Fri, 15 Sep 2023 19:42:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E5C226B03FF; Fri, 15 Sep 2023 19:42:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CFCB46B0400; Fri, 15 Sep 2023 19:42:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BDF2E6B03FD for ; Fri, 15 Sep 2023 19:42:33 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 94A631A07AF for ; Fri, 15 Sep 2023 23:42:33 +0000 (UTC) X-FDA: 81240458586.01.265B208 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf05.hostedemail.com (Postfix) with ESMTP id B1C24100016 for ; Fri, 15 Sep 2023 23:42:31 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="G/YHupz3"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694821351; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HvSLgTTIgHIGD+l7tl19R4elC30zzIy17VfAeigIAQE=; b=IFecEkIF9+EyCTOT8M1A8UFhBB5uqEIsaTHCF4NvV6udjVwCKav76ULG21dKrPc+UGgE6S u/KgmnXxwIiEeQkvfVzg+v7vAxPzrNqqQRpk0WULw0ce9YEItxMsRsBkn+ie/E4vOy93fy 11LA5zfViYqvpJop82daL8HXQ5DgZxg= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="G/YHupz3"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.50 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694821351; a=rsa-sha256; cv=none; b=T3l9cRXhKf2Kk28zMEE9m7RGoOGNuEBEAFgQQnUoInCfHTzHsdwyATfcoIas9TxuZXubb9 0SN+omZ0RQjxFpKN0NWOI/MCNsV7ErFwfeo+Ajiwok8Y7G5rql5upWT3o98qPTXzTnMGJa jOqvQrq/OytPNToVTkereFNvmDCK9tY= Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-26934bc3059so2808662a91.1 for ; Fri, 15 Sep 2023 16:42:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694821350; x=1695426150; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HvSLgTTIgHIGD+l7tl19R4elC30zzIy17VfAeigIAQE=; b=G/YHupz3d+dFrEoFftSWDW0Zo8EmR2S90TV5DXnKG9lFS3cCiP+tMoGBme/+arVgnb Z4Vo3RTWG0QxIQ7kkb4yYt/0YjQP5wW1UmK3GzvgU7JCSJf6PmnnLsQjjfEOAVY1Mkmg 4y5mLVsXDaC+LOsI7F0ZVCWHyjHEzfbQmSaBPc35jbEi6Uc+t62ZD7T5QrUZmbD798ol 76215gHc8Sc2T6/QesRugswTulUgGq8KWrdAr7/X/XSbGE3uzzCO63hEww0PvCdx/Wvx N+iJ5fn30t1w+7rxptAjfykQdffrCfNEpw9WiyZ0SBI04dVvoi0M0nvf1vnZC9meegED awvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694821350; x=1695426150; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HvSLgTTIgHIGD+l7tl19R4elC30zzIy17VfAeigIAQE=; b=t77kDrn0D209Ajd0olZZfie3IBue1tsSJrYubR2QhWATsW69rHctB1j0sLPurPYoOU +mHmTIr8YyukZbrMqghptbpzFWYkzlyuEG8ElpFxa2kS3CWWyoDkUDrAYx7kv8gYA689 Ocif8GXLqI7Q+sPZjailnfMoJ5jQtdFQAcasd5hxq2Pk9j9k/jLW8UtBJsv/CScERwb1 jp8L5cccZIHcZka3ofSotGWxCPvQB6MivotKUK7d7iyKksGLMQdMaDqVLfHeMu5cDWfC F1dO7ZirolPIxO+bY2wuuu7RXyTOQAkAocUE/N6yBT8n1w2FREf3y88SmlPvZIxAZdYm jDlQ== X-Gm-Message-State: AOJu0YzKtRSOpcd5fjqpB4LgZK65zLxoTFxlFySPXgDR0jPNVsqwukaF A1OAD20qULxCtZN0CeJV9ARd0V/qqVjIMV97teA= X-Google-Smtp-Source: AGHT+IHziJa53jxs/XUXF4tHjfe9Bu1xfg0fT9TSx83rjnJPL7ddsasQ91PExTWxXIx5RQn+yT/uPOeSlQY9Cc9pFL0= X-Received: by 2002:a17:90b:34a:b0:274:8951:b5ed with SMTP id fh10-20020a17090b034a00b002748951b5edmr3968062pjb.20.1694821350468; Fri, 15 Sep 2023 16:42:30 -0700 (PDT) MIME-Version: 1.0 References: <2a161c99c47a45f8e9f7a21a732c60f0cd674a66.1694625260.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Sat, 16 Sep 2023 01:42:19 +0200 Message-ID: Subject: Re: [PATCH v2 14/19] lib/stackdepot, kasan: add flags to __stack_depot_save and rename To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: B1C24100016 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: e6d1u7hdu4krzq1mxims7wjk8gg9cj88 X-HE-Tag: 1694821351-167545 X-HE-Meta: U2FsdGVkX19JGNfEycCfg1eZijPJa7xXOAzX3petFM9i9vuFtp5BOyL3FSW8Q4g5wLbTiIx+zEGVLiiMPfI/UGV9yp8nd84BuXnB2BbQSbdJUWHoDRJxBi5sRfHOt9HJhdrnDkETv9QixMYMJpJQSOtFVU0zrhf6yUuquDow14qGRyw/RF8ijZO8CqW81chG243auh0hRyKcod2WIpRP0UWmOdLhMCkodDq24asCLZPDqAjyjWMb6Ew1BFtAeQpvgmwYVuX36mkytC/JpxABWDXKIjTgcCw7NoRqkcnS8WvuQHm+d8pPr6SPz0LYZ991UMJOrpXtqUVMAdYWbc2fk052diwxuwOEpSw686vdlNqdPCaiAPVoULKgwA0+zJAy55JTzMtaFgASEfC8OKzrJHU4NmgtnwWfaS/MjXPSlKe+pzNuq4H3yKEBju9iJ6nGfXCGVUlMPEHbkD/3t72xjyv1JsnpZ1ZWChqA+AHboNFajGZgmlsbgQ2xUXEmEwY1czp/mbXAA4OhmCqct4ouDrb6u8oCIMXZPaSpIZMcnNwaOT8nUH5idlVBDVSon7lPbZwyH3IdffD5i1dXSw+p8Jy50qLSdCldtxTdooR+lCViwOhhKicOrjmZ46+PhrLG82Gf1o+Xk4VfMxGOnISPDglTMrmyjbbVwy2VIl+nNWkCgYfAzDywh/WQceNI94E7KYaFWUejYCrtVvY3wAiA9eYSfLj+qoHazQm3XwTaRDyD68o4jQlYUOCgj5ciRZ9tKwZpCI9ffIWS91Kth3V9o5iI4F4L/4IW4fix43WiSsF5db8YXZfTmXKfvhgMaITiXgpVAjdLqHJh27dAsiRarnEtOblUy+0uvQqJVuYvLfzd1jIT1di/FyxFwd4KQcYxVewlrWoS/6rH6wfk19MVL6MusGBjfsZcz/RYZQf5NIz6f0vpkIbWl/p9R9Qkem6JzIqusETp6wnctY1po4l DI0hzZmd JkeCG9fS3OG9w6+L2GPUrYqDmM/O2T5ICxMIJMtjnCP9umNB6URveDoluZzmsTAv68Acvp+2bbO6U/shGbbK0oeHPtsekM2Wsohza51yFuP4L3iswh+JLXWPLGIZYqe0En7Iy7ipKm9XEYOlIuVgZJZzX31wgwAQNdezq2qkRwxrDpFddXBBV/oeD4qVSED6ED4ERWpGd2koJRe2515tbKgE2ibREvBssuJU5jB+3RoslaIYZjWOGC8Nu4ZCBZHVfg3XWQH/8zV81w7VcQsx7TS/PbUffx+lYzBvK83qEV1Kw/GPOQTcMkukk/6ryAiFq+Hltgrpn/1dg2c101JA6rPce1nUpB9p8U9P1VCn7YaqamUvmXz2SaTPpnDPfR7RIiTynhVBuV0/FptcFoEaVgxjOIprbFKMdMzoj4BR932RyYVM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 10:32=E2=80=AFPM Marco Elver wro= te: > > +depot_stack_handle_t stack_depot_save_flags(unsigned long *entries, > > + unsigned int nr_entries, > > + gfp_t alloc_flags, > > + depot_flags_t depot_flags) > > { > > struct list_head *bucket; > > struct stack_record *found =3D NULL; > > depot_stack_handle_t handle =3D 0; > > struct page *page =3D NULL; > > void *prealloc =3D NULL; > > + bool can_alloc =3D depot_flags & STACK_DEPOT_FLAG_CAN_ALLOC; > > bool need_alloc =3D false; > > unsigned long flags; > > u32 hash; > > > > + if (depot_flags & ~STACK_DEPOT_FLAGS_MASK) > > + return 0; > > + > > Shouldn't this be a WARN due to invalid flags? Good idea! Will fix. Thanks!