From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6BC8C433F5 for ; Mon, 6 Dec 2021 21:10:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B0BA6B0087; Mon, 6 Dec 2021 16:10:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65FE56B008C; Mon, 6 Dec 2021 16:10:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 501FD6B0092; Mon, 6 Dec 2021 16:10:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0056.hostedemail.com [216.40.44.56]) by kanga.kvack.org (Postfix) with ESMTP id 401686B0087 for ; Mon, 6 Dec 2021 16:10:17 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0B7261815A4A9 for ; Mon, 6 Dec 2021 21:10:07 +0000 (UTC) X-FDA: 78888612054.13.0E78DF8 Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by imf24.hostedemail.com (Postfix) with ESMTP id A3C7DB00009D for ; Mon, 6 Dec 2021 21:10:06 +0000 (UTC) Received: by mail-io1-f49.google.com with SMTP id 14so14539108ioe.2 for ; Mon, 06 Dec 2021 13:10:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vPzV3+wkeUfRoOQi+Ln3ww49AQZvsG1boIOkNO2vCs4=; b=gxZcfGvIArjbWnFtr6tjBtX/HZnpf8uwu1b5Q9uJHJ0TYjJS7WM/2R52fluaRJULUM ECtYP9CsxKQvfEQA1Yo5UXhKoDzJ+nqbCgVoCLSJY4sT7Goyz+dxjSzRfXTTFxTNgzXG nHnJzssFp53tZI4A4sYt2kXbuCKPj7rUTg1bU/1FbVTf6ScI/k4gDg9vHxiO/WydAV+w pEtb6Tff5zup9ann3xb0Ek/QJe308UT4sHKExgsVGeh3K77J85/N35Jz5WZcqH1ZI9Gn 1TwmlYl5GiZPY7+Qddv3YNiHiYXfZROo/xjSfbXLjm45UEvTH2oTfTovQxZ/IXN3Q7Xj ALxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vPzV3+wkeUfRoOQi+Ln3ww49AQZvsG1boIOkNO2vCs4=; b=NKbIAipWCsD2KyvNHDdyMQ1gzoyAeoeqXMxol2/Cd4G/C1idx1zIVV1zN/dStfdIAg sbgjlXCFsiUIV0phiRptBPSUJL1KK2ocYxDuQx/VepMcsCpEqtapUDgIp/KHgXDVmBY6 Byuya0Vquo1GIjw1DCRZ2uMu91zOTjR911rP4yqCz+evD0CkczzIP1RBuUqtrc3TLoL+ r/RWbQa+WpjFPtKq7z7UdwTgiE/LwEVOKc+53spgT40q2GctooFqpAHGkKu4Qix/7ZsT 2DQunFDeXIkMNolgdhB3jQCJwkbHhahhQfP4/hFIiSkVrL1dbpDjlRbkCXfxZM4e0avF SgNA== X-Gm-Message-State: AOAM5317cnk5OQuRIG+fs5eJiNvrejPu037aklBQERXJf3yn0XagAfOr ckUg6fqwHh6GlfbOLC+Q7AIPJTkty4/+rIA0f6k= X-Google-Smtp-Source: ABdhPJzDaKRH0rrEq+qtUFRiNPVT3Pn/hqQWooiMUJ/VfBlgtiETibDWKKL+AObO7DhzBRSLag1bTHrXvgxOFlGVPH8= X-Received: by 2002:a05:6602:45d:: with SMTP id e29mr37042616iov.202.1638825006153; Mon, 06 Dec 2021 13:10:06 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 6 Dec 2021 22:09:55 +0100 Message-ID: Subject: Re: [PATCH 28/31] kasan: add kasan.vmalloc command line flag To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Vincenzo Frascino , Catalin Marinas , Peter Collingbourne , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , Will Deacon , Linux ARM , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 61m4f1p1bymmdghz3wyu8j6kxjw1mucn Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=gxZcfGvI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf24.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.49 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A3C7DB00009D X-HE-Tag: 1638825006-40813 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Dec 3, 2021 at 1:09 PM Marco Elver wrote: > > On Tue, Nov 30, 2021 at 11:08PM +0100, andrey.konovalov@linux.dev wrote: > [...] > > enum kasan_arg_stacktrace { > > KASAN_ARG_STACKTRACE_DEFAULT, > > KASAN_ARG_STACKTRACE_OFF, > > @@ -40,6 +46,7 @@ enum kasan_arg_stacktrace { > > > > static enum kasan_arg kasan_arg __ro_after_init; > > static enum kasan_arg_mode kasan_arg_mode __ro_after_init; > > +static enum kasan_arg_vmalloc kasan_arg_vmalloc __ro_after_init; > > static enum kasan_arg_stacktrace kasan_arg_stacktrace __ro_after_init; > > It just occurred to me that all of these (except kasan_arg_mode) are > only used by __init functions, so they could actually be marked > __initdata instead of __ro_after_init to free up some bytes after init. *Except kasan_arg_mode and kasan_arg. Both are accessed by kasan_init_hw_tags_cpu(), which is not __init to support hot-plugged CPUs. However, kasan_arg_stacktrace and kasan_arg_vmalloc can indeed be marked as __initdata, will do in v2. > [...] > > + switch (kasan_arg_vmalloc) { > > + case KASAN_ARG_VMALLOC_DEFAULT: > > + /* Default to enabling vmalloc tagging. */ > > + static_branch_enable(&kasan_flag_vmalloc); > > + break; > > + case KASAN_ARG_VMALLOC_OFF: > > + /* Do nothing, kasan_flag_vmalloc keeps its default value. */ > > + break; > > + case KASAN_ARG_VMALLOC_ON: > > + static_branch_enable(&kasan_flag_vmalloc); > > + break; > > + } > > The KASAN_ARG_STACKTRACE_DEFAULT and KASAN_ARG_VMALLOC_ON cases can be > combined. Will do in v2. Thanks!