From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F565C001E0 for ; Mon, 23 Oct 2023 16:16:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F2566B00E9; Mon, 23 Oct 2023 12:16:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3A2B66B00EA; Mon, 23 Oct 2023 12:16:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26C286B00EB; Mon, 23 Oct 2023 12:16:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 160C66B00E9 for ; Mon, 23 Oct 2023 12:16:57 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A7A06C033B for ; Mon, 23 Oct 2023 16:16:56 +0000 (UTC) X-FDA: 81377230032.10.2D4C315 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf14.hostedemail.com (Postfix) with ESMTP id D38FE100033 for ; Mon, 23 Oct 2023 16:16:54 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NoTjgazQ; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698077814; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9tHn32Hb+H9q5/wYxwsubEfubdWSQHXuWNQ2b+po3Bg=; b=Deo3lIvOoexoec8OpAwUthm3S53hrjYstuX4utNXgibhfdy3RRN4a2L28yf+pRWLPfCzJq DPOl5F4yjUL9pu15F1ICEXoualUVGGZtv3bjoeselWPjRaUv6G74wLczk7xbngvxqAttHy PVU68ppfsvwYUsdVifi8gbFLjJEbYJM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698077814; a=rsa-sha256; cv=none; b=mhRYDlLFloQEvQu+PxXlCeNVHYCzD37pKCh5teML5VBLVKJpn4znLx8UAw19soXg6DCJs8 esX+2NYYDh9uYu5eevy1XrFg8N03ZXU5j/xah85vUa56yQE1pAgGcN89PO/jylnEdNUWB4 HCc98arupe0hSDBujK8d8axjjqVpWVc= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=NoTjgazQ; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-27d2b814912so2208835a91.0 for ; Mon, 23 Oct 2023 09:16:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698077814; x=1698682614; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9tHn32Hb+H9q5/wYxwsubEfubdWSQHXuWNQ2b+po3Bg=; b=NoTjgazQO5gIL5QlYY9CTRDGHlfvpdOHJVqDHUDSm4thrEJD2w/vRzGP1n6j33W9sg iW4qc3w59C7Mrk52ovn/+djY+qpyGAXCr3KnuU1qEtaKUtVchWcV6RKwTCdAhzPNi2TO M84REHwHzG7QO/oIplOIYWMLlguUY7ruE5OHX+lKUKzHJGAJnT8x5ARr/txbwjC/lVxa dC16V+0pjMrZmmi0SiinAyLOB6rZCkDpZjlHQAlVecAGDxhDs+FKlrsyd/qc8hWO1Z6n 1EpU35xcI5C9FzwpFgkVGsbEyCUifqFgv17bQ7iD5rZDmkPHzvRqmuKfkUkTYwH3oC+r wPvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698077814; x=1698682614; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9tHn32Hb+H9q5/wYxwsubEfubdWSQHXuWNQ2b+po3Bg=; b=ClRhJmf0Y3lzBlGFObuNLJu0S5WUvKZJk2pNUsLz9XBYbHauIZLxQxIIUOR9+/sxHt 84pQGXPyjdpTxMD9nEHOo8n8C6m4fok2olZl6vXQH7og1xwa3nQfcapbPRXMAWAg16Qa Wz/NZLzlkSEwut9rSDwfCd9iLqYH8876ScZlNo7USOfti26BNEJtT4s7Li2eD6raqHti 6vHhQ/DqjwQ67KOY6ZcuK19tOAIJD0+qOkxGHZszswBeee0owNj34zXueymvhP6iizJl qmgat6aY5wRMI+hSNfE0MMBYafXMcjh343prCoe/1gmyJx/czcUmpdcq7lUhRsBYuYR9 +1ig== X-Gm-Message-State: AOJu0YyJqbXtZ07cibfQXw8Cu6AUG+ExrVl2NN9eVtWRrslXfsplBp33 z5vgi2j9lUwE1CDh1PB2bcrfbXB4HhqEBo4oPy4= X-Google-Smtp-Source: AGHT+IE7NI5AoYX+Q47TXmLtq15KJkt/9rcszVFqGyTG7JZwhgGpYyJtBDC0qFW9+8fElaMW/I7RGKsYlJZlFdIN/BM= X-Received: by 2002:a17:90a:b903:b0:27d:5504:4cc8 with SMTP id p3-20020a17090ab90300b0027d55044cc8mr7495426pjr.9.1698077813463; Mon, 23 Oct 2023 09:16:53 -0700 (PDT) MIME-Version: 1.0 References: <5c5eca8a53ea53352794de57c87440ec509c9bbc.1694625260.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 23 Oct 2023 18:16:42 +0200 Message-ID: Subject: Re: [PATCH v2 11/19] lib/stackdepot: use read/write lock To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 9x1wh1p4rcmqtagxroj4bu9cqst83995 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D38FE100033 X-Rspam-User: X-HE-Tag: 1698077814-190517 X-HE-Meta: U2FsdGVkX1/elh/tlXxC3eOExSUHi5Y3RaaEIgPwM5hMBiMBUjbyOWM93YE1e/1q7kC7kd+s3v6M3Jnxxai7FMIjp9S6CKyOMg1kni8EI3h69onMLKemIc17K2F/ov3QG/DzrO6nltEtS+PZdJyLXcLmeCFRqylHXLj6tyDijwLFrR3NLgZfy3wFwcJlFqxuSBA9ipFM16872C4e5qh9fOXhagNh6kM0Kc9BVIIWeN8pWPmky7TyYaiMTp0WhlZmZzENdaDd5BlMd0r0/X1hcH79KWW/7dcT9Z7tbRC1F10AvndzBBD1APLBnPR2ZLY4o5s+UMjKsY0U13J8EQYQMiXj89kfAQ8T6NL1IpGm6DLXWMoP7Y+jFlGFrVsQR4E+7pJKTYiz+ZZCleHJDCVxZyhZKAcf3QWh4MvF1uS7UR62v1qSpRGT+PelBX3ZBVOMsIu43ZDkoZ5MFoMrLRA1mP1y25A+mMXmP1ioPyHcntovANe1h31fxf9/vTJPX6bc7Knq/U0yg/VhbzwJLdRQx7DoY0mhri4DfYO8s7QzSJXBQPDjpXD/Zd+3wUrx0r/6gzvscMmJFALhvAdsL4xkzKyePIhsxCFQVd3m8cWIjV4Liauh8114r+ryOkRwzuiFw3rD1kQh1XpM3NFKwsuSGtRrEgSYfsE0F3czLyb3g/9Xm1nYdCKWAch8Klr6O8bz0urgReHi8Z7NRWipq7VW6HhHNemdJURfx3uztAPy1xIpeFlty5aKfQI7pUGxYkfUVb5EAqIbgnLZ+sWa62IyhcmGfWTckhC+e2JimP96ts9SxvfVkdncLVsug2xGJpkRLWVYn1ZyjEObWRFZz2bBr7rIGEoqRDdumtrEQrew+bgzSYvN+jLV3HaeBvzDN85+7IoV63xz9x23khz9Tc19kgu1YCA4OzRiYEXcgMNI5cEd1jdZU50cP6QHHCLKoQe3rw/iitQl7CWzxn/k4/x jYGIHYeX BTPUQkQIjfhjVIjXKOJyTVXfDYaKA4FjZ2RLYUGomidhI7Ql8D7RkE7oPo1aG1W9aCh1oOMU1WxhzYgDoC6M0HeWCfWDo+7MHcf3fbDkjPeOG4ceaJtLun0zl8T7/xoKlb8ipOTZ18uPbg91Lor3poEtORF2ZRxh2lmemuLhGryL4v4Yah/nKnGGaPzKdegLAN3S6n4E0zIaqWHZIYXM/Lwm1quDT9U510+IY+F/HO1Gkm6Fx6EofcAaRsvqyqJaw2qeTr5CH3qlEmbysKSaLFG7dAazULpbNchAL+rfGbFil335uIE6I0fsEgY1HDxd8I9jA4IcJy1y1T+1Uw5X6H2fSbpzFE8kcpZA9Vo+einuqCfoFT096J57Wpg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000118, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 9, 2023 at 11:45=E2=80=AFAM Alexander Potapenko wrote: > > > static struct stack_record *depot_fetch_stack(depot_stack_handle_t han= dle) > > { > > union handle_parts parts =3D { .handle =3D handle }; > > - /* > > - * READ_ONCE pairs with potential concurrent write in > > - * depot_init_pool. > > - */ > > - int pools_num_cached =3D READ_ONCE(pools_num); > > void *pool; > > size_t offset =3D parts.offset << DEPOT_STACK_ALIGN; > > struct stack_record *stack; > > > > - if (parts.pool_index > pools_num_cached) { > > + lockdep_assert_held(&pool_rwlock); > > Shouldn't it be lockdep_assert_held_read()? Indeed, this is more precise. Will fix in v3, thanks!