From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9544FC433F5 for ; Fri, 18 Feb 2022 15:08:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 968E76B0073; Fri, 18 Feb 2022 10:08:11 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F08F6B0075; Fri, 18 Feb 2022 10:08:11 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76B426B0078; Fri, 18 Feb 2022 10:08:11 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0083.hostedemail.com [216.40.44.83]) by kanga.kvack.org (Postfix) with ESMTP id 619016B0073 for ; Fri, 18 Feb 2022 10:08:11 -0500 (EST) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0BECD1815BBE8 for ; Fri, 18 Feb 2022 15:08:11 +0000 (UTC) X-FDA: 79156231182.06.3D435B1 Received: from mail-il1-f173.google.com (mail-il1-f173.google.com [209.85.166.173]) by imf23.hostedemail.com (Postfix) with ESMTP id A3CBD140009 for ; Fri, 18 Feb 2022 15:08:10 +0000 (UTC) Received: by mail-il1-f173.google.com with SMTP id o10so4873856ilh.0 for ; Fri, 18 Feb 2022 07:08:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0WAY4GVsgjaO40pd4PC+o5Qrkod87XgfNtjMligfgoY=; b=k0fc5rFlb0nYvtjo4+yOGOzoacZjWtAHBTbCbMc7Q25WPenvdId6aWq+y6Rdb+00Dq aOaQ218/pbphHfK1eH91BX8+P0n48dqdTw2zXtA+iPrZ1D3/fyQW8/DtgREA0pJKvUj6 Lp3X/6UpSCjLaud6YFWBrPpbWCOZpWE2/WLzSzX0WdLKV9qwvctPYZ60VTz33cAFUw2H ipn17iIMIdUWIB+10TVBgomrK5cedM2iYJRHZjXO/1y0/Lu4+/ZN9IN9pabjQMn7Gx6n qpN+ALnPW/fafYsm5bvSbyI2r+q53/Kf+9VFoS0l84yOd5GtMAbo2c69nY8gVvEJjEaB R64A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0WAY4GVsgjaO40pd4PC+o5Qrkod87XgfNtjMligfgoY=; b=wPZf829wmgWXxTRXHQRTsmgX5rQsRHcEqt50+lRIfC+46ToHMP+Y15iW5y5s61l63p ywesr5L4D2iYQ4AM4TpEO1Ud/nE4/qUAB2F0FRVtL3ueix/sP7OEqx0WdNC+rEjrGGBw 7rb4q/P4mKfC1gPN/B9dis75wTuAf6aIj5CN/uDS/C+CQfGs8jozjomtqUV2x0tsv3og WxlFMdg0BTxN5vCO7xKrAjvikYFh2uU+E9+HY8xLQ7vsHk7i9lMwFRMn+PvIdGWvMQBz 4LkUHqDX1txG/v5CM4KKJU91IiXcn857l7HJIIbXOOTvOBx9AysD8CCfuFhKT2Bt7V+3 GfrA== X-Gm-Message-State: AOAM532VHH89yNiZjqpRGmWYC4CK3R0tOT3k/AojnIQsbCqv4gy2+Ar8 EA5NYvqPb0tEFEKThuLo8mlbCJmhKKRjvPqH9xA= X-Google-Smtp-Source: ABdhPJzMnq7hK9D6lNRhKVIGRl8EXyxXzDy7SCwE7CO0ADTREL9Si+pDygSfUleL+W61anVYscsBJdjjvZkJ28zIcZ4= X-Received: by 2002:a05:6e02:1905:b0:2c1:e164:76eb with SMTP id w5-20020a056e02190500b002c1e16476ebmr982921ilu.28.1645196889849; Fri, 18 Feb 2022 07:08:09 -0800 (PST) MIME-Version: 1.0 References: <5b120f7cadcc0e0d8d5f41fd0cff35981b3f7f3a.1645038022.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Fri, 18 Feb 2022 16:07:58 +0100 Message-ID: Subject: Re: [PATCH mm] kasan: print virtual mapping info in reports To: Mark Rutland Cc: andrey.konovalov@linux.dev, Marco Elver , Alexander Potapenko , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Vincenzo Frascino , Catalin Marinas , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: A3CBD140009 X-Stat-Signature: 1445j49a4ko7zbryfaczwuao1n8thyke Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=k0fc5rFl; spf=pass (imf23.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.173 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1645196890-860292 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 17, 2022 at 1:00 PM Mark Rutland wrote: > > On Wed, Feb 16, 2022 at 08:01:37PM +0100, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > Print virtual mapping range and its creator in reports affecting virtual > > mappings. > > > > Also get physical page pointer for such mappings, so page information > > gets printed as well. > > > > Signed-off-by: Andrey Konovalov > > > > --- > > > > Note: no need to merge this patch into any of the KASAN vmalloc patches > > that are already in mm, better to keep it separate. > > --- > > mm/kasan/report.c | 12 +++++++++++- > > 1 file changed, 11 insertions(+), 1 deletion(-) > > > > diff --git a/mm/kasan/report.c b/mm/kasan/report.c > > index 137c2c0b09db..8002fb3c417d 100644 > > --- a/mm/kasan/report.c > > +++ b/mm/kasan/report.c > > @@ -260,8 +260,18 @@ static void print_address_description(void *addr, u8 tag) > > pr_err(" %pS\n", addr); > > } > > > > + if (is_vmalloc_addr(addr)) { > > + struct vm_struct *va = find_vm_area(addr); > > + > > + pr_err("The buggy address belongs to the virtual mapping at\n" > > + " [%px, %px) created by:\n" > > + " %pS\n", va->addr, va->addr + va->size, va->caller); > > The return value of find_vm_area() needs a NULL check here; > is_vmalloc_addr(addr) just checks that `addr` is within the vmalloc VA > range, and doesn't guarantee that there is a vmap_area associated with > that `addr`. > > Without the NULL-check, we'll blow up on the `va->addr` dereference and > will fail to make the report, which would be unfortunate. Indeed. Will fix in v2. Thanks, Mark!