From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43A3AC7EE32 for ; Sat, 28 Jun 2025 10:57:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A21E06B00A1; Sat, 28 Jun 2025 06:57:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D27D6B00A2; Sat, 28 Jun 2025 06:57:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E8266B00A3; Sat, 28 Jun 2025 06:57:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 7485C6B00A1 for ; Sat, 28 Jun 2025 06:57:03 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2602C122BBA for ; Sat, 28 Jun 2025 10:57:03 +0000 (UTC) X-FDA: 83604507126.10.330B0BD Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) by imf22.hostedemail.com (Postfix) with ESMTP id 3D68BC000B for ; Sat, 28 Jun 2025 10:57:00 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V1Xk82Ix; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751108221; a=rsa-sha256; cv=none; b=0G+92kPMq+7alSUcw2TgIH2wzWI7SCwxJQHxcGum62bWfEh8WPRZJswDEhP27xsq8pZfL6 Dwg1mjNgnLyfWdvoYGaXlothXO9BVB0cAFjGCVtRS1jLGq0UvyfWvTaw9Foox2ypVzT8RB z/LmVwRPqjvE+fLwMWzz695t9a1Dl4g= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=V1Xk82Ix; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.47 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751108221; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WW5Xm1iyi3UCGUGi1nrA70AfDCSuOC/overmp2OZ2oI=; b=Qvbn2zWmhMoy1zfJ02kGGrrq8MKUqWpZT+lldgVUyxgcjYdF+UbU+0yNTI0l3c2gjPUmKC 1uuRvyoSrRreAIMO+PizZV1C4KON77RlQWD+JrB1CKaESQSPQd0PzqNnhlVWs9ik3Cu+Ch gMX/AqCLswgvDJXlxtPmpH42zvSQZPA= Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-453643020bdso26032455e9.1 for ; Sat, 28 Jun 2025 03:57:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751108219; x=1751713019; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WW5Xm1iyi3UCGUGi1nrA70AfDCSuOC/overmp2OZ2oI=; b=V1Xk82IxfxeXn19piuLkw3zK9ofqFo00ttGsUKpYLjRIlxL6fA8UD7k+xHyJrc8CWa m+kMukUIY+PuYbll+3pZpsj4VKJzxBxYoRmUfdW3/RmNtfJ1/ZdYID2kdAk5/stD32PF lQz4rIwvT/k15R2kbbDbKzQ6+5R48p1rz0BKAVnFtiA28MMtdzSXGtTJQ782/FOvfbRG pWBK0MPcL2jVEI6JCjWf5kpH7cgBkoBrJpKc58OysNA9UOl/OwNTs/R7tH61DvQojd3a bB8HMZU9onc+2sfo60jNCXXRBR/KDc9Ne0qAwyboI8Pq8ZWv3QORuSJ6ZtHkvAGU0y02 f1qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751108219; x=1751713019; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WW5Xm1iyi3UCGUGi1nrA70AfDCSuOC/overmp2OZ2oI=; b=hF6TW3NsrIZVFh74hXz2ZWyhDBS10+X4aHSYFne8DygT30EFM9cDPuoEONRRR8OKjI peznmH47v6H+vVPe4qxgqqGAswULs6AedUQUOJLrhppeaU7L0jnptmPeMaYICCN35bLA 3pxuPjfFGA3uC9V6j0qMKpDuYcJq5QC1Zz6Hy4joXdBIV3Vl1o9pn0XgbAqlZ+KPpt0N ker+JvB15fvdXZQnkQAHJOyMS+fU6wrbPbHu60v3rG6MZAFl/7GCUBa4m3+QK75ciIOG KKjZcYNFP1DlZeP3D9l/pH8Q9RjOmoYFuLreq5OZUIn4EaS1oIgb8bV/cze8b2vfBcFP 4LUA== X-Forwarded-Encrypted: i=1; AJvYcCVuvGU+iZaoCOkwyd5Q+/sHAOgAF+Xj+PCxwBT3fka3ORndQ+3xDUqa07z7HOASByLqJEhUlxh9zA==@kvack.org X-Gm-Message-State: AOJu0YzleTXRz4tn7MmnBkB4GVCotSKzbghP6ClslPmNFuT8cScBI+Ym sv0UCee4hDW4K/gGd675QYVhSQMbGhhQpaU+P4vGNeJfreSPs/zCMWyNQcRXGN2MI45H6Ja4ZLy vT5O9YAjoPCUVOAOX2F6zUyE9ovGnldU= X-Gm-Gg: ASbGncsVpOo/aLV71QzJJlE7YC7GT4mJb0sDe+cSINhP4amTmvLS52qqfEy/FzW8L3w BZW+DQiKzMA8TkxZbKZ7Pz9PHjkFqv8+zl3nrpbFLXZ4JBL3bMDGSwgYjo3Dfj0VGS71o21lDDQ qVBY+MAME02hP7pExv9wR0ESK8isHgouP+ViWJrjy8HWsG205nuYmn9s0b X-Google-Smtp-Source: AGHT+IGAGkRhQdbRpH6HhS1J+gxMpfj97HGV7cZaVPURx7gE9Aj/9LEPZdgznOP2vFFz/ZEWLwEewnTNwxfxlbsYcE0= X-Received: by 2002:adf:a1cb:0:b0:3a5:3b14:1ba3 with SMTP id ffacd0b85a97d-3a90b8c99bdmr4338216f8f.49.1751108219175; Sat, 28 Jun 2025 03:56:59 -0700 (PDT) MIME-Version: 1.0 References: <20250626153147.145312-1-snovitoll@gmail.com> In-Reply-To: <20250626153147.145312-1-snovitoll@gmail.com> From: Andrey Konovalov Date: Sat, 28 Jun 2025 12:56:46 +0200 X-Gm-Features: Ac12FXzas27xdNkixqmlGojlaGpK_Gh1QoVs4xiB8K_jsjOjMmn0UG8i3tUlU1Q Message-ID: Subject: Re: [PATCH v2 00/11] kasan: unify kasan_arch_is_ready with kasan_enabled To: Sabyrzhan Tasbolatov Cc: ryabinin.a.a@gmail.com, glider@google.com, dvyukov@google.com, vincenzo.frascino@arm.com, linux@armlinux.org.uk, catalin.marinas@arm.com, will@kernel.org, chenhuacai@kernel.org, kernel@xen0n.name, maddy@linux.ibm.com, mpe@ellerman.id.au, npiggin@gmail.com, christophe.leroy@csgroup.eu, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, alex@ghiti.fr, hca@linux.ibm.com, gor@linux.ibm.com, agordeev@linux.ibm.com, borntraeger@linux.ibm.com, svens@linux.ibm.com, richard@nod.at, anton.ivanov@cambridgegreys.com, johannes@sipsolutions.net, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, x86@kernel.org, hpa@zytor.com, chris@zankel.net, jcmvbkbc@gmail.com, akpm@linux-foundation.org, nathan@kernel.org, nick.desaulniers+lkml@gmail.com, morbo@google.com, justinstitt@google.com, arnd@arndb.de, rppt@kernel.org, geert@linux-m68k.org, mcgrof@kernel.org, guoweikang.kernel@gmail.com, tiwei.btw@antgroup.com, kevin.brodsky@arm.com, benjamin.berg@intel.com, kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, loongarch@lists.linux.dev, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-um@lists.infradead.org, linux-mm@kvack.org, llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 3D68BC000B X-Stat-Signature: jpqyk1yp5caeod8c9py4whqi1sjpnfrn X-HE-Tag: 1751108220-165997 X-HE-Meta: U2FsdGVkX1/wc9f10UyDVp03iCqAsZBSTOatFdO1XclEfioOn8LNf3RkSGFtZkqE+YYIxYRMY5UhJXWDZm3JdKJc4JJTSuU/9loO6KZatxRkqyDlq6P8FQTI5E/nUH/AO94MAHGaS6DBTGwJGtQqwapvpxcXbgBRfMtv0sM/d0UMB1ZE+/G/S1AVQhf/PESu///CYI9vBZLwxOJMLWM3RsAiqd1kmXtaSEh3cZWvIn+Sb8gTMLLzo16//DLJaRlKYkhlLRIkAWHdffYoBR1/t8dPv9paZ9/9Da3mgwRPk3PI90kiz4DmgsxazwYeeXQ47EA5PJiY75Nv30KIX6krywNkSqHenJjHK+5osVTSJFFvQEyLoHiLd/gcY9HUNjxJ5vOxP1m9V7X3fxzJwz84WYIbYnoIPYhYdWNrYH5tWPtmzmOFhycwvG19sM+CE0exE3YhxcLMVTIZB8V6s+ceiKKY68g5Aym8SX6IfWk16M+DyHqw7AQNBLAjc9P6GYXWXfKOq0fgJNSOJBFsntwVcFI6+gNnmWvlqR0Ole6tbFcPw3Bu9dHREq66Jrwdh93p2l2EYf745HjO4EMWk5Rr53cJeAgjcwPXvLnrSAOLgM5I9rZv9O1SsXQqeHpjP4yw/2jgYg7wle0Ez0ld/JBZ5jLO3VxduEb50Z2qLF6jgX43rDTcRGTmVYlX6mCT7i7UeMv9KGTgj1T1k81iw3pRKEbkyCH6OVvL/3MtzSDIKzikRLPm2kyTTmJbT2+lOWGGiWZVU5arhjZe7ri2zjB4RskgfHnFulGlRVrXrGJLIzrOpKCA9e4S3ZWFMr7fu0Pfzhs+uXbLRpJWvyAg2h4+IfvEMsiXqlurkYlFYGru111l0ajSEoXdpdZtwRqaxxxfaeqBT7gezjLPswxBwbg3lxKcMWLvEakM3uXKsDp9HUBBYShh7wn/CSu47Og+vjs1cquItATWn1imX2IzkLO SMfl+yTx c0cA5XXAacFOTCYqbZWPLoPp56qSz8n1WOpw6mUweuWwmP+2tf5ElonHSQyoIn+sNEAqs8yxqGR6osePy6dxC3WgWFDwDc/M0wMyMF0L4zDC+UNMDrw9aWNJatzI16JrUbdHKcbN1FSJOyHNKWwE+GeR5nwpC4DczGMKKfZDLm5LnX+laC5+WnHJLUom7xB9aOzQmZeHGDu/s+hBq9idPAbWLCtUXVqrliKWOeloIGBR3UPHEB8wI0R8A8ExG9SVchvlxCAf8otoAXZ0qZ5aUVpSyRTwGmiUaYO/V9EHih/2rzhD5mT5KMdvfRzHRPj3wm7J1FtP74K1j7XvDOKAthuBT2/V5FHPkDNpv1GpaxjPVPD+CfuGg0/jKE3BH0thq2/C+Kn1sQRdWlVQSuLb/gMfm96kRv1Pxq5DbFq2feTFxxFnX3W+7l9iNk8KjioGS7iAFY43O0noeZcHSyjfcPiqqL0idJRrCw4Ui2rgvux8guJc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Jun 26, 2025 at 5:32=E2=80=AFPM Sabyrzhan Tasbolatov wrote: > > This patch series unifies the kasan_arch_is_ready() and kasan_enabled() > interfaces by extending the existing kasan_enabled() infrastructure to > work consistently across all KASAN modes (Generic, SW_TAGS, HW_TAGS). > > Currently, kasan_enabled() only works for HW_TAGS mode using a static key= , > while other modes either return IS_ENABLED(CONFIG_KASAN) (compile-time > constant) or rely on architecture-specific kasan_arch_is_ready() > implementations with custom static keys and global variables. > > This leads to: > - Code duplication across architectures > - Inconsistent runtime behavior between KASAN modes > - Architecture-specific readiness tracking > > After this series: > - All KASAN modes use the same kasan_flag_enabled static key > - Consistent runtime enable/disable behavior across modes > - Simplified architecture code with unified kasan_init_generic() calls > - Elimination of arch specific kasan_arch_is_ready() implementations > - Unified vmalloc integration using kasan_enabled() checks > > This addresses the bugzilla issue [1] about making > kasan_flag_enabled and kasan_enabled() work for Generic mode, > and extends it to provide true unification across all modes. > > [1] https://bugzilla.kernel.org/show_bug.cgi?id=3D217049 Hi Sabyrzhan, Thank you for working on this! One aspect that is missing from the patches is moving the kasan_arch_is_ready() calls into the include/linux/kasan.h (this is not explicitly mentioned in the issue, but this is what the "adding __wrappers" part is about). Another thing that needs careful consideration is whether it's possible to combine kasan_arch_is_ready() and kasan_enabled() into the same check logically at all. There's one issue mentioned in [1]: > In kasan_cache_create() we unconditionally allocate a metadata buffer, > but the kasan_init_slab_obj() call to initialise it is guarded by > kasan_enabled(). But later parts of the code only check the presence of > the buffer before using it, so bad things happen if kasan_enabled() > later turns on (I was getting some error about invalid lock state). And there might be other callbacks that should be executed even before kasan_init_...() completes. But then for the HW_TAGS mode, if kasan_enabled() is off, then we don't want to execute any callbacks. So maybe we do actually need a separate static key for kasan_arch_is_ready(). But even if so, it still makes sense to move kasan_arch_is_ready() into the __wrappers for the affected callbacks. Thanks! [1] https://lore.kernel.org/linux-mm/CA+fCnZf7JqTH46C7oG2Wk9NnLU7hgiVDEK0EA= 8RAtyr-KgkHdg@mail.gmail.com/