From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F903C4167D for ; Wed, 13 Dec 2023 14:41:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 055236B0406; Wed, 13 Dec 2023 09:41:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 004DA6B0407; Wed, 13 Dec 2023 09:41:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E10626B0409; Wed, 13 Dec 2023 09:41:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D1EEF6B0406 for ; Wed, 13 Dec 2023 09:41:58 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5F2E714019B for ; Wed, 13 Dec 2023 14:41:58 +0000 (UTC) X-FDA: 81562059516.03.19CA9CB Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf06.hostedemail.com (Postfix) with ESMTP id 7FFF218001F for ; Wed, 13 Dec 2023 14:41:56 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eeleDK1c; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702478516; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ti4WWgukFD9JVeDjV7lFsBG44Mu7OstpF0433QBdo70=; b=B6zlEuBA00glYikx+AzdMYMs2jZ+egT/J8TA9Y/BDOGxIaCCPSTE3DSj9FTDChPcPEL1ou JSA/CQxb6ArautKeKTQdvUcj+vc8JZFMB1q9fA2Elc1QnOjceE4y2dhwEwu+j0wyw+J+ON pZioyWECr2lfG2MGCcK28ibz4p2ZOns= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eeleDK1c; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf06.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702478516; a=rsa-sha256; cv=none; b=Efn7ul1DdTF0VV/JfGBLWc9hVxn54cNCNv/ZJrS+t3wc5bQ0IONNy2lGZfTj0afy7Cdq6H tuCP3t7Wdlprkcses0S3qiTl+HIvuPPlNPq+btbzJv8E/83HvQ+jls5LeqvnPbzUNumtta gHq0rN1D0MOgkkMMKDEtwH1h30ZtiPo= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-53fbf2c42bfso5718530a12.3 for ; Wed, 13 Dec 2023 06:41:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702478515; x=1703083315; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ti4WWgukFD9JVeDjV7lFsBG44Mu7OstpF0433QBdo70=; b=eeleDK1cRjfjaCGaSk/VY4flBDgw/nIoCYymN4kQL4xwwE8EVjuWhkTKMPOEyLAtDq kwYHQIKLJCzsCAgJKzlwTXoxvsV0GpegpgCaiC4ru4d4V2O3pbGUVf1eoJ3SJ91SrQtn UKb2Xbf6i9m4q5fg7T0arTRv6KZAQrluqg+uTZiSAgMyuokm22J0AUaZbm0O+LGv/9l+ ssQCGDKRRVBPjwC5Ip7ivypkFcmIMYlWb+aIMW7Y4gj6j306/pNEXaujaOQ51dRG52JD 3kFvzrIHlsr2hPItfnOMsOyjbYnU4CMew853k6rv+n7V/cIcdaBTOznX15x4ZA8oma66 T4cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702478515; x=1703083315; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ti4WWgukFD9JVeDjV7lFsBG44Mu7OstpF0433QBdo70=; b=A7I+YQFI8zIj+zJJp3PE4LhjUhNuAg+EXtRxEn1eTd90n44x53SfEmc55m2xyB1IL1 R6N0bJy8VkbzoosuMdqraXZ9Y48v4spuCZHC9iSezE8xUOpFLwM2WOR3qd0yP5Hj8Bnz nwJyNJvWFf/E1cYKKJHgfK6Zqf6UPgfpbfTbtl0VQVqlMJTkNUrUJfyCksDAsEavHuVR rbL3i3IV0G9g8fM1nF9+n2fKrSIe1oTlDLfCWt92oBzNmLFM3AAXV3OyuKI9+1hl84DO lE/QmtCL/kCu+3yheLR+1byFa3JaKFaRkqeLWWSFop7H1NTqq4cpwnSK7QDiKYjmIOAr rGug== X-Gm-Message-State: AOJu0Yzw6lGvoqkEKwv3rBJApk6G/T0oarid+0IH7LA88v+avpKKXufj /yL9iQAVyzKAfEGYIoBINqSF3mVYSUrzE0sTeAQ= X-Google-Smtp-Source: AGHT+IHrfU+uljWMKsJP4r9Y6j8of4YygdL0gChR4SfRHkHP7ldH7o9FG4rZYsnJqwOKzNQbU3GjbGIXVkcS8MvVcQo= X-Received: by 2002:a05:6a20:9706:b0:18a:e86f:f246 with SMTP id hr6-20020a056a20970600b0018ae86ff246mr7813053pzc.10.1702478515453; Wed, 13 Dec 2023 06:41:55 -0800 (PST) MIME-Version: 1.0 References: <6c38c31e304a55449f76f60b6f72e35f992cad99.1702339432.git.andreyknvl@google.com> <20231212125728.1a275e704db4a5f5ca30e15c@linux-foundation.org> In-Reply-To: <20231212125728.1a275e704db4a5f5ca30e15c@linux-foundation.org> From: Andrey Konovalov Date: Wed, 13 Dec 2023 15:41:44 +0100 Message-ID: Subject: Re: [PATCH mm 1/4] lib/stackdepot: add printk_deferred_enter/exit guards To: Andrew Morton Cc: Marco Elver , andrey.konovalov@linux.dev, Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 7FFF218001F X-Stat-Signature: ad1airrh73z7igycj3cgtqdn1eyyuggq X-Rspam-User: X-HE-Tag: 1702478516-344851 X-HE-Meta: U2FsdGVkX1+vWEiG+e9BeHwesb/DgL+qI34YBk/A5oluBMqmZHS72U9KtVSA6rt677OEoiSeU6kDTMTTiuBPWZIcNRHkorWhj/UNU70Frty5eBerFwzr9ejQtDqSWhb/9rQQCbZmJSRtWK8b7nAMq0xd0UZXtMBrHHj9Ry3YBXpN9i5LeMJYNrG0k3X3OBDMlRG9Au+RQG59nBNi3EEVO4pfcp1ZI4DvOqapBMkK/PLygnYaSaSfe3o4Sk/Aod7cX72LXXzu1hTU8pC9YdfRlf6YLW0I7sumgAWcd/5rLcJ4SoGGIVOr4WXBLMoiPtoOrKvctkF4EMXRWD81XqBShx3mKElWv6w8zpmUB9xdkQob+tQu4NImGWSBdTrcMobvZihmERUHYHs7bUWtLoFYlzWfsU8wH7OI9g3rDaVO3Y8DEj36JNItK4gQLY0bUMR9/hCUHvq0ZVbXenSNagJ/61OUthvZ1dYFMapOJHTeg012F7u5GvGYhspvO40KOxGAm5vvgQiza/eIdzNNTQzI5LXLnc9WEudfq8i+vZNVjFnxW0ywATxtsbpmBxFaobPL+N4kc02Sj2jjQPuPwy5RfpAAr8FvJeQD4PN3ntuZuFH11VDLptcP9Wq2RD7/vqDdr++M9tcGY91MJOzaMOyqhr5FrXmYt4/Rd19A1exYtm3zf0xIkU2jQ4cxfukO0uqDpb1FkSs/je9r/iV9SiAJTpHSIgdQ9178oMy/4tRo+yEyARWnGYUEGM8GTvvcCUu2H575hYoZ6O+IOBJOQM0KfiOFlXesf+FIX/LvSgXjrT3BNfnzxECvMcM/AnufUdrPYU6uz8DBx+67otrt/TrmgcDeanq2WUjuXVmeqLSXyVrlACTSPGm48VPTUTtpT72v85eiWgX+vYoV+3WuFuUl6gHbyKcwL6hn7MhEMIjYt1j5V2bk0bQA2Sb7n1WafWxSZytnKFkuD4HfQga4PeQ KqS0vCN2 Hq5sUAtmzhR5xm8lQSoznY0BWq/83DWmrcWdzY9LBjN6TPA0TXPGaauGVVNlxHOjSXSPMvqcLP2wFBqPcfH0kOcp3CeX5XS8bYvPVJomzUuWrqySJaKA9QiCGbX26fWuO4yCLdJuTfUYg4qogE8K+oJ4XrmuXdtdG2vDMh4fFFGz+x0PzW/dkWYlY5hxo8KQJ4qgz9mPnAvLOqnmaAdaFoqs+Gl6TALNwc5K1xP7kmGeN0EpNexrzHDUPb/nWd4cxFSvnuYnDT0o8ifok5JGmuddG1Bss6fYYYF1q6HbjQsZOg1IgJCsgMLiQdOnY6hkEKNT5ZkGITtP5Zmujsth2CUri4fi0GDTwcJlZRsqmZ0iZe0e+afq91yar4kzmcGLp8iqnREh8wA4E5bH/3TSBH9lIbwM+fUW+hYDAuaUHfxGoq4D5iS896zSVIUL/m2cxpjyOQDROPtJzwG16U3peq+wbVZeIR0C1F9oP0EQUFCw302VGMx2YTTyxwBTTwY12u76RkUNM2fHcwi/JMX4MfsSbbLELq5YpxtB1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Dec 12, 2023 at 9:57=E2=80=AFPM Andrew Morton wrote: > > On Tue, 12 Dec 2023 19:59:29 +0100 Marco Elver wrote: > > > On Tue, 12 Dec 2023 at 01:14, wrote: > > > > > > From: Andrey Konovalov > > > > > > Stack depot functions can be called from various contexts that do > > > allocations, including with console locks taken. At the same time, st= ack > > > depot functions might print WARNING's or refcount-related failures. > > > > > > This can cause a deadlock on console locks. > > > > > > Add printk_deferred_enter/exit guards to stack depot to avoid this. > > > > > > Reported-by: Tetsuo Handa > > > Closes: https://lore.kernel.org/all/000000000000f56750060b9ad216@goog= le.com/ > > > Signed-off-by: Andrey Konovalov > > > > Reviewed-by: Marco Elver > > > > Doesn't need Fixes, because the series is not yet in mainline, right? > > I've moved the series "stackdepot: allow evicting stack traces, v4" > (please, not "the stack depot eviction series") into mm-nonmm-stable. > Which is allegedly non-rebasing. > > So yes please, provide Fixes: on each patch. Sure, I'll add them when I mail v2 after we figure out what to do with patch #2. Thanks!