From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7433CC433EF for ; Wed, 16 Feb 2022 15:21:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FF426B0073; Wed, 16 Feb 2022 10:21:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8AEAB6B0075; Wed, 16 Feb 2022 10:21:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 79D676B0078; Wed, 16 Feb 2022 10:21:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.27]) by kanga.kvack.org (Postfix) with ESMTP id 6B6946B0073 for ; Wed, 16 Feb 2022 10:21:01 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 20FC3224D5 for ; Wed, 16 Feb 2022 15:21:01 +0000 (UTC) X-FDA: 79149005922.04.B8CA081 Received: from mail-io1-f54.google.com (mail-io1-f54.google.com [209.85.166.54]) by imf17.hostedemail.com (Postfix) with ESMTP id 684CE40005 for ; Wed, 16 Feb 2022 15:21:00 +0000 (UTC) Received: by mail-io1-f54.google.com with SMTP id z2so11305iow.8 for ; Wed, 16 Feb 2022 07:21:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=uBW1C5wFk0wpTZVzu222A5UngO/IWRNu9ZiYVflWd9Y=; b=i56LMHidru/lux2u/YrSKgJU+bbEQdHAE1K799Dk4ygQBtMRJ/+pD99/xsKygtsqld VN34cOzYkmLCgxHXDM+1obWGrvvZWxXCE+trLuNyrktZnHsToGvVov33p1JGiyTJsnxr 8nIb11yF8nh7Xk/g51JYSqFApDRYJEZMpPBMXbc9sNoUnXVyc8Os4ei8wwIp28C69Or1 fHc/W55PuSxdLtfErtSFXVigC0z9TWrElvU0UD5I7h+LBOxLxu9bfcZGwnnF2DvC8WqM 2BmmRGjBiC9P09ODUqL9vhfzOQjy9F4j/74CGUTtWHmtxgiwEBDCFlSSLJyIlVUuko0h dCag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=uBW1C5wFk0wpTZVzu222A5UngO/IWRNu9ZiYVflWd9Y=; b=ZGVO2FdUKRx348TAKeokrA/FZrL0nHHXe40JskZ7DMfp/DHFnSXorxJa0yrHZzYKrO FSJw9I8kfSou7YwmVSAeKn17Cx9aO6Hp44FC/eYdjHq59Bjd8U21oXcovLCAtlsqU6Ek y3eAKoWtW3LGkqpSIlFJb2f4GCusim/tnX9YvZdRmYum5xy6roEreE+YFne2YPrayud3 WiKjcgwzRO8iwplMKVrLqR8+NvzIYNyU/D7iUjKu9/OvKjvnEP71IIGd+3kwqslDdv5j 8rzMvrnluM3uSAbsPIHBg2hHv4pNAXMbzf2y2VhEQQulna5HC5gwiBlqExfDWilVgqof Q63Q== X-Gm-Message-State: AOAM5334PVghf+JFwxKnyiuVssWe1B+WF23fpefe8BSV5y7dwrWztJNm tzOqQeZ5c+XfONBwTHgtOi747fXwaohx6QqpLng= X-Google-Smtp-Source: ABdhPJwv6JqLq+tNlN1qIvpvO1TTUyqoC1Tw2tFERpxyFP+V+f/r5WWie9UqPKBbf/tYwmRuVvYKi/XQ7fcCjGyC08I= X-Received: by 2002:a05:6638:1409:b0:30f:843:f953 with SMTP id k9-20020a056638140900b0030f0843f953mr2079611jad.22.1645024859660; Wed, 16 Feb 2022 07:20:59 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Wed, 16 Feb 2022 16:20:49 +0100 Message-ID: Subject: Re: [PATCH mm] fix for "kasan, fork: reset pointer tags of vmapped stacks" To: Marco Elver Cc: andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 684CE40005 X-Rspam-User: Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=i56LMHid; spf=pass (imf17.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: 151z4wsyo4tw1jtpko5zkakqrp9b3fw4 X-Rspamd-Server: rspam03 X-HE-Tag: 1645024860-833028 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 16, 2022 at 10:59 AM Marco Elver wrote: > > On Tue, 15 Feb 2022 at 17:52, wrote: > > > > From: Andrey Konovalov > > > > That patch didn't update the case when a stack is retrived from > > cached_stacks in alloc_thread_stack_node(). As cached_stacks stores > > vm_structs and not stack pointers themselves, the pointer tag needs > > to be reset there as well. > > > > Signed-off-by: Andrey Konovalov > > Reviewed-by: Marco Elver > > Did the test catch this? If not, can this be tested? Kind of, the kernel crashes on boot. I got KASAN_STACK accidentally disabled in my SW_TAGS config, so I didn't see the crash until now.