From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82616C61DA4 for ; Thu, 9 Feb 2023 22:54:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEB7A6B00B5; Thu, 9 Feb 2023 17:54:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A9B096B00B7; Thu, 9 Feb 2023 17:54:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9633C6B00B8; Thu, 9 Feb 2023 17:54:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 865956B00B5 for ; Thu, 9 Feb 2023 17:54:38 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 569CC1A055F for ; Thu, 9 Feb 2023 22:54:38 +0000 (UTC) X-FDA: 80449259436.07.57452AB Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf28.hostedemail.com (Postfix) with ESMTP id 93037C000C for ; Thu, 9 Feb 2023 22:54:36 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="G/FznRNO"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675983276; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jdJbx8cUbzo0up0IR5lEzRMt6aSIhKf92x7ZKJB7vEo=; b=RkhrVi3BwkwnnqiH8AVGjycP7PlKaTvjG1AzO886OpPlKVKVfFQzdmWJD5/yYKfEELgW8D 0LPfurqlXqdnUDHyucaCeLn7KCewzo7DGM46X5CzyH7vsvqd/6Jw0kOZE7genORLzH9PdC RKpIyx3uDQVh3rgLXOE9NYbH9zctYOU= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="G/FznRNO"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf28.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675983276; a=rsa-sha256; cv=none; b=UL5t29Gicki/M9zwmVL5yko9FbV5dP4+GGDZ1xsaZo1IowjYWfTMWJzISQnyf+NUf9BMDN O6iHeYZ/6gOn84Y6l5e+djqaLB5SzHMWXEUcjVtMaT7cqc2IH0Cl2ddFMjt1H9SChFhitC /GjXrqwvv0VG4nyfspxYiZJ3+Oxt8EI= Received: by mail-pj1-f41.google.com with SMTP id f16-20020a17090a9b1000b0023058bbd7b2so3839954pjp.0 for ; Thu, 09 Feb 2023 14:54:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jdJbx8cUbzo0up0IR5lEzRMt6aSIhKf92x7ZKJB7vEo=; b=G/FznRNObgVkQXLBPohkbpuy+Vo3zgOTN1k9wT6w62lk4JC/1LrHh+T2XUb/NvZmH9 sDMIWW/wpMD0wG1f83vfj6CpRRoGaNbzw5buebe/e2B7EBdyQCChWA559Akzg2Kws4D3 h6HozfsFOX0WeDdPM0KgCsV5QxDIRIBtbITs5JE7N3MpY3NQOhnW6gfpQgBCeGAQ9ao/ 35A19tpKtVrbHyiJFfcl9pJoV3bvvfbrGofBIoNpfqBi+ohkXfj/IQWOpXIJE636nsAF iYG3KtVfhFvhiAy2+O41XpIYANOobom8/RI3HTyNMeyabHfgzYFmoW9BZ7HQVB8XulMw ORoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jdJbx8cUbzo0up0IR5lEzRMt6aSIhKf92x7ZKJB7vEo=; b=oI99yxFlkjjNtRm3ClJ8Ws8+VP4qLoaPQb8EoWBGxjm9MyGLMfT0cx45ou1BtBiVHM m8OWI6sSHxFqneKZyNjZ8LlUGIGw/maZH1zO1MaEwiKommGq69ePadrUSUfdE12DKoUc 7cRUFuUELgZJYkfwepTbeK723semT3BAHEuQT/oF1SASev/dHkdHKfFKGBYid9L/dFds ExBUIfFUcvXrX/l0I+QZhIg9ATKgw+4CNfLbAe+dc6dg0Phw+4g0W9J/ow6y4Mde1rbA k9jxuuk4sPZfHTH23rjbJ5G+fPV7JvHtdJXNyb/Kvf9MXhQUixkdq8YBV+aP66Wfk9ry So8Q== X-Gm-Message-State: AO0yUKXpirSz4L2tfUztr0L2YJwUh0Mc68POp8CCRv6OwSaCxBfbh7GN ftFrFLNzIC7jH1kXirP3wwgudSgmfTVlBYyEncA= X-Google-Smtp-Source: AK7set9BmOFXeMFgWuYqsMw64603eTyj8QckPEuvDG0+7W0AEhRV/p749AsDYf+uFJJ6rqHxdBb8BEMlTMnjg9BbfMM= X-Received: by 2002:a17:903:22c1:b0:196:6319:a029 with SMTP id y1-20020a17090322c100b001966319a029mr3302057plg.12.1675983275394; Thu, 09 Feb 2023 14:54:35 -0800 (PST) MIME-Version: 1.0 References: <20230209031159.2337445-1-ouyangweizhao@zeku.com> <93b94f59016145adbb1e01311a1103f8@zeku.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 9 Feb 2023 23:54:24 +0100 Message-ID: Subject: Re: [PATCH v2] kasan: fix deadlock in start_report() To: Dmitry Vyukov , =?UTF-8?B?6KKB5biFKFNodWFpIFl1YW4p?= Cc: =?UTF-8?B?5qyn6Ziz54Kc6ZKKKFdlaXpoYW8gT3V5YW5nKQ==?= , Andrey Ryabinin , Alexander Potapenko , Vincenzo Frascino , Andrew Morton , "kasan-dev@googlegroups.com" , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Weizhao Ouyang , =?UTF-8?B?5Lu756uL6bmPKFBlbmcgUmVuKQ==?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 93037C000C X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: sxya45x6skdi3s69hxqunxgazdtx1bw6 X-HE-Tag: 1675983276-986881 X-HE-Meta: U2FsdGVkX1+VGE86ikKrc8Gbq+VuFoz/gCM/28q2xjzuTe4QuH8OIM/Z2+FN3R+tA1pApl63oKXYgj6RJ3HaDku0Jh7dssLcsj5k/bn3lvczc3jW8D9GxUOIiZ7fMugfKSzOJxk7VwhRKAo7fSzWGlDwV8DAK+upQ9hdOxQeA2adLw3gmyr2i/IZaCVlmS2DCBfw9yGUj97isAvrMvETzI8hzZqEgsHrRWqGQx5Ng9fQkQYGxfhlHm1Mk0dkj0o/DaA+hQtYfON/ew113kyWlGwUNPriy2g5idA7vsz9nq19/xFYbavLx/Tc2nHpQ8LAmAX09iWa2RPifq9xXJdM+igWSJYZB2SVz71W0vFFG89+8nJrHo0IRoY5mhfTAUa6OIO/iaukr16USk1wpoccQpnOn8uoO2nwDsQd3szuSOnEEtYK2Gz1wQ5HekAFwuLIEx88pBVNU9QTGkRIlJ4UarMUVwKaGBTsFa7MRg7UNbhX0bGfDatn1YFtcV6rscxRzCY5KTE3Xy82yKxYXSN+rn0ZoruhyhLO4rBKA2tOtM+kCsrQdhZKEdpoUtGK2NPr/jPJerLkyGJLipPSAWElYZybDgwHJQkH2dKmKE9COP0xvXbqgXcqCCH+YLWQETJZju3Bv0TO9HEJzHKJoUn5y4mRsTOKFAaxarPHb3hKr0aXUTFjvqElNMK6JrWggtYlT/K/oY7wFef4lkPUagfpmf9S9yQ0ln1m/EHWjldciQgCanrYOadE4tsLOcDKb9AI/px+BdaehwkRhGpY3kDuzRov6WJFu9/r1fpPiM6TVSMe+wY/eQ2dLztoW4mq+jAf0uQhGxPLEFJAHyFgBhrEKqBygY5JBKQVGsA3PXOWBW1at/YCSL+9ikI2emTTSn6jN78+RcifGWDIFN74IYS1q3V7vTfTk1hgnIpK/s0RngxMDGYV8Ww5DAAtFlcguEqybDQBPJcAvdEmj7u2e9M x856Usm9 FNKIH2AiL+dSwl0mCjyRpm6X/ykcLm/VEcYf4TwQ/fmMj1tqVr1ErSNGiWOYW7fOCDURfTOYbGk7AYYapouzr5gj+w1Lr/89J68Bet+vU0Oo+5US6L5FZVmp41pwEHF7sYpWLK3fCWHYDQHY66kynNCQlefw59pvwpR3QTPusE5UJWsW0z/eNPYZ3AsyVWOyL8ZcXHwEfctX1BexbYtF7M781itwNF63uCRiEHGTbqUcrxcxGUC1XBtP7LL+QEX+JyfXBNI3bcmtz1hkBSK/xf223WoWZeXRGZEtrRaj0TJP1jqem5kTFCIrl9P+WjT/omKdhWJEIr05mo6wgho1wrQCpYuxuCG0CSIsFEm3oQ1Kp2ihXtlubmGelM9lXWQywwmdtDFWknR3EYt3+ZT1+N60at46T0zNsidmXW+niJts9aWnCFy2zM/Cys9LmAxbWyJnUF1mXf/RwZho9Yyitdd9kt2JCUdvHdqoJx57hYYkkOPDDxBxzZi7z5TZWMfQGu2A0jvvquBm2Mq7fiiswlSxctLD6BdT/W4WL9ayw3+ZHn7redAc3YMt2DYCo/pv2hK4d1QikTAwmW4k4w+S26M50cL+2ExNlnCO2ITjbtgsnEE+7mfTNEAiF6eepQZM5tiE9pWHIBytFkQ9UFGmqxvQFm4piFp0Z+83edUw6yVVLBe4h0HoyO9SJNBnwMprLs3b/29Yit6re7/B19tDwCrS4sJmVbnYTh7kO X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Feb 9, 2023 at 11:44 AM Dmitry Vyukov wrote: > > On Thu, 9 Feb 2023 at 10:19, =E8=A2=81=E5=B8=85(Shuai Yuan) wrote: > > > > Hi Dmitry Vyukov > > > > Thanks, I see that your means. > > > > Currently, report_suppressed() seem not work in Kasan-HW mode, it alway= s return false. > > Do you think should change the report_suppressed function? > > I don't know why CONFIG_KASAN_HW_TAGS was blocked separately before. > > That logic was added by Andrey in: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit= /?id=3Dc068664c97c7cf > > Andrey, can we make report_enabled() check current->kasan_depth and > remove report_suppressed()? I decided to not use kasan_depth for HW_TAGS, as we can always use a match-all tag to make "invalid" memory accesses. I think we can fix the reporting code to do exactly that so that it doesn't cause MTE faults. Shuai, could you clarify, at which point due kasan_report_invalid_free an MTE exception is raised in your tests? > Then we can also remove the comment in kasan_report_invalid_free(). > > It looks like kasan_disable_current() in kmemleak needs to affect > HW_TAGS mode as well: > https://elixir.bootlin.com/linux/v6.2-rc7/source/mm/kmemleak.c#L301 It uses kasan_reset_tag, so it should work properly with HW_TAGS.