From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD39C433ED for ; Fri, 9 Apr 2021 20:39:59 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 954E9610C8 for ; Fri, 9 Apr 2021 20:39:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 954E9610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0949C6B006C; Fri, 9 Apr 2021 16:39:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 044CD6B006E; Fri, 9 Apr 2021 16:39:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E262B6B0070; Fri, 9 Apr 2021 16:39:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0175.hostedemail.com [216.40.44.175]) by kanga.kvack.org (Postfix) with ESMTP id C28F76B006C for ; Fri, 9 Apr 2021 16:39:58 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7AED58248047 for ; Fri, 9 Apr 2021 20:39:58 +0000 (UTC) X-FDA: 78013995276.14.D42E39A Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf14.hostedemail.com (Postfix) with ESMTP id 6C882C0007C2 for ; Fri, 9 Apr 2021 20:39:52 +0000 (UTC) Received: by mail-ej1-f42.google.com with SMTP id hq27so10620293ejc.9 for ; Fri, 09 Apr 2021 13:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vx9Ye8GdMp5AWz2zoETZUcBCfUh884wkgBYG61Nkrec=; b=AvHGMe88O0kQ2Jw87ZBNde7OJ3MZ4GXqRLkY0A26Y/iq7IfsvvGW7Mz/j09toL2lT4 OL+rASnnRujVoF8fPXZ4Rq3vALqXD3nqS+V3CkmQg52G8gD7wiPlFu6lUXVET7KS2OWb ihE6Fgh6nQAYUAnJc2TuiMpIdRFMamI/A9sTo1fxkf8rNo5z3EvbZ5N9NftuqFXGitY0 Z3WD7d69eSILnU54USApDCbRqB85msN0T9iMKDg0DDNW2BIUNhgSneR+IMf65F+3qV/S DYO5dqcf7K/kHy12UFQcUayea069gpAcm9J502+mhApVaa8TDv7YvWw/rtf03xoUl1Qg GSpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vx9Ye8GdMp5AWz2zoETZUcBCfUh884wkgBYG61Nkrec=; b=o50gpP2FN8gkZ2mNHKuEcZxIrBowW32mZfYOwKhfFrJawRboi9L6jt/ZA0cp58N1Xn DkTzFxRTE4nhqKJKLg69fRSLAw8eCPyWpZCiqxyDKA0+X5azk8UHQSbU5zK4/90SyOjk 9cjoulk3wVM6dliLIn0oZM5bosk9ddub3wfGCgITPb+ZhQqV46sBiykocNefiyUhs/+V j2vMmjsleZsGA05LWFas2amMsW57NiXdjLDDTaytvFpsUdEovjYYp/QWrLcmWxcx+5/p 8mrByLXh4CXKy6LA49Dr+9qQKqtdRwaMDPM/WMI28pjUZ17gDBbYQAYuULftl9o57pWl gvrA== X-Gm-Message-State: AOAM530dAIMB8GALaQyNL9m4MAO03uxGF1mFIJKw5SedFXcmX3GqY4J9 w9pKiJzNW1DrLMk1gWU2UgaGX5Wzba9amTn4Gzg= X-Google-Smtp-Source: ABdhPJyKfYmNeVaGIwRZmk0RgiGlYMyt7DNrutjBjgs8GlHP8UI3q4Zhv4kuldzxUd1CINSs8alfCUJyuIiaFeCUuNM= X-Received: by 2002:a17:907:3c08:: with SMTP id gh8mr4061051ejc.439.1618000796958; Fri, 09 Apr 2021 13:39:56 -0700 (PDT) MIME-Version: 1.0 References: <20210409132633.6855fc8fea1b3905ea1bb4be@linux-foundation.org> <20210409202713.NIELx3Tx9%akpm@linux-foundation.org> In-Reply-To: <20210409202713.NIELx3Tx9%akpm@linux-foundation.org> From: Andrey Konovalov Date: Fri, 9 Apr 2021 22:39:46 +0200 Message-ID: Subject: Re: [patch 05/16] kasan: fix hwasan build for gcc To: Andrew Morton , Arnd Bergmann Cc: Dmitry Vyukov , Marco Elver , Alexander Potapenko , Linux Memory Management List , Masahiro Yamada , Michal Marek , mm-commits@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Andrey Ryabinin , Linus Torvalds Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: ubdqeyx34qk6g9jhz5tyufgmc873hz68 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 6C882C0007C2 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf14; identity=mailfrom; envelope-from=""; helo=mail-ej1-f42.google.com; client-ip=209.85.218.42 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618000792-150605 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Apr 9, 2021 at 10:27 PM Andrew Morton wrote: > > From: Arnd Bergmann > Subject: kasan: fix hwasan build for gcc > > gcc-11 adds support for -fsanitize=kernel-hwaddress, so it becomes > possible to enable CONFIG_KASAN_SW_TAGS. > > Unfortunately this fails to build at the moment, because the corresponding > command line arguments use llvm specific syntax. > > Change it to use the cc-param macro instead, which works on both clang and > gcc. > > Link: https://lkml.kernel.org/r/20210323124112.1229772-1-arnd@kernel.org > Signed-off-by: Arnd Bergmann > Reviewed-by: Marco Elver > Cc: Masahiro Yamada > Cc: Michal Marek > Cc: Andrey Ryabinin > Cc: Nathan Chancellor > Cc: Nick Desaulniers > Cc: Alexander Potapenko > Cc: Andrey Konovalov > Cc: Dmitry Vyukov > Signed-off-by: Andrew Morton > --- > > scripts/Makefile.kasan | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > --- a/scripts/Makefile.kasan~kasan-fix-hwasan-build-for-gcc > +++ a/scripts/Makefile.kasan > @@ -36,14 +36,14 @@ endif # CONFIG_KASAN_GENERIC > ifdef CONFIG_KASAN_SW_TAGS > > ifdef CONFIG_KASAN_INLINE > - instrumentation_flags := -mllvm -hwasan-mapping-offset=$(KASAN_SHADOW_OFFSET) > + instrumentation_flags := $(call cc-param,hwasan-mapping-offset=$(KASAN_SHADOW_OFFSET)) > else > - instrumentation_flags := -mllvm -hwasan-instrument-with-calls=1 > + instrumentation_flags := $(call cc-param,hwasan-instrument-with-calls=1) > endif > > CFLAGS_KASAN := -fsanitize=kernel-hwaddress \ > - -mllvm -hwasan-instrument-stack=$(CONFIG_KASAN_STACK) \ > - -mllvm -hwasan-use-short-granules=0 \ > + $(call cc-param,hwasan-instrument-stack=$(CONFIG_KASAN_STACK)) \ > + $(call cc-param,hwasan-use-short-granules=0) \ > $(instrumentation_flags) > > endif # CONFIG_KASAN_SW_TAGS > _ Hi, As I commented on the patch, this breaks SW_TAGS build with Clang for me with: arch/arm64/include/asm/current.h:19: undefined reference to `__hwasan_tls' The reason for this is that cc-param is only defined for KASAN_GENERIC, the definition needs to be moved. Thanks!