From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96F3CC77B6C for ; Tue, 4 Apr 2023 22:09:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 010786B0071; Tue, 4 Apr 2023 18:09:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F02D76B0074; Tue, 4 Apr 2023 18:09:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DCA376B0075; Tue, 4 Apr 2023 18:09:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CCEA76B0071 for ; Tue, 4 Apr 2023 18:09:34 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A182CC0187 for ; Tue, 4 Apr 2023 22:09:34 +0000 (UTC) X-FDA: 80645101068.19.ACC1A25 Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by imf10.hostedemail.com (Postfix) with ESMTP id DA56BC000A for ; Tue, 4 Apr 2023 22:09:31 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JoPIXnG8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680646171; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ypW3uCkatd85laSwJoEHyhvz6A6Q9ytym+XuTNT93dU=; b=q0GxGGRxnuiXpfvQWpeSw6mhBipnpxcy9GteFb4j+isdxrwWteXmv56tUviyGt0nU/UCT8 InIrBbId58QrBtHOIq6nM5LTCdu0n19FXnUy4RxvhjYe8Ba4Zd8/Jw6d2APVeunKac6r13 DaYd8C7Yz1AufRmmAzFUfsWwupTXeoU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=JoPIXnG8; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.51 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680646171; a=rsa-sha256; cv=none; b=LH5E/TVjImU6pGOhJmGWw9nGQxKVgZ2tY4feFl8IUT9s4KXa18G7V/Nb6VhwQcKKmhh30H rdPNIAGrGNCVxVxSnYHFQWyouvUpB4YL0KSgZ+O02tcZX8YLgEhN6wZNRBXc0DRB/tnkkZ J/O6+UM5P19QvN1x5O9LxzeMWQLCVwM= Received: by mail-pj1-f51.google.com with SMTP id e15-20020a17090ac20f00b0023d1b009f52so37625829pjt.2 for ; Tue, 04 Apr 2023 15:09:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680646170; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ypW3uCkatd85laSwJoEHyhvz6A6Q9ytym+XuTNT93dU=; b=JoPIXnG83ROdZ1kq4xk1n+ZIq8MPvMAtV87d4GO9cK1Ht5tNTGA78J92/9fyfQ8qOz zOkXvSQyi0fCdcUqwDCF1aySQtYSj47zHGZnMA6yXhwZv9AQyrF4VswADo/gInOgv8cV EDAQSv8DIu5lKaQgYKo3yqqGWLmwn21LgwsYD2Hyci1hzAh6UsJvZJCr+689gc8dKlqn eS1k5e6m5h04Bp+/UQ/F13SBvUKzlkK5oXRvgxzxk3Kk5KyPaC5gueNPmztxsO+0cjDR KyU54efHq5YIukhd5Dzmoy4gKq97Wol87Sn4yfXNtziL0Ij6a9VFiH9OrZ1WyDfc4cc6 lwxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680646170; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ypW3uCkatd85laSwJoEHyhvz6A6Q9ytym+XuTNT93dU=; b=ANtfveGjZRa5tYAvuuHVG4Hryu3Rzln41jmSrPOaSaIZ++2YwARl/MWLFKTEyhQUgc +K0/QoBq9zJ6hpxqBpD0ZjYD4qAjil83T0v4Pk3cV8ZFXE+AYsE11KqldTkXXgK/nA9V 0SqcTKgMFlcFxsOqRrHU43MzJcxmilATDvHAs7vyVqLcg7eTtz6NenOV9GhJVO9ae/xu W+09BGTjYD1dE7v0oOspjU21zhXwscbhn3aBgiGJN/LxTZeULxWBzMA0LnabHL/Ym937 CnIEPJUb+fsy56MJRi0PQKmWlYhzlvZBNzrEPZSrPldbbX+TBkLMYq9IMKe590fPdDno 12AA== X-Gm-Message-State: AAQBX9edGyp/4B66pvJsIOGp873bnbIKqGP196Rh/SjJrze9LmPXNTRO 1NJwFwh3zzeVldIzyq6qp36jJYBQRHXrH/TjBAg= X-Google-Smtp-Source: AKy350auMB5aAW5vcPRu5Z3zk0kCG0J70wFTxHDdx38zTGhfy79hnQwCL23EHjo5fAbzVlHyZYpeRiAzV27aaZOYeGI= X-Received: by 2002:a17:902:8604:b0:1a0:48ff:539c with SMTP id f4-20020a170902860400b001a048ff539cmr1636900plo.11.1680646170341; Tue, 04 Apr 2023 15:09:30 -0700 (PDT) MIME-Version: 1.0 References: <20230404084308.813-1-zhangqing@loongson.cn> <20230404084308.813-2-zhangqing@loongson.cn> In-Reply-To: <20230404084308.813-2-zhangqing@loongson.cn> From: Andrey Konovalov Date: Wed, 5 Apr 2023 00:09:19 +0200 Message-ID: Subject: Re: [PATCH v2 5/6] kasan: Add (pmd|pud)_init for LoongArch zero_(pud|p4d)_populate process To: Qing Zhang Cc: Andrey Ryabinin , Jonathan Corbet , Huacai Chen , Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , WANG Xuerui , Jiaxun Yang , kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: DA56BC000A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: yo5y4s3z4iyksq3ng768d6om1891pcy4 X-HE-Tag: 1680646171-437252 X-HE-Meta: U2FsdGVkX1/tj82fbEqfOX3AqfP/ITdw+gHsig6aKJZAOE1S47vmX7l3ADHT7wgZSp7iM9EoMv60jq3ni08wgvVaV8GvSYHk77rQeEJSuJCoac3zpuHVT5DZFa59hrRq7X4Sc+9IdQvOZK0gw4SwfVU3+CRUVdniBfmhNH7nmfquK0QJUptvgyKhmbSQPyzHGbdu/g/A2mIhJnipeab4izeSUS5037YXE+r1VoknuGsQBXKq4W8SiKw3djhTPNJKxAV2k4/zGYV0ib6wAZdjulSeNd29aESw8ytDVt/dvkPxHJ3xHwyCKrtWqAy+2Er89FOhJCQB2yvRvItySOxKqnTMGG7b2AHlTyHpJikePTURDOJb17QPmUaZBI+acpWVvGIEyIO7OIudEY4HOl7be/KXHk9YC99ntzZ7ea4LGUMTF/WU4Q4B828zFzacFjHeiEM1gA869FCBYQj7HCaP5YQ+gUhksh2AOPG30RC7N1qcCuB3vpo5dmDNSOeihiZfvT3fbfrQQz2WACGj4k2dFzKUvKl4NsjxWhrff1EQHCpu7a0UiyYz3f5nP4OQ5bMuIcSJSpGc4soIgYbiBETpr/V2QvvgTgSTTsWgJ4ZekI2uF8vN4dMEZuk84rpAT0RiDiJdEIdFIi9PdWFe3zraK9CBDHkCMTjzE71xpLwbgKns/DIgw6SAweqkBDgm+/PDJyqLDPBHQDoaL6FeWj0Gv/vu6RkzbEDsvj4hNpONJy93qSyKosbj+ZwlpNblF+2ArF7ipPIc2wvsNnYxYPW/+ceJboRRvE1necCEL/bWEA6sNB7IxtJ83rh05HFsQox93vEw7buDemLrfk7y9syqxseE+4zYNcE6uFIr2kufEJubVBtYaSF2f44IG5gpgKmklIbmNMFz1HLr87G9ShgwScUwG7sxghYsAhMnYx75B7TgN6pV9xoILU2c4TsXWEVSMqYZhMkudzRcsB3APh5 oyr++ne0 tJxQdp8JORAp88q/X1KPPtB0B84aIpEq6zG5Wo10QYjy9lbcO6tDhfMxeVVwd6HJD6gvBWd7u8J6gJ9e3J/VUMR0tdYfA7k12Kr/DFcqgFtcuIyH5lgqBskrOHhJUN0HWyF0meqyMzwnsNGMgLJ8M1arduA7E4AY8lN27MNDydbKEWK0PRuKb9ZUdPTKg4KbXwUZSN+XLD3GWFVqyAcrXmb1aJ1S4W/Iffe1FoRMOd2kcgiZt/E4ZVcwlTf0Fs4wkHIdc1RM3j1Cs0VxNMpST/S6K9edQfiVsCFPBezy4AM080soopXtS52uc18NX9Dy6Z61PL7/GCYljLM67Ygfz7tsj9g0m6Ne1gzzk3PcUY40iCiYM/jgFT/UW+fCzNcjaDRashP0UQlVpnyqs8O6pJoKPiGe4qsQdO/TwYHuvqQWKgnnL8LQvwnXLDBNGnG5ag+hwSr3xjrbeXdlcgYL0rpsZoghtF0t/nsCZZuuiJwosDoudcEonueY5nEoqhIknyQKN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Apr 4, 2023 at 10:43=E2=80=AFAM Qing Zhang = wrote: > > Loongarch populate pmd/pud with invalid_pmd_table/invalid_pud_table in > pagetable_init, So pmd_init/pud_init(p) is required, define them as __wea= k > in mm/kasan/init.c, like mm/sparse-vmemmap.c. > > Signed-off-by: Qing Zhang > --- > mm/kasan/init.c | 18 ++++++++++++++---- > 1 file changed, 14 insertions(+), 4 deletions(-) > > diff --git a/mm/kasan/init.c b/mm/kasan/init.c > index cc64ed6858c6..a7fa223b96e4 100644 > --- a/mm/kasan/init.c > +++ b/mm/kasan/init.c > @@ -139,6 +139,10 @@ static int __ref zero_pmd_populate(pud_t *pud, unsig= ned long addr, > return 0; > } > > +void __weak __meminit pmd_init(void *addr) > +{ > +} > + > static int __ref zero_pud_populate(p4d_t *p4d, unsigned long addr, > unsigned long end) > { > @@ -166,8 +170,9 @@ static int __ref zero_pud_populate(p4d_t *p4d, unsign= ed long addr, > if (!p) > return -ENOMEM; > } else { > - pud_populate(&init_mm, pud, > - early_alloc(PAGE_SIZE, NUMA_NO_NO= DE)); > + p =3D early_alloc(PAGE_SIZE, NUMA_NO_NODE= ); > + pmd_init(p); > + pud_populate(&init_mm, pud, p); > } > } > zero_pmd_populate(pud, addr, next); > @@ -176,6 +181,10 @@ static int __ref zero_pud_populate(p4d_t *p4d, unsig= ned long addr, > return 0; > } > > +void __weak __meminit pud_init(void *addr) > +{ > +} > + > static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr, > unsigned long end) > { > @@ -207,8 +216,9 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsign= ed long addr, > if (!p) > return -ENOMEM; > } else { > - p4d_populate(&init_mm, p4d, > - early_alloc(PAGE_SIZE, NUMA_NO_NO= DE)); > + p =3D early_alloc(PAGE_SIZE, NUMA_NO_NODE= ); > + pud_init(p); > + p4d_populate(&init_mm, p4d, p); > } > } > zero_pud_populate(p4d, addr, next); > -- > 2.20.1 > Reviewed-by: Andrey Konovalov Thanks!