From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFBC3C433EF for ; Mon, 6 Dec 2021 22:02:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EFEA6B00AC; Mon, 6 Dec 2021 16:49:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 59F0C6B00AD; Mon, 6 Dec 2021 16:49:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4192E6B00AE; Mon, 6 Dec 2021 16:49:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0102.hostedemail.com [216.40.44.102]) by kanga.kvack.org (Postfix) with ESMTP id 2FE786B00AC for ; Mon, 6 Dec 2021 16:49:15 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 007A5894A3 for ; Mon, 6 Dec 2021 21:49:04 +0000 (UTC) X-FDA: 78888710250.10.BA20427 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf20.hostedemail.com (Postfix) with ESMTP id 94E0DD0000A2 for ; Mon, 6 Dec 2021 21:49:04 +0000 (UTC) Received: by mail-il1-f175.google.com with SMTP id s11so11737509ilv.3 for ; Mon, 06 Dec 2021 13:49:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NRJ2Vq4GGEkOM9Z1L10C4gsdtd/cSS7963Dg1Lu81Vk=; b=O5oU/P9UojrjXnhFmSvebt4u3yIwBjy9ZlVDmW2FwCSlXQrNXuaD5T/r9nc5B38xCC UMw4UWCvWApqBXQs8X9vUho2pXiJ4diAJCIr8xX7ADGWbe4FgvqHeX46y5DNIL24PHuy KND30Hj31SIu/p3zJF9C6XBrKl1mLUuVXzlLthev7jJ3x/BuYvZhiRb2zPUL2H56ppZx y6Gdqj5bVS6v7rIjtVj5xZ2hTsPKnqoa/W76ijNxPLz6eNS3WJ9arjEZFwwflsbmOS9L mDNgAiqFm6UWSSn1UjRoKsP2Q8nKE5f3dVaHQMTa3Xiwg/GrkMABpHDz/c4kCfoFG+PN sW1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NRJ2Vq4GGEkOM9Z1L10C4gsdtd/cSS7963Dg1Lu81Vk=; b=xyfxM5a8fJmhewKgXCKCNaNMCTOepv6m90UIfFNurTsnVYtZBHiDbgSoXGAzAUfqRz 0mVlFtKFKOK8lyFDkpCtJbqhMTiPGidHRAYTAptA/Sn1XEhJwVEU7EOTOfRtpl+hNWWI x0p2oB6Rj44NqstlVxkEs5U82B6VltU80HBDSKq2lVv/geg3eDPegjjE7ZZla25LbkQZ NQ840Mw5+9oDUsIZWkGhVr7vxsCxXllrnXR7Uumw4TPBl5M4v04kM1BHxaz2H+vNhFJ5 RlK1ps14BRDdpCrzmbgEEL8icQvYy8Wowdu+Mt9PxtQ7YLEE4AcXyxFO6N8SkBj8DxSs HvYw== X-Gm-Message-State: AOAM530VJlLjHSwEJPseiE3Nf6gOzijtf10KiGw5YQ2E1W7WeloaqwTz otG/YgnDz2lVw/O0E9UnIBd6QiGEV5w/kpaBu1Y= X-Google-Smtp-Source: ABdhPJyn5Di1ZCOMfCFI/yFYRKjnMDY8M7gCkGqKV4X0AyAj2tgSO/+Pf2Qsr1gPkUE3JoF1Ul+gUi8goVPxCOcZfqU= X-Received: by 2002:a05:6e02:1605:: with SMTP id t5mr39279632ilu.233.1638827343979; Mon, 06 Dec 2021 13:49:03 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Mon, 6 Dec 2021 22:48:52 +0100 Message-ID: Subject: Re: [PATCH v2 24/34] kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged To: Vincenzo Frascino Cc: Marco Elver , Alexander Potapenko , Catalin Marinas , Peter Collingbourne , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , Will Deacon , Mark Rutland , Linux ARM , Evgenii Stepanov , LKML , Andrey Konovalov , andrey.konovalov@linux.dev Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 94E0DD0000A2 X-Stat-Signature: 18f9axqonkxmhif94pfkckxaipp5rqux Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="O5oU/P9U"; spf=pass (imf20.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1638827344-343843 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Dec 6, 2021 at 10:46 PM wrote: > > From: Andrey Konovalov > > HW_TAGS KASAN relies on ARM Memory Tagging Extension (MTE). With MTE, > a memory region must be mapped as MT_NORMAL_TAGGED to allow setting > memory tags via MTE-specific instructions. > > This change adds proper protection bits to vmalloc() allocations. > These allocations are always backed by page_alloc pages, so the tags > will actually be getting set on the corresponding physical memory. > > Signed-off-by: Andrey Konovalov > Co-developed-by: Vincenzo Frascino > --- > arch/arm64/include/asm/vmalloc.h | 10 ++++++++++ > include/linux/vmalloc.h | 7 +++++++ > mm/vmalloc.c | 2 ++ > 3 files changed, 19 insertions(+) > > diff --git a/arch/arm64/include/asm/vmalloc.h b/arch/arm64/include/asm/vmalloc.h > index b9185503feae..3d35adf365bf 100644 > --- a/arch/arm64/include/asm/vmalloc.h > +++ b/arch/arm64/include/asm/vmalloc.h > @@ -25,4 +25,14 @@ static inline bool arch_vmap_pmd_supported(pgprot_t prot) > > #endif > > +#define arch_vmalloc_pgprot_modify arch_vmalloc_pgprot_modify > +static inline pgprot_t arch_vmalloc_pgprot_modify(pgprot_t prot) > +{ > + if (IS_ENABLED(CONFIG_KASAN_HW_TAGS) && > + (pgprot_val(prot) == pgprot_val(PAGE_KERNEL))) > + prot = pgprot_tagged(prot); > + > + return prot; > +} > + > #endif /* _ASM_ARM64_VMALLOC_H */ > diff --git a/include/linux/vmalloc.h b/include/linux/vmalloc.h > index b22369f540eb..965c4bf475f1 100644 > --- a/include/linux/vmalloc.h > +++ b/include/linux/vmalloc.h > @@ -108,6 +108,13 @@ static inline int arch_vmap_pte_supported_shift(unsigned long size) > } > #endif > > +#ifndef arch_vmalloc_pgprot_modify > +static inline pgprot_t arch_vmalloc_pgprot_modify(pgprot_t prot) > +{ > + return prot; > +} > +#endif > + > /* > * Highlevel APIs for driver use > */ > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 7be18b292679..f37d0ed99bf9 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3033,6 +3033,8 @@ void *__vmalloc_node_range(unsigned long size, unsigned long align, > return NULL; > } > > + prot = arch_vmalloc_pgprot_modify(prot); > + > if (vmap_allow_huge && !(vm_flags & VM_NO_HUGE_VMAP)) { > unsigned long size_per_node; > > -- > 2.25.1 > Hi Vincenzo, This patch is based on an early version of the HW_TAGS series you had. Could you PTAL and give your sign-off? Thanks!