From: Andrey Konovalov <andreyknvl@gmail.com>
To: Yu Kuai <yukuai3@huawei.com>
Cc: Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux Memory Management List <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
yi.zhang@huawei.com
Subject: Re: [PATCH] kasan: fix doc warning in init.c
Date: Sat, 5 Jun 2021 23:15:16 +0300 [thread overview]
Message-ID: <CA+fCnZewY8MNf1fWaTg0VLwSivEejn1-msRXiuy7WGXApfBJYQ@mail.gmail.com> (raw)
In-Reply-To: <20210603140700.3045298-1-yukuai3@huawei.com>
On Thu, Jun 3, 2021 at 4:58 PM Yu Kuai <yukuai3@huawei.com> wrote:
>
> Fix gcc W=1 warning:
>
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_start' not described in 'kasan_populate_early_shadow'
> mm/kasan/init.c:228: warning: Function parameter or member 'shadow_end' not described in 'kasan_populate_early_shadow'
>
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> mm/kasan/init.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/kasan/init.c b/mm/kasan/init.c
> index c4605ac9837b..348f31d15a97 100644
> --- a/mm/kasan/init.c
> +++ b/mm/kasan/init.c
> @@ -220,8 +220,8 @@ static int __ref zero_p4d_populate(pgd_t *pgd, unsigned long addr,
> /**
> * kasan_populate_early_shadow - populate shadow memory region with
> * kasan_early_shadow_page
> - * @shadow_start - start of the memory range to populate
> - * @shadow_end - end of the memory range to populate
> + * @shadow_start: start of the memory range to populate
> + * @shadow_end: end of the memory range to populate
> */
> int __ref kasan_populate_early_shadow(const void *shadow_start,
> const void *shadow_end)
> --
> 2.31.1
Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>
prev parent reply other threads:[~2021-06-05 20:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 14:07 Yu Kuai
2021-06-03 14:16 ` Andrey Ryabinin
2021-06-05 20:15 ` Andrey Konovalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+fCnZewY8MNf1fWaTg0VLwSivEejn1-msRXiuy7WGXApfBJYQ@mail.gmail.com \
--to=andreyknvl@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ryabinin.a.a@gmail.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox