From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B66F8C43334 for ; Mon, 18 Jul 2022 22:41:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3359E6B0073; Mon, 18 Jul 2022 18:41:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E4AF6B0074; Mon, 18 Jul 2022 18:41:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1ADA28E0001; Mon, 18 Jul 2022 18:41:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D6F56B0073 for ; Mon, 18 Jul 2022 18:41:32 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 6E4958017B for ; Mon, 18 Jul 2022 22:41:31 +0000 (UTC) X-FDA: 79701693582.10.B3D4A82 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) by imf20.hostedemail.com (Postfix) with ESMTP id 1BC541C007C for ; Mon, 18 Jul 2022 22:41:30 +0000 (UTC) Received: by mail-qk1-f169.google.com with SMTP id k7so7007409qkj.2 for ; Mon, 18 Jul 2022 15:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ISQEQ+fIU3xAcRWcqutk61dQJfgUByc+o/p0/o9VaqQ=; b=IH/FZ8SrUXP2dDYcRxYo5hHvEHRDVPafx35U/9ZnUzKdYONMPijudkIJgyNp/P1eqS Vz+6KL7fWpehsS1cZaRejfGyFWa9vLodhJW54WnzQEK190wK7fzCpe4PgSrQWHAWy7LD 7P0Jn3c54BPUPIYPFib731YYvXf1TFuRIGIS/T7kyWo5aD/jaGyK+zZC7wKvmgenhRkO V1YUIwQj5br4kxCvuQZPcJDR4aEDHWvE+ePOZLsmgkHnzwZjCXOvCQ/99BF64hkTG7qd eJEAXPCtQMqIXm1OH4M7jazorAiFE6SEzkdjAGKvnw7iGZ69My6Qo5IOfomFGWEVisqU vo6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ISQEQ+fIU3xAcRWcqutk61dQJfgUByc+o/p0/o9VaqQ=; b=QkV0ikct8TcX6YSTH0YKCs+sYPvnAoZ3ucV0M0eTFa4Uni4wXi3BQrYq9ajpg22+xA GprUqR/wTrjmxEV/3fZk6YjOFHYaJhuytU46x6UJMqlySe7dbSIZm42wmIGCxq0lxw9U 0Tk2PYclSZYvQgZjB7JZNuN6vy5CRqizkJ4QiFxfZQhkHuU3CTVmd4404V1m7TcEUM73 BK0zlL9yDrjnazFCOZ4DumcGxReBEwc4tayDw6UHQa5/tpfn0Ql/OvCRP4bXJo40ItML iKpvPrcN+6H5e5LI4eC7RRr5lh0Nn+dw1u4qY8sjS6jQeIocgZbZwN8Q76ys3w18GNuQ ql3A== X-Gm-Message-State: AJIora+UtYTT3LZj8nIYCuNyVxl94rCPl/niBn59ECU5vnIlRin2bHRW cjmE+KG7FOGKDx2R4dg0E+U/0T9Cm2fqyjG98zA= X-Google-Smtp-Source: AGRyM1tSoqflDUr5Mg2xHUPRTTAzjNKYxv+S53Qbj3gS0KL0JvYKrrffyaAXoiFit8+UmyC/nTzU38aOfUyQ4tXScMQ= X-Received: by 2002:a05:620a:2807:b0:6a6:6ef1:fb9d with SMTP id f7-20020a05620a280700b006a66ef1fb9dmr19234367qkp.146.1658184090436; Mon, 18 Jul 2022 15:41:30 -0700 (PDT) MIME-Version: 1.0 References: <11a7bfb5ed5de141b50db8c08e9c6ad37ef3febc.1655150842.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 19 Jul 2022 00:41:19 +0200 Message-ID: Subject: Re: [PATCH 06/32] kasan: introduce kasan_print_aux_stacks To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1658184091; a=rsa-sha256; cv=none; b=Yjd4o02/SHjrd/HcSA/23O7liHNd+4Vo0D30bwpXGWUc7Ac3BGSDFA7dC+O+GTNuyXq+gI 9/iN4uHU5sfu8Es5LFJp5pmLTOdGKst/c5AlYa3qbNfiIBPIPmT2FkzyPfYK5hfNqdZASQ 6DwIS130LOAcaNzSGsmuPCZn2t3zrZU= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="IH/FZ8Sr"; spf=pass (imf20.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1658184091; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ISQEQ+fIU3xAcRWcqutk61dQJfgUByc+o/p0/o9VaqQ=; b=ErpgeuZBKlaJ3/bGlnaCuVvVu3/UhPQ/wFUvXPSAxyk8Z50En/i6mKiJtHkzmg8Y7dA8h/ vxJ1jYlDC37jE+nroS2SgbE52FV/17SCPTKvxbD7zhQu/WRLZT/gMEAJVlI+DdPY4M8BrQ DOlV8pSfx5DH6FH5AQncWZML/g7Wgow= X-Rspamd-Queue-Id: 1BC541C007C Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="IH/FZ8Sr"; spf=pass (imf20.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.222.169 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: cbjubethsckfpg3wxfycgkoe3ojbgku4 X-HE-Tag: 1658184090-880313 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 17, 2022 at 1:35 PM Marco Elver wrote: > > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > > index aa6b43936f8d..bcea5ed15631 100644 > > --- a/mm/kasan/kasan.h > > +++ b/mm/kasan/kasan.h > > @@ -265,6 +265,12 @@ void kasan_print_address_stack_frame(const void *addr); > > static inline void kasan_print_address_stack_frame(const void *addr) { } > > #endif > > > > +#ifdef CONFIG_KASAN_GENERIC > > +void kasan_print_aux_stacks(struct kmem_cache *cache, const void *object); > > +#else > > +static inline void kasan_print_aux_stacks(struct kmem_cache *cache, const void *object) { } > > +#endif > > Why not put this into one of the existing "#ifdef > CONFIG_KASAN_GENERIC" blocks? There are several; probably the one 10 > lines down might be ok? The idea was to group functions based on their purpose, not on which mode uses them. Here, kasan_print_aux_stacks() is related to printing reports, so it goes next to other such functions. We could rework the order of functions in this file, but I'd rather keep it as is in this change. Thanks!