From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6781EB64DD for ; Wed, 5 Jul 2023 13:19:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 038648D0002; Wed, 5 Jul 2023 09:19:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F2C348D0001; Wed, 5 Jul 2023 09:19:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E1AEA8D0002; Wed, 5 Jul 2023 09:19:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id D69F58D0001 for ; Wed, 5 Jul 2023 09:19:22 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9962DA0B83 for ; Wed, 5 Jul 2023 13:19:22 +0000 (UTC) X-FDA: 80977614564.27.4078DE0 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by imf14.hostedemail.com (Postfix) with ESMTP id A720510001D for ; Wed, 5 Jul 2023 13:19:20 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=asQQxGjG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688563160; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dHD+gumzoWP+nl3VtSqoKGEKW4lPTUyBTvzSxtXSgic=; b=lDcwIo/Gb9s+zghab56LgFdjjTMLbRLeNDBQ5yX9hlmDTpdBVVVZsBmUVS/B+a/dX8k72F 7a5jchDHD7cLAEh/QDI4RSuLdWZ9MOqsxHdla54P7nrXoJqMlwmnKbqiZVz4WTqTKPD7he R41pQVLir5uKAk8eSekAuCtF/kmrFzw= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=asQQxGjG; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.179 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688563160; a=rsa-sha256; cv=none; b=im4eFzCO5880yJEwuauFMSVuzXN8vTUrbX36Nf7LZ1qbc9R/EpwbCELSq6cQXmB3HQpdM6 q7wJo+vbXEHAy2Q6nNflIJTqSFTuCaINi3N8k6naOvuEqWNq6I6zLvr2/QDfGPuuzU/gDb vYk2/fGDkJC7jdgrKzJLr4BsmsVZevM= Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1b8a8154f9cso5217465ad.1 for ; Wed, 05 Jul 2023 06:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688563159; x=1691155159; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=dHD+gumzoWP+nl3VtSqoKGEKW4lPTUyBTvzSxtXSgic=; b=asQQxGjGoyEoGcp0NIF7Aq/cB3t8GLX4OuYOJWGn/pxr5hkHba1+Vtu62kNUqA3ANS cbt3exB8yJCokdcq3izXIcpAt6HmIxDv7B7EUBfJLMFm6a5y9kLjSMQdA5t7Ud/jGXsM 8bNCd8+pnLMgVeuQystG16cJbyHeoNl0grbUkXBgLveBWatIchIPKk0ARqfT4jxJnYXM EfqwIZ59JOWRep7p1bT0wZBk4wQB9T1Xg5XdQbWHg0wztHBylfFnLMMJVPHeRDdlDDiK vxc5RCHbyVuf4onWIeE9whQt2lTa/Cu621QMa5e3sEOW16rXVPIb4VmCPwI1xfB/P7Mm mZVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688563159; x=1691155159; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dHD+gumzoWP+nl3VtSqoKGEKW4lPTUyBTvzSxtXSgic=; b=McrNjPIwr+WzIoETkVYGPRBhjWxfYhejmcF4PgX646XYVz1Wfc6bRPYVpeUsurjb1p ZhHKkBwZTWKXg2m9rX88t1qn0dCNJd9VPxWVa4fXfF+ogHkklB47Rap/yEP1W6DYaBPS JgrvLyknpKCrYItx2qG0E3nv3gRPMxky26ZThor9VnOCSxWNvLiYBLOTYY7r+OnhHHMM IERpDzmmyY7KyNzEKchVc0UgJoLyO1sa0+V9hfllgVE7YalyaTfBqxQzf/qErlZEBv+f godONoj73BM2abhuMVB6Rr5o+LFHR92J4nk8mbli0CTB3c0ufMZ58lSRuh43JLJZgaJ6 rNAw== X-Gm-Message-State: ABy/qLZ88O5Il1A+FB7N5MAdxr0LYrpJJ/5MM/g2YXFoyFvUGqtG1f43 En4feoPytZLAHNQZdzqOnCJkgNYo3KoNNZ0+nCU= X-Google-Smtp-Source: APBJJlFMxcKhkpFMy8Afh17cwFaJLPJkAfv85FqPfqTqtaMzLuDJiGQDW1AWfQwv+AvoCm9fDTTPpplJMQAZhEYfJF0= X-Received: by 2002:a17:903:228d:b0:1b8:8d48:958d with SMTP id b13-20020a170903228d00b001b88d48958dmr3547209plh.1.1688563157269; Wed, 05 Jul 2023 06:19:17 -0700 (PDT) MIME-Version: 1.0 References: <678ac92ab790dba9198f9ca14f405651b97c8502.1688561016.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Wed, 5 Jul 2023 15:19:06 +0200 Message-ID: Subject: Re: [PATCH] kasan, slub: fix HW_TAGS zeroing with slub_debug To: Marco Elver Cc: andrey.konovalov@linux.dev, Mark Rutland , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , Vincenzo Frascino , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Catalin Marinas , Peter Collingbourne , Feng Tang , stable@vger.kernel.org, Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , Hyeonggon Yoo <42.hyeyoo@gmail.com>, linux-kernel@vger.kernel.org, Andrey Konovalov , Will Deacon Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A720510001D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 7je3hxyjbsngypxghpebwjesymmodgnc X-HE-Tag: 1688563160-189402 X-HE-Meta: U2FsdGVkX1+BpZAH2T0/xnrApobFnVvOtu6zBRXq4tLRGMhN0RXSQgNwY10tLra1QIMeO9lHq+z7iyrRmn3kDjj8TQR22k3Trd+kawPCx5H7jBKxOo7lNC3Gudqj1SAwBp2BepwslewfHA7eFsXlI4S7zfZAAiajhn7kiQe9Ypi9HEGm04Pol5bOz4GfgpCiK9M94nKMyXeSUzI30qdogelT2ACnjisvL/estedhyfrhI3NyIcE7wWv8iCOncoeTNvD9NrusfG5uLohOHD5ppXUPRaf/qUwIee811U4liiNrAMns1a+6bPLj6tLGFzoBhNVbPTg7/+uBzaRZTQrxMGkCiQ2VTyDdue5axYI04Lqrj1nSGz0jwuWWGWZRdOqJOXRMcARZF4UMNyWnHtSnLzmOwxy81MJSM8hH6IVtQet9jN0+i4CiNpUPBTo/SrlmGtGWI+dcjt7obrVPPYVN1hb/gLEfncrSpiNre4p4dOB4qAxLhlLdLt152HIgR8aKZO0bKTpWRmN1pESK/IJQcl28t6x7mIBZXwdsQe/2c/pQxMZ5/Fd9WhRKum/fKgLylBKuMUifw4DUVCzmEnubGQjBeuRARSwN3tvnbkIz/PfF0vDTESLO/i65I1AXZs/xQFT55yofmmLC3F0KmtpKFxn7VsXiUVZ8QRbNuHohHP0XhggOMOcAZ1gNAJ+/l63+1X+kffOnPI6qq+BW2IL9TC8Epxckq1n5TYHLhpXghmZUhpCuuO2qNQJjCcf94wZ6+MaZMjhQj81kbotLCXr9iIOqS0McQ7aqiHHGVBVHuTLNm3Rde7ZelhIku5da7UG/1aGthuDVsCFceJYMORR1ixjJ5U1hAx9H8VAtzfaFiLhAtqBuHJlvwM5zqgW6rvUK6QhUiPC9iJpSvQllrnTFlRnXhUAO3H0lZ1PVdJf+awCV2q6zGfBBjuuqRWP8XE7uMkmMVp7gybN1jrYP1eS yS0BZATL 6RZ4Nd2/rmxZkGAdrBbIENWubhQzxjwReEo+lw3jinfPzIUDUhOefPPVcrpDwA7HRa5otQCuqsk6z3sE9y1BwBJKm9XlXImmz3cafn0cM3ED5CWN+gzsbtHFmJegigK//n4DmACkkT+yeGeIKIvTUFDGKoiMay2880l+hf6trzsZ9STvTlLthHdqmFz4SGUfkfiZDZcWOyGnLa7zUwhlDLuiX1N9dQ3wbAH6M0L/Wt+m+C81UrW0wbNfNaEf4OAYLvFbT5WodWBvlniUB0W0IS92jgvjDZ74Y6yHOcxBzmdW4MniHZNaNYB6JIwazy7Sk7kSa9KgjrAjbCMVmMZ5wzXPTRbVEJpW4JAuZZLmeOyhZ/ZEpRm/2Yq+nZOJ5KSl1zHfVpVoBmEa1KvIYKfnIhgnq9SfdBqjsiEhl+V9RaAJSJ8f5LD4PtWM5tEUWNkq6OyjqqG3gY0TH+tuNTwkXksc9MiJP8l2LNRBsO8O/PNEQxBYl9SG2oEt4qOQLMozLdHw6UgemIXSDM8tDrovyQN9nSjf8dbT05dZWUKFUIj1xb9cpbbgFYUAhZWtESgk/phc17sdgfGEYObq1kzal6aXe+VrZwzxSKG4mEkc9jshSVnE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jul 5, 2023 at 2:51=E2=80=AFPM Marco Elver wrote= : > > On Wed, 5 Jul 2023 at 14:44, wrote: > > > > From: Andrey Konovalov > > > > Commit 946fa0dbf2d8 ("mm/slub: extend redzone check to extra allocated > > kmalloc space than requested") added precise kmalloc redzone poisoning > > to the slub_debug functionality. > > > > However, this commit didn't account for HW_TAGS KASAN fully initializin= g > > the object via its built-in memory initialization feature. Even though > > HW_TAGS KASAN memory initialization contains special memory initializat= ion > > handling for when slub_debug is enabled, it does not account for in-obj= ect > > slub_debug redzones. As a result, HW_TAGS KASAN can overwrite these > > redzones and cause false-positive slub_debug reports. > > > > To fix the issue, avoid HW_TAGS KASAN memory initialization when slub_d= ebug > > is enabled altogether. Implement this by moving the __slub_debug_enable= d > > check to slab_post_alloc_hook. Common slab code seems like a more > > appropriate place for a slub_debug check anyway. > > > > Fixes: 946fa0dbf2d8 ("mm/slub: extend redzone check to extra allocated = kmalloc space than requested") > > Cc: > > Reported-by: Mark Rutland > > Is it fixing this issue: > > https://lore.kernel.org/all/20230628154714.GB22090@willie-the-truck/ Yes, my bad, messed up the Reported-by tag. The correct one should be: Reported-by: Will Deacon > Other than the question above, it looks sane: > > Acked-by: Marco Elver Thank you, Marco!