From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9071AC021A9 for ; Mon, 17 Feb 2025 16:30:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22676280070; Mon, 17 Feb 2025 11:30:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D67128006F; Mon, 17 Feb 2025 11:30:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0C75A280070; Mon, 17 Feb 2025 11:30:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E01A828006F for ; Mon, 17 Feb 2025 11:30:00 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 6B83EA09BE for ; Mon, 17 Feb 2025 16:30:00 +0000 (UTC) X-FDA: 83129973360.06.99DC98C Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) by imf11.hostedemail.com (Postfix) with ESMTP id 4A7B740006 for ; Mon, 17 Feb 2025 16:29:58 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FHGHvPyD; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739809798; a=rsa-sha256; cv=none; b=lPuO9GyaeF56Eo1hrMAmjB2bQSrxGvxefUmuSvJtCeSlsJcSQFXF4BwulRqPk2FB4KnYlg xqX2UzIMCp6mlNn9Ct2FCQnBm1bz7NXZydmD/GguYZSopnrnPE1dVV6zde6ALTzrOcqimf yyaubZ7UKTA9hq0BlRVHMUjwtugDLGQ= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FHGHvPyD; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.51 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739809798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pZQb2m4LI3eZ0whbBX38Hfb+TR1d3xUyfma8FbMenc8=; b=o+aETBv6KB/sBhE1Fw5+a5itf2DgaxrKIbMTfaLmbnKlsBGEUUXMYRh2Df6MBMna4Qpo9m XhdzP3YIZwotbzxs68ZL5C1UmZR/N69moI+JUipJSA105TN+qqC+1WsHihOqKsnMMTp/aY jIp3tfAE2R2hI/qTNT86rg9UiQDGEdA= Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-38f406e9f80so1207783f8f.2 for ; Mon, 17 Feb 2025 08:29:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739809797; x=1740414597; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pZQb2m4LI3eZ0whbBX38Hfb+TR1d3xUyfma8FbMenc8=; b=FHGHvPyD634JXRBdK4/3LJgMyqbqHuHETRZ0c4EJuSRYZh+N1BTuTu55yUyhpW+zto SRF182dB2urFzmxpmjabVcAbLeGKRxcwaF+1JoK75oozS7r3oX5rdRVZdqnaJV0tecfs cj1QGyAQF2NVFSySTbovhKupD+FlMJMm/E7gxdcAg3VA2tUOAh3R4NlaNYkcM/4GyVur dI8FAi+kuurfeKDwBQ+7wWYH5FIhp8gyuMI9Yh9NPwtrT0jQefvXXZFOTib2RMphTxeZ kgQBZg+db0hnbNwiYd7j2ZhYlUg3atejQ4XkbGklijX3fccEJu8gcw09+9k9E2x8Jk/0 6oUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739809797; x=1740414597; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pZQb2m4LI3eZ0whbBX38Hfb+TR1d3xUyfma8FbMenc8=; b=HVOYcID0aFtSfJnRAwUZavZhDlGqFNJTQCEWdTTf00f1Q0BfV7jVyTQQVOVYermiEl T/TL3cfAJZJFQyofOHUFVx/Z+VE5p5bXYb+y7y7qiHDv6RPiZtTYZ9aK30uCwJtbeTbz 6bVICtiGcLp5tQsbD5TE09AQnJ4izIqmKYgoRGuHrJCzYpPk85dNcDJiQayUy/d5T1Rs WLeYeoRIzC4P6Dge5C1iq7dy9fvoFjdNvoHH6INfyVQgtw+I1A+hBRFcZh+LzqrG4ExJ v2Gj2ieV115H+zf/k5+5t7b23G5Sv91JGTulIwmC+kYPQdGY9QJzzeK7W5uGzbS3Es76 IFlg== X-Forwarded-Encrypted: i=1; AJvYcCXLz1alDp4Dy0quS+P2+BFq/yuQHuTM3tDkJKnwm0icSEW3adDKwO3/WDO2+Be8ks4zk+abqLVocg==@kvack.org X-Gm-Message-State: AOJu0YzXXghzFPwnU9B3/gPgAf8rbWpQuBuedvaFlc222ZkpXwkIN0CU uReGWEGcCJsqzxvliJxIZN7CCiXfOCTs/dKYo6LIknKVGUhA+M4HKvBJSxYzkfAtAR/ALtZaWno hw2S1Hplc44LysIxaztHuWbLbyleOww== X-Gm-Gg: ASbGnctKQJ0kRcOuBl6Lzc4NgIFBSXz5bs7tiJ+Ys5be0tzI9uOpgcwafD0pRVgnkE+ DTbVLwa6Si9BWxXo02R69yQY/iC4zLsmnbqVOjmPSNljqvaQUQB4Q9q2izuULQgJMqOYYsYHx6F k= X-Google-Smtp-Source: AGHT+IFPGojklZ8rX6C2jIUVXuI7Nu18SntXvHS3iftVKfpo60nJI733DAqjbgFpNf/qFXWucoMCahPUZAaAlZWrVQs= X-Received: by 2002:a05:6000:1fa4:b0:38f:3d10:6ab7 with SMTP id ffacd0b85a97d-38f3d1072b9mr4816691f8f.23.1739809796774; Mon, 17 Feb 2025 08:29:56 -0800 (PST) MIME-Version: 1.0 References: <20250217042108.185932-1-longman@redhat.com> <20250217154309.C2CMqCjE@linutronix.de> In-Reply-To: <20250217154309.C2CMqCjE@linutronix.de> From: Andrey Konovalov Date: Mon, 17 Feb 2025 17:29:45 +0100 X-Gm-Features: AWEUYZlZbQRUYlLo8ZMq5M3z45K6gh8vpPysxswkL9MmuffmUF5lc2K91cMG2qk Message-ID: Subject: Re: [PATCH v3] kasan: Don't call find_vm_area() in RT kernel To: Sebastian Andrzej Siewior Cc: Waiman Long , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , Andrew Morton , Clark Williams , Steven Rostedt , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Nico Pache Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4A7B740006 X-Stat-Signature: wcs79r7jzoxpysysdedf815m3a3f637u X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1739809798-374361 X-HE-Meta: U2FsdGVkX1+1oFDiEeNVJtusV3BIyJR66SgqH0UAbnrdfROkAR8RLlJrmED84zEXDZlzRPVA3Rj4d0X1K/whR216TmIxQ9/kmJfgClMkFHpLUDhsrYRw7sdOTKiThMeEFrazxaKuSls6xwFGiOAo3hS7NfnA++J9dhM1RXVve5BIdCEbOGh6KsfEcN5g/1bhJUMyd3CeEKalLj8SjELiVwehRcYqOYeqUhYB+EMtVwyS64WOQGpN0TxsQBHsl32CutR6NJh0+BVtq/7rTKqBYqp9lpUeJoJ3WowOBhc4gkomeQnP+DCbUJUnLI5mOCjERheyt8KFBmjzfkHlQVRunVXktsgTGCq0jgGnn1dtnzupGSR/pM5mBufESVCLPIwW4T7iHiEdey2wQxh43lp6XlBteP+lOlQfsungXHEAyGG1JoUW57VZJFq1t7vhzNdY8myYFYQuf55YIQC5Ne468GI6Mjp9O6qih366TkCfY0E8rVflRTZpLI2VJZeL2QZXax5Aq1Vdjm5nLg3jkU2Ew8Hhmx8FUOW6sN2RGZCMVwIO6UUk8+/f/zUzLo4Axeu9uDvS33ag+AqGb5Y0zTZ++Nvy1/kV3Gz6v3HfAFiElfcruoUdyAOWPmDDJlXcu7KwI+T1gRcRLX4ryUmqSJ1m+dL91iO5VJuQV0slkAHD+hE4Su5yj3Gcfgx2kSeeNN8eCvmYfpiGv31tQnjoz0Ph1uZCAaZrJvuXALBl3s7Js6lk4S+9gPvU9hyXdivDXbF/01OQatHKxTRRFC8y/47ziw28z4uokv332ZLdGT/ItS1giG/UdX/QMxlKOq01xkfKO40hBq9A17j9RGhbtu9CjfsdlADmIQPP+BLxdb5nBhGiXCbzFBXOPke7cz84HWU7LNOG8rd4ZqUE1pfdKXx0jLKQHs4s340BhmCbqGYRp0OOzJatIqeusY3WmJpBHkK8+VmG0IyYthKi/Hv5exa xS8gtrFV UmuefUm+r2i+jpERpHjrhqribTf5z68JEigmj+9kkmcyYOdNdQ8K9yQf7a8REu5suqjI7bl0Lj7c0uLMGOdlwk2qviXsqsswyIn2EcLOQg6Ta1dCm/4WbCpVuxm7eVuXj7ozYT8Ix2UCtF5RjL6eexb55YnmcaPzxb0Oyo8tffxE+WHhJ3P+4IK1P8Zc62vI216MERFAoNRt/5yL0D8E4vxYTB9hv3vTHYabaLR/Jibn6K7qUl+sFFNPbrqt76idamgh+Vn0KGGGZjVrQGepdtik4jfCr9PD1HrISQOzxnxuPh6A8aeBJ6UVSITv8nBqWwdp+DtMjO1iLxdLOzFXW9NV9yk1Q3FrACH9ChHaocjUVtB7BtaF4swf7fjYBaZkERBX444bA8mSAxBmwgMUAyMv25Z1ZXhEYI2ZY56kQ8GY9IQFHsgo5DFZRmA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.093016, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 17, 2025 at 4:43=E2=80=AFPM Sebastian Andrzej Siewior wrote: > > > --- a/mm/kasan/report.c > > +++ b/mm/kasan/report.c > > @@ -370,6 +370,34 @@ static inline bool init_task_stack_addr(const void= *addr) > > sizeof(init_thread_union.stack)); > > } > > > > +/* > > + * RT kernel cannot call find_vm_area() in atomic context. For !RT ker= nel, > > + * prevent spinlock_t inside raw_spinlock_t warning by raising wait-ty= pe > > + * to WAIT_SLEEP. > > + */ > > Do we need this comment? I lacks context of why it is atomic. And we > have it in the commit description. I would prefer to have this in the comment, but with a full explanation of why this needs to be done.