From: Andrey Konovalov <andreyknvl@gmail.com>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: Waiman Long <longman@redhat.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Clark Williams <clrkwllms@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
kasan-dev@googlegroups.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev,
Nico Pache <npache@redhat.com>
Subject: Re: [PATCH v3] kasan: Don't call find_vm_area() in RT kernel
Date: Mon, 17 Feb 2025 17:29:45 +0100 [thread overview]
Message-ID: <CA+fCnZekjO6ajX5YDE2VgL3pzyawdVNkJ0g6-w0Xq15zdDdLog@mail.gmail.com> (raw)
In-Reply-To: <20250217154309.C2CMqCjE@linutronix.de>
On Mon, Feb 17, 2025 at 4:43 PM Sebastian Andrzej Siewior
<bigeasy@linutronix.de> wrote:
>
> > --- a/mm/kasan/report.c
> > +++ b/mm/kasan/report.c
> > @@ -370,6 +370,34 @@ static inline bool init_task_stack_addr(const void *addr)
> > sizeof(init_thread_union.stack));
> > }
> >
> > +/*
> > + * RT kernel cannot call find_vm_area() in atomic context. For !RT kernel,
> > + * prevent spinlock_t inside raw_spinlock_t warning by raising wait-type
> > + * to WAIT_SLEEP.
> > + */
>
> Do we need this comment? I lacks context of why it is atomic. And we
> have it in the commit description.
I would prefer to have this in the comment, but with a full
explanation of why this needs to be done.
next prev parent reply other threads:[~2025-02-17 16:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-17 4:21 Waiman Long
2025-02-17 15:43 ` Sebastian Andrzej Siewior
2025-02-17 16:29 ` Andrey Konovalov [this message]
2025-02-17 16:28 ` Andrey Konovalov
2025-02-17 17:56 ` Waiman Long
2025-02-17 18:59 ` Andrey Konovalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+fCnZekjO6ajX5YDE2VgL3pzyawdVNkJ0g6-w0Xq15zdDdLog@mail.gmail.com \
--to=andreyknvl@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=dvyukov@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=longman@redhat.com \
--cc=npache@redhat.com \
--cc=rostedt@goodmis.org \
--cc=ryabinin.a.a@gmail.com \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox