From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EA7CC021B8 for ; Wed, 26 Feb 2025 15:24:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A57CD280007; Wed, 26 Feb 2025 10:24:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A0806280003; Wed, 26 Feb 2025 10:24:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CF8F280007; Wed, 26 Feb 2025 10:24:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 700AE280003 for ; Wed, 26 Feb 2025 10:24:44 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B818781F55 for ; Wed, 26 Feb 2025 15:24:43 +0000 (UTC) X-FDA: 83162468046.10.E763A2A Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by imf30.hostedemail.com (Postfix) with ESMTP id 3DB7C80012 for ; Wed, 26 Feb 2025 15:24:40 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LigcjgGk; spf=pass (imf30.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740583481; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hsuCvPIYOZxMSn5nKFFEtm5mHOuqFxBxK/9CbbLtirI=; b=LA7eUe1n4H8j0mcIZsxZGnPCNXas2joOOk8SekXySP+Rq8fLfewdkLNA7qDtT02aDdR/1Y /38Sfo2seu8rP7SQpydFmPpjZRhBwFJZkg0km+/Hnud6DryoPlhtpfoloqDmjbTssO4i/z gdHDLRa7E39cK9h1BNcG/fbLg1Ml+Nc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=LigcjgGk; spf=pass (imf30.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.45 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740583481; a=rsa-sha256; cv=none; b=zMeEdjgd4wO9aIlZHpjgnkTT+IBaNHSdYH4WfOxSHHZLRY88kqrpj/aY2v9vCETv5270se FgwJNY6MtDsbcIysU4zRgfNe4NtTdMDYSUIinxQQvWUwVD45nxjYK5JtbTpgBX3ekJIBCd jn/+GT3C/fgwimfSIgGhEXEKgIWoxMc= Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4399a1eada3so60944525e9.2 for ; Wed, 26 Feb 2025 07:24:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740583479; x=1741188279; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hsuCvPIYOZxMSn5nKFFEtm5mHOuqFxBxK/9CbbLtirI=; b=LigcjgGkwk5D7zhG95wOo99ogYHvQx2j8B50wWVPQ055DcorkuXbhfyYEQXTQ7COZP mqJ15wu8aQ4cSdKLtfW8L8AHEgSD7UEE94s690t6QVLbeGY5VZhAspJuOlgZ2OvdUkPv C6OrbFUqSA+hcVj7Z13Npjqg/E3GKi990VzyR28N4MZacCOX6wEHKxS9lrv7H2g14bIj MBMH7WI7o/lHvpHPb6iohLOOhWMmT6Y8Qraz1JG56xa7Zq+idtbHo9jJHFlCWnS1ttnx X1PGXeQe3j3i0YPjWvhk1vAtRyKQShgILeBqyiuuErc/Wy7gz100aQysZ4oahsOh2y33 fxLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740583479; x=1741188279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hsuCvPIYOZxMSn5nKFFEtm5mHOuqFxBxK/9CbbLtirI=; b=IgaNMm1C0asMs0ONIHJTTyz1vcMnROiNBCwvPndtcjbkeIw2FB9cEIsB30WQp4YpI5 CcHcR7sS274NXbEktUfJ3LfXgQN6clmYM3xiTVXFZuxYUjybA7k9HROjuQmcb+x06sgo KmkjRgXirNxUZQhNETZKJ0V9fMH9pDzuF0T8/oFw+vttSEfTDjsn74OfBKQxuj8eNICV +/alF0NPzaOjm7eXrPk1hYgi1O6eM7i/sqyq1ckStSM1CzEklbansfCT+R0AD/iC3yTO BfJdbJr5MqV+Ikcj6slVfOt8WfxxE4d+DyFwoLjvJa5xey0Lq+qg33TjDDzqFFOV2yGi 1ddQ== X-Forwarded-Encrypted: i=1; AJvYcCUYhoavr/cdPAXfZLkTLiU8WSeX/VV2M04oz7vfjH10xxjJtkD+BLbbECr6RhnYLV50EfT5sAGHjg==@kvack.org X-Gm-Message-State: AOJu0YxZZM3sd2GuH8Qm2W6L78rerHOL6/tFYzKoj2rfCLfe61V8AXlD gjioV0X5hGqhLbjF0CKqRaIfug0YCyH0h8uI0GyeShQYlfXP+R5SMDM2ACx3mmaFi1iCCmdpYq+ MIAWvnGCj6/Z2x5gxYnFX6aXxuao= X-Gm-Gg: ASbGncv3in2gikW3Tho4QUBCfqj0jWABvWF94ftEO3Q5whfGOZ/+qcc7xp/9s4SGh8l ok1zmddQ0SL196Uu1TnqKSTNt6fphWT3lyIp1+puk8XTjIJor7DqRA4cMgxrIBap78PBLZanW5g TeCBTsAas3NA== X-Google-Smtp-Source: AGHT+IHrvicEAjuDRUywYtjbdluORS9DbtcVPJQWBJkKvDDRVQNrfEoh71Lo3le8ngVV4cTzym1PeNRSV0ffNMSQYUc= X-Received: by 2002:a05:600c:3548:b0:439:8a44:1e68 with SMTP id 5b1f17b1804b1-43ab9046de3mr32060425e9.28.1740583479193; Wed, 26 Feb 2025 07:24:39 -0800 (PST) MIME-Version: 1.0 References: <2a2f08bc8118b369610d34e4d190a879d44f76b8.1739866028.git.maciej.wieczor-retman@intel.com> In-Reply-To: From: Andrey Konovalov Date: Wed, 26 Feb 2025 16:24:28 +0100 X-Gm-Features: AQ5f1Jpqwg1oQbqitjHoWgohREHEbfWOkzeGk2nGzOh9RmhEEI44EKvWgfDP0bM Message-ID: Subject: Re: [PATCH v2 13/14] x86: runtime_const used for KASAN_SHADOW_END To: Maciej Wieczor-Retman , Florian Mayer , Vitaly Buka Cc: kees@kernel.org, julian.stecklina@cyberus-technology.de, kevinloughlin@google.com, peterz@infradead.org, tglx@linutronix.de, justinstitt@google.com, catalin.marinas@arm.com, wangkefeng.wang@huawei.com, bhe@redhat.com, ryabinin.a.a@gmail.com, kirill.shutemov@linux.intel.com, will@kernel.org, ardb@kernel.org, jason.andryuk@amd.com, dave.hansen@linux.intel.com, pasha.tatashin@soleen.com, ndesaulniers@google.com, guoweikang.kernel@gmail.com, dwmw@amazon.co.uk, mark.rutland@arm.com, broonie@kernel.org, apopple@nvidia.com, bp@alien8.de, rppt@kernel.org, kaleshsingh@google.com, richard.weiyang@gmail.com, luto@kernel.org, glider@google.com, pankaj.gupta@amd.com, pawan.kumar.gupta@linux.intel.com, kuan-ying.lee@canonical.com, tony.luck@intel.com, tj@kernel.org, jgross@suse.com, dvyukov@google.com, baohua@kernel.org, samuel.holland@sifive.com, dennis@kernel.org, akpm@linux-foundation.org, thomas.weissschuh@linutronix.de, surenb@google.com, kbingham@kernel.org, ankita@nvidia.com, nathan@kernel.org, ziy@nvidia.com, xin@zytor.com, rafael.j.wysocki@intel.com, andriy.shevchenko@linux.intel.com, cl@linux.com, jhubbard@nvidia.com, hpa@zytor.com, scott@os.amperecomputing.com, david@redhat.com, jan.kiszka@siemens.com, vincenzo.frascino@arm.com, corbet@lwn.net, maz@kernel.org, mingo@redhat.com, arnd@arndb.de, ytcoode@gmail.com, xur@google.com, morbo@google.com, thiago.bauermann@linaro.org, linux-doc@vger.kernel.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3DB7C80012 X-Stat-Signature: nqpe54jacf5jhjeyxt9rhabakm6tmprh X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1740583480-979376 X-HE-Meta: U2FsdGVkX19UjsGnv2jlIbljY04wOegBwpfQLNNGw3+NBumI65M4rVsR+eii7QB5VkR4B3lbAUy3Akew8afg0wBujoCAT4IMoFefnuvjHd7+9RGNtaY7ffeqaZH8evyx494IM6WelzO+NBYktPYpoSgthHmJiaP4+22C1LW2HLsnWQ182VJ+KnElVlRHl+b+DL3bzhZt/zT5RT7bAWg+W/PjK/zkcWsqrTRFYVr0DrWEN2c02su/dNdO1PkCEsz4X1z5hUTO9wO+YI24KNlb+67YzHMvYSTRISvX7Hg+IDNiim4rnCinh36VgXpi7vx0S5IIFVwlC5WKrcGRtMqy5bEd5x+1y0DDdjy5ii+PcOhZZkgu+zedoWtCXS+YTAQLdsFu2oKOuHRM+eGwC+Js1t7zzkVbRyeKWqoCVlc2Oar2lrRJtOv60oXIrBPvNMjaEiPYCZ52/QsHiHf2Gt2HSM1mAm2thyRnnvtoOFqO7XiS6JdJ46OBQmSIqPnpsL+P8V9q1AdUk/ghxYwg+HOeyNiLHwW0qDsySXNtzW/DkCNY35bJJrGB3+l/kYRSqJjbGoW4kjCFj+VTo1hPHMvL2D/bHTSCYuLSWl0lQGdlVNQDaaa/580Mmi9c7TiQDy5r9gT3kcKt/CiMm+BkD/lmDWasf2W32DL7M/xmg948vYWh3v/YcBnWOOS0jbOFKelw2n5WU3u/BPvWYdqlp/EUcQ7XiG9P4S8Jc/rkT8lDVah3YZH7hh9/6t272j7MOGsN3dX+XPeDal1wFqgSDOWkBNLYv/BFYcAbJ5DLEnYuczj2lIFmae06P+SGBXv2HIxteOjfpr1QdJszyxgWaPhn+Y80S9NxnWy/5vX6BkZuHrxoJL0HSDyTADfpbM4XJt+aX8ZaPEAkNvxD83hPoIj8HOvTazM2wqSOVzcPKx4SsAcvIiNkP1/oCpNyRvrCWc+InyIFt1ZjRHLc9DhlsL1 fTO8/KzS Vuk6eoAMV15J9DEOTwFxoQArPrvPiEef9dh7YN+aZVI9lfiOQ2km9K8gKB7d1tp+Eqm+OwCwW18TTyZFntUTFfprdJqa6TBEbglBgaL84yBEnktx1aR5m3t9kNtWqn9SS/Chc4fctJ+nV4+HNc95X00243ouNxDho+NN3xvgEj8d/MH25sdA6DJvQSLTimH3PX7Wah29evciqR7O5kjxL3+ZQ2HMpPDftla/D0HylcD3nBYIktO5OssVzE99CxSDYJuuoGhyo529ntT6egNVwRlI2/T/p4qauZw1WFirEtDf2Tl0k9j3O6Tl4Uredqx1bde3TLA61VkfJ76AcJ/YzRImJFg2RgvtSbk80L1KwxTow3VTTfBeUsdlPekPLz5gWsd6UqnzO/kJ/f0rTwqK2wLdtcNALVEf7fdivBWpDz89NZM1xmftk0LtcY+WngQrs6Smb1sFtrWDjSJI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000009, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 12:53=E2=80=AFPM Maciej Wieczor-Retman wrote: > > After adding > kasan_params +=3D hwasan-instrument-with-calls=3D0 > to Makefile.kasan just under > kasan_params +=3D hwasan-mapping-offset=3D$(KASAN_SHADOW_OFFSET) > inline works properly in x86. I looked into assembly and before there wer= e just > calls to __hwasan_load/store. After adding the the > hwasan-instrument-with-calls=3D0 I can see no calls and the KASAN offset = is now > inlined, plus all functions that were previously instrumented now have th= e > kasan_check_range inlined in them. > > My LLVM investigation lead me to > bool shouldInstrumentWithCalls(const Triple &TargetTriple) { > return optOr(ClInstrumentWithCalls, TargetTriple.getArch() =3D= =3D Triple::x86_64); > } > which I assume defaults to "1" on x86? So even with inline mode it doesn'= t care > and still does an outline version. Ah, indeed. Weird discrepancy between x86 and arm. Florian, Vitaly, do you recall why this was implemented like this? To account for this, let's then set hwasan-instrument-with-calls=3D0 when CONFIG_KASAN_INLINE is enabled. And also please add a comment explaining why this is done. [...] > >What do you mean by "The alignment doesn't fit the shadow memory size"? > > Maybe that's the wrong way to put it. I meant that KASAN_SHADOW_END and > KASAN_SHADOW_END aren't aligned to the size of shadow memory. I see. And the negative side-effect of this would be that we'll need extra page table entries to describe the shadow region? [...] > I think this was a false alarm, sorry. I asked Kirill about turning > pgtable_l5_enabled() into a runtime_const value but it turns out it's alr= eady > patched by alternative code during boot. I just saw a bunch more stuff th= ere > because I was looking at the assembly output and the code isn't patched t= here > yet. Great!