From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 553EAC3DA4A for ; Thu, 22 Aug 2024 21:46:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A44780068; Thu, 22 Aug 2024 17:46:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 852688005A; Thu, 22 Aug 2024 17:46:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F27280068; Thu, 22 Aug 2024 17:46:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5087A8005A for ; Thu, 22 Aug 2024 17:46:49 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CAC0FC19E9 for ; Thu, 22 Aug 2024 21:46:48 +0000 (UTC) X-FDA: 82481216496.23.E445806 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by imf16.hostedemail.com (Postfix) with ESMTP id E795118001E for ; Thu, 22 Aug 2024 21:46:46 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nc5RgahT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724363146; a=rsa-sha256; cv=none; b=38b4YTbhgv9Y2Xw9BOM3fH7gxwEBM+AhPOUpm5ycFvUX51TRWmXMdCF2uUrT4gLiNvtEPY ygXdGJO4K3wrcdmzTBzCqnrbzL4iGx7LW5KbLhMz/z1szVgaLKR16OaBGgHs7N5LAKO9xJ SfHGlDLd7VOULMvG8Ta7S9gvLGvh/vw= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Nc5RgahT; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724363146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2ObMnDIQZlaNLUtvENvNnRW6RrF/I2xgEC9S7H+saKg=; b=bmJOhRJwe1kiW8Oc/HDDgnJP30AAlbrCRX5b4vDTA+vXUwxqMlH6KnGMQYmMRxeSTjcK38 ZgZhgKj5+l+PnBp+SylHTFvDzdWs0PxgLiEsZQS/0vXlkm4qz21TqpfdXcrQPA49mnXJEZ x/AJeqSL+dzp1W972c9NiIWNtvRt/0c= Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-42812945633so9391645e9.0 for ; Thu, 22 Aug 2024 14:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724363205; x=1724968005; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=2ObMnDIQZlaNLUtvENvNnRW6RrF/I2xgEC9S7H+saKg=; b=Nc5RgahTvVnC4jZWtkkrHJVm0X4U+F0ZWsSnGKvIV1i7ezFlh8Hs8W/04Cv0Y6guaK aNhQOIJoFsdnIXV/ujGG98IzVb3wBu9EoS9/DPHbWpDJyYo6Dp9XDxqRxmhe3/gt/wzS tllaZb7LbHjTXqXGK/x0774QA8XZOkMU+46lslDj4in0vBZCcodc96CbkErRXntkvKFu apzJOMTXSg5m6CpSH2VBnMIzAyk5Y/XjoG42lY6dE/jhXxHce/XlObwENchV41zpXpAA OotFNLsSJE5R/dCyTGqBu9v3WdDCE8PJbOsIFi2ZCmpU6TmubBVjL4v5NyyE2Xpv7xVj 4QqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724363205; x=1724968005; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2ObMnDIQZlaNLUtvENvNnRW6RrF/I2xgEC9S7H+saKg=; b=aS4Z9/fiyJLUvDxQRIgViHAa2ml8rS1ENmd1FW4vL1kyjbMyBVrIdK5Nx5ubDTQLav qLGqIBhFDCrdkJNSQzzy99YCBJG1pn7CVIN+cPidiImNvfn5ZHhmbZPJsM8f56JA2HUK PT9qAAor3X3HTc4ujwfcwZw8pDZenTQKCYDytmLRpY+HAUaDMXUbJD/iEUfHFgSFsVJT SmZaCFvTv1r8eifVm+fs1OnCb5tthGyxmdox9fP5xXwug0jlZfysmU8XLfBwcmoQ2RPU IP7x4/NZ8t1oHiGOTS2U9+hv7i/+gKtYhuGzb1dV5wb9Jm9ehkcrcA6vb5UPkDEYBnFa aC6g== X-Forwarded-Encrypted: i=1; AJvYcCXL+WdRCIn6+UCu33I4IU/DSiRqLvLlSOXHb1y+hbzqdSjsyKWTj9iE40qNRgwtW1Maj06CpicO7g==@kvack.org X-Gm-Message-State: AOJu0Yz3X6SdFZQSDwjMFufQfOephNXdIeVPoxnfOxaNK9XQ+LusBD4X tcMnNSu0cmsIjx6AZ5nOWHrTPtjUM/ke3Rck5Px1crAvxYlVf8gpY9goTxqGmY4YNnwIToX1NEn eUUMozQqDO9qy//0tgqH2qHSy9fg= X-Google-Smtp-Source: AGHT+IE5ZG51q5aQTxFlFyKW6RddTpr1z4HSCEspsxdoq5oIegCSLiJ4/rs7Ct5ZxTCIN6NplrmjqMWejQ3LtCfXL70= X-Received: by 2002:a5d:63cc:0:b0:371:7c71:9ab2 with SMTP id ffacd0b85a97d-373118e2f0fmr82331f8f.52.1724363205185; Thu, 22 Aug 2024 14:46:45 -0700 (PDT) MIME-Version: 1.0 References: <20240814161052.10374-1-andrey.konovalov@linux.dev> In-Reply-To: From: Andrey Konovalov Date: Thu, 22 Aug 2024 23:46:34 +0200 Message-ID: Subject: Re: [PATCH v2] kasan: simplify and clarify Makefile To: Marco Elver Cc: andrey.konovalov@linux.dev, Matthew Maurer , Miguel Ojeda , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: E795118001E X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rsdz9xqt86bmkjdsknq9hn79mnk8xhbr X-HE-Tag: 1724363206-962243 X-HE-Meta: U2FsdGVkX1/jXBMABeNnyqKlyH59EXlfyKQcg5uz8IqQwAqebj7VOQlkCAaFtEf8BQ4Of4eMbrOZWlBHeLGj/CEoZX4arnY17uPGqIDKilDcxffDDcRE6/76lDncTH4Sx8PJtEljlynFnX1WV+cvfF8I81VE42a0ePztGHh7u/qkAUVZ4Nws2vRVcw8NX5MVpswEII7y5gfdyu3v8Fv0T1r/LrNEU9jJZcEQXts+svIJVJArDMB1UTj0zBX469lOO9M6maInSyXao0z7uRhReVzXL2stc4ZQmL+JVNhEoBM9rym9J7aqsUseq4VHbipalm3K7C+PpnOQ47I+9ot3vHwPOYGoJZn0v9cCDRG7jujaIsdgQYU1vXSo5/ILF5u0VM19SOu/XoriGRuBEDLUC50Xg9xMAcQSqTidRlvrzFfndmCvYKBIhjDWzF7TS5QH/qM8Po497RMnvBbOVh/N8Z5aZKMXAHP/CBqKlLFQrucsmsiBmj40Rqh6awRsguAsvYAOKIhUEUiYNPWM3JCskc9Ru5GsiYMyu3M7WPljhFVCOnADavOjOs3qeXU6ojSYFGwGl6xxtFBvVoOu59WGVTlIlmy4xdCpoiGDSpKxwxBkIhIU/usQjsbBgmsSdzUOeApb/gkacYpy1CxQJ43gnok5KCvKuDyvC2UoJ5khoeLEtSgnMahfsnr51/eDBc+DT9ACzmmjSdPHlYHVWRfTFzBqBNhlzBFpxZ0IHgc3foaB/CUDRABrNqiTXbgWHamD3UIBaxZN+eJy7HP90Hx74Z7WAXuq1EVUbcFBw32u051LH/DqLjnFgFl+SOrAlAt+92vjme1WqD1W680D5gJ+a1ST7kwGu2FAElzrnGu1sMbZEsFN+Dh0sp9EKjauSzzbQa8Zerp+5K9W610dsxH7A68QKVkAfiLu8BACcrJdIegx41UzfF9jwZsAfReXkYNy8uVGVItnpC5VJZL0fjO lT6+yL4I hUlUwqA3YLMDacn8o3Fv+PnDcpq8B6kTv7XIHVcHlSl2yDUi4tvW0IVMoWnXN5rTABADGpEKT3gSih5oDjUt30xUYpHTSjx002Rf8AbJc5WVz89hXyaq0PqdrtX185gwD/rlylNGlB14x13LNcW83RXEs4JTM5Rs2KPLP6U7SUhW80iDZdtOkU1aYTSk4Re9wVpoMpyqwtwHf/rFCS0mtn7ucLaHmmvhPnKX8Fpi/mJb3bCqVsZFLISQrO1GVTuPeu/cN+/elBrOg+RPm7hATCVszIyHEQw1dai/bks1Rmcfjv8uN/2yoHhsJNsr0idYlDBFZ8kIn4Oy/7SrMj+D9FE6WLrHwkslZ4iylv2PfnygDU1i2mIbcOscVqNEHuia13mUfN4BGmxRTInDJT1Sk1/o6Ibh9vvHzW5XN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000008, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 3:49=E2=80=AFPM Marco Elver wrot= e: > > On Wed, 14 Aug 2024 at 18:11, wrote: > > > > From: Andrey Konovalov > > > > When KASAN support was being added to the Linux kernel, GCC did not yet > > support all of the KASAN-related compiler options. Thus, the KASAN > > Makefile had to probe the compiler for supported options. > > > > Nowadays, the Linux kernel GCC version requirement is 5.1+, and thus we > > don't need the probing of the -fasan-shadow-offset parameter: it exists= in > > all 5.1+ GCCs. > > > > Simplify the KASAN Makefile to drop CFLAGS_KASAN_MINIMAL. > > > > Also add a few more comments and unify the indentation. > > > > Signed-off-by: Andrey Konovalov > > Acked-by: Marco Elver > > Just in case, did you test SW and HW tags modes as well? HW_TAGS doesn't rely on Makefile.kasan, and for SW_TAGS, this change is a no-op. But I did just test them just in case - everything works. Thanks!