From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45EA3C4167B for ; Mon, 11 Dec 2023 17:50:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C99786B018E; Mon, 11 Dec 2023 12:50:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C49EC6B0190; Mon, 11 Dec 2023 12:50:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEABF6B0191; Mon, 11 Dec 2023 12:50:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9BB616B018E for ; Mon, 11 Dec 2023 12:50:15 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 767E1A1B0C for ; Mon, 11 Dec 2023 17:50:15 +0000 (UTC) X-FDA: 81555276390.23.FEB0B45 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) by imf01.hostedemail.com (Postfix) with ESMTP id 9F4AF40007 for ; Mon, 11 Dec 2023 17:50:12 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Eker6I+y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1702317012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tiLi/yokcTOlHvcoLGIsa/eRQZmbR3afyB1eNuF7ev0=; b=Jzev64vjfoG7atUQZbILFrHO09B1dcwBUAPJMBVgD0YAphmESTwP0yf/PKvG06TK+rmt6w EtK+PTnHQOcXkBHreWAWlZVIZ1o0RGcbBnmaB422z4L87CcU5+lgZSHO+fKnUM2mmxTPo1 8gAgWi4g5d9t5E+UlHV0LYD7djQGeBM= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Eker6I+y; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf01.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1702317012; a=rsa-sha256; cv=none; b=ZNKcrOmJP9/nhTwcwBPV2w3yexqnRY+Q0dX59gOxLGpATq32kap7QZ5KheO1SiHGEpFyv2 +VR4Y9O+sAsaw8jcuXQLjZWQFCE9ygcoU7xd3YUYrSJ6Ig2WUKjHRvQ6AAtttvJZIFA1Nb QJNJY5faUni9aTvDLaaPYwiz2KC3DiA= Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-5c239897895so2462307a12.2 for ; Mon, 11 Dec 2023 09:50:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702317011; x=1702921811; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tiLi/yokcTOlHvcoLGIsa/eRQZmbR3afyB1eNuF7ev0=; b=Eker6I+yJf0cpcOls2IJJtp9WxFd1vZbSiiISvQtdiaSTK+0K+KE/uRBt2pexQZCrN 1w4DSQ9abfLFox/rgv59rUnLJ+q8DBwmHkuO9cJ87rV44QT7PmFq517/skyA7bAoZ+gQ xWOcn4KjRNpBpNvVDzohyxPqvbq7lu4dRSK+myNp59Occ1WCmXYzA4g0mzisRD+ECrG8 Anv8Z+BRPYcmbtotWa/E6fLJZ96Sdzd9M8Ssa9TbNIrg9G1HYBhjrQzUkAaqU0qrdaDF bYJxYmqOV8o7CFIipgHAoDo1+EYkdmfbKYLxfcvqXVvrPGWfDdKQ4jC8WHmlKAl9q1XD GAlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702317011; x=1702921811; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tiLi/yokcTOlHvcoLGIsa/eRQZmbR3afyB1eNuF7ev0=; b=g3Clr7skE5WZQKYTUAy8y7XAAs5ZIxGYVtRFc0s0q80rxVevy03cvq3PA86erFKF1B CpWFONmdmvI4l1k670XiKUnmpe78lX0JSAM+vUa+TSe5bH5TteVeoSAQeyQOcaV2FQSq REKQO1eInO2tkQmgUDA942JerAmOdQnb0Z0a2Bj6IauwdnI1HD47uhtIyHFK3DreSyya 1+tkzpgFxT/NVHUjodjcYzgwUGSO5zhJdwATwq5zeVZzpniShT8oZMbPVKZqyLBl0Ois c/povr+KDZC1771nBVpXXIcvxeNrcdsL2KqQoyIwVzVanw9aZt8Uw9C1IudPuy7A2FSA aUqQ== X-Gm-Message-State: AOJu0YyX/en1aV9AzXW1zzpE+yjdpjADM2kK/byE2SvLu48KQrh8xdxr YGNVfBULRWgaPaJ2e+VcWuVzN/BW3aV3u2arNbM= X-Google-Smtp-Source: AGHT+IGZ09V46qQ2KO7TgfHo5RcJIBY0LdSE3C3oXZPU+qn+nf/0U8vIhPjyznuLtIRWHVoYZFhRwF70ijgGPgZ23U0= X-Received: by 2002:a17:90a:454f:b0:286:d42d:e7e with SMTP id r15-20020a17090a454f00b00286d42d0e7emr2099722pjm.3.1702317011374; Mon, 11 Dec 2023 09:50:11 -0800 (PST) MIME-Version: 1.0 References: <20230215143306.2d563215@rorschach.local.home> <20230505095805.759153de@gandalf.local.home> In-Reply-To: From: Andrey Konovalov Date: Mon, 11 Dec 2023 18:50:00 +0100 Message-ID: Subject: Re: [PATCH v3 1/3] kasan: switch kunit tests to console tracepoints To: =?UTF-8?Q?Paul_Heidekr=C3=BCger?= Cc: Steven Rostedt , Peter Collingbourne , Marco Elver , andrey.konovalov@linux.dev, Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org, Nick Desaulniers Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 9F4AF40007 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 3saxhu3ze4payb6o37zuxesf7juungib X-HE-Tag: 1702317012-138783 X-HE-Meta: U2FsdGVkX1+nbeC0sf1gFUXpUz1ZtmRB9eo2liq5LZrXlsWte+fTkm690S7xLKerI0ln4TC8G2pPzuiSa/shjwogP87FHFWRqyNRMNtaH1CP4/xaIXqs/deUd2UP8lpgL/RGtZ3ZscFuF3ghjvqUPRgryigx+03yemtMz3JxHBVcOp/HgMYC/p4Mo+eXP71Fje3cqt7b8OlpMv6oIiiSTp9Yy6rWzkM8peJfS+aTsABXFw093TfKum/zfQ3mSoedC5I48xOfEQV0+SprlI8MQQ71D7mnAT9yBeCljTUCTdXVFuDqMxpA4E3H4tlEwSHSDG3ygHCIZfsuMA3NA0cvU6RCEGFcYihfFPnV4KYEWq4KbRp2V+NqIY4QHv2poeSvoOY6ficJmB3zYfbEXpVF3DQvwYIXZHhc6rqXNAnPZKoPQqJUiWw01XefebaBwfO8kAi4PmFaCchZuzL5S0jOUTv+86sB07bkwOSLi6luTDeRcBqrEVR7hfw/ej3iq6C2froHd5xPSfiEX2tYFRbR9+nANt6rF04aOPXrtwvjnvSaZUciiP1746KQA2/9KA5L9PHV0qfk7/lx2oTtuRfY1n7M5IpDYYFhYV6P10wcjFL4f49Tw+xOhoKfMHwnXRUYB9qod7YHclp7yJ+Pltc0Tz75wwJajznAJR5AvIOrZEMGh6FLY3Hq0E+wp7WrBjUcfQjO+uWWWqeNMc0uLV+UH7KkynD0CQorCOSo7j8ayxpKNQkwmRYHfaqaMHa95+UcBvYrlVN52jvQ3aITHyidBMUJHycWg2pW5a+KqWFBnVm+WG4gQ++0hIlprnrT/+Fm1laJhM6HST9jfRqBnSAnL+Blmk5SJHtyXsCwrfDiNSV0BXLWOiLNxXELC34+bK88FYhy0M8ETbVIEPnPsyQYWIjLeF73AZtHqq9hC9LdogJA1sfJG5qzmJZF2x4HB7uq1XK/Hoey8SNvHu/1Qcg 7maYkytL wJlLNE4c8fouA3f7K2ro8zXKfhINXJtolSrjbAK4mLGDGu7LG8GlRCYpkHSKg0M7rU95rlpzt8zuX76eQRl17oxefob5MW8RNNuK+1Md7V8UpzkjCUOOuVj+76VTSDLdi+jhSUfbzSIkcVkaZA+qn+qMzooyfnGEoL4B21vglMA+xK+jvD95boKgnMD9V+vgKLSW+zXO6jRpMUZ2PJCWorJ3/jTnOwIRYPzd/sFDpbyaBo40nzo2fBmf/H/riQMogPIrzMZTtG2tYsa53Ane2Muf60PdnCQEI0ONhqZze0QHLob651g96Vy31BdW+Tz2xjAUUerI5opPkBtaF+0S0ybOkSygIo5BfKVmXxLjpVvYQw4vYHz8gQuFvaV9I6RUpQ5iRYtpZhnXvs4ZJuZiSE5rFv3ZOUgE7lPuxg8Wntin1bWwmrnr3YHhLPTUk33ID2w7cVmNDYR/AdFOSlK8DADaLFgcosmxO/25z/A1xvCwDkDOe0jOfAA2sSgHgEnMHWOiB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000192, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Dec 11, 2023 at 5:37=E2=80=AFPM Paul Heidekr=C3=BCger wrote: > > Hi all! > > On 05.05.2023 09:58, Steven Rostedt wrote: > > On Mon, 1 May 2023 15:02:37 -0700 > > Peter Collingbourne wrote: > > > > > > > "ftrace" is really for just the function tracing, but CONFIG_FTRA= CE > > > > > really should just be for the function tracing infrastructure, an= d > > > > > perhaps not even include trace events :-/ But at the time it was > > > > > created, it was for all the "tracers" (this was added before trac= e > > > > > events). > > > > > > > > It would be great to see this cleaned up. I found this aspect of ho= w > > > > tracing works rather confusing. > > > > > > > > So do you think it makes sense for the KASAN tests to "select TRACI= NG" > > > > for now if the code depends on the trace event infrastructure? > > > > > > Any thoughts? It looks like someone else got tripped up by this: > > > https://reviews.llvm.org/D144057 > > > > Yeah, it really does need to get cleaned up, but unfortunately it's not > > going to be a trivial change. We need to make sure it's done in a way t= hat > > an old .config still keeps the same things enabled with the new config > > settings. That takes some trickery in the dependency. > > > > I'll add this to my todo list, hopefully it doesn't fall into the abyss > > portion of that list :-p > > > > -- Steve > > Just adding to Peter's concern re: CONFIG_KASAN_KUNIT_TEST's dependency o= n > CONFIG_TRACEPOINTS. > > I'm having no luck running the KASan KUnit tests on arm64 with the follow= ing > .kunitconfig on v6.6.0: > > CONFIG_KUNIT=3Dy > CONFIG_KUNIT_ALL_TESTS=3Dn > CONFIG_DEBUG_KERNEL=3Dy > CONFIG_KASAN=3Dy > CINFIG_KASAN_GENERIC=3Dy > CONFIG_KASAN_KUNIT_TEST=3Dy > > CONFIG_TRACEPOINTS, which CONFIG_KASAN_TEST relies on since the patch thi= s > thread is based on, isn't defined for arm64, AFAICT. > > If I comment out the dependency on CONFIG_TRACEPOINTS, the tests appear t= o run, > but KUnit isn't picking up the KASan output. > > If I revert the patch, the above .kunitconfig appears to work fine on arm= 64 and > the tests pass. > > The above .kunitconfig works as intended on X86, no changes necessary. > > Am I missing something? Hi Paul, I've been successfully running KASAN tests with CONFIG_TRACEPOINTS enabled on arm64 since this patch landed. What happens when you try running the tests with .kunitconfig? Does CONFIG_TRACEPOINTS or CONFIG_KASAN_KUNIT_TEST get disabled during kernel building? Or tests just don't get executed? Thanks!