From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D4FC636D6 for ; Thu, 9 Feb 2023 22:22:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8B116B00AE; Thu, 9 Feb 2023 17:21:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C13FE6B00AF; Thu, 9 Feb 2023 17:21:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8DA46B00B0; Thu, 9 Feb 2023 17:21:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 936446B00AE for ; Thu, 9 Feb 2023 17:21:59 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 564D5A1073 for ; Thu, 9 Feb 2023 22:21:59 +0000 (UTC) X-FDA: 80449177158.25.1942F8E Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by imf22.hostedemail.com (Postfix) with ESMTP id 95BD2C001A for ; Thu, 9 Feb 2023 22:21:57 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=G66azLLs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675981317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HBgooxc0T8xR3a6LCddpzQrYzp6lIglbhu4rq7s0u6g=; b=fu8l0dMjPN043V+wU8XnE56IecAKuNZ6mx+vEo0CRZ7VC1qc7VZRTXHzOKGFPhv9WuWxzw wS0ydAZYj/sz3OFdBWET+M8hXHsTUmjlM4fHJ+gTSJQpOtNBvCWQuNZBLQ7r+lJHpIQ5VK eAYrXa+Vpp6+QD5P/pS44qUZ4fJLo+w= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=G66azLLs; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf22.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.45 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675981317; a=rsa-sha256; cv=none; b=aSmIuG73ToE7f3d/emozSnUaD4BLrAl8S8eZ/6V1QQ1hTKw7ptvHrekmQ+hm9gZKsgS434 fffJ5V+TwDXFf0wMIRWG+v++MmaGbWVgxwrbAKwQIzMS65rZMytLjQcnqCDu6wMKcxJ6KC qNtnyIu97+SyqbmrHZNOJsO7tPNBEtA= Received: by mail-pj1-f45.google.com with SMTP id a8-20020a17090a6d8800b002336b48f653so1754202pjk.3 for ; Thu, 09 Feb 2023 14:21:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HBgooxc0T8xR3a6LCddpzQrYzp6lIglbhu4rq7s0u6g=; b=G66azLLsnTGcPff6dZ1UZZ+l6WItPKuuCA63rRDwBGGG286NbanTz7nS2sZyhkGFxa RuXPkGIsymiNyAWKgcNo8RbtOHohyX3kMlAxKyy93fxILNt+SuJhoSmjxN/nlTmHCdbr fUIg6nbBvmTjIcReqiqmmMljzQddn8PFmwHiuPWhpQutH6p67/3g0CHc8XjEa8cD7f1j 08qP74TSw0MId7RvhzbxNMVoWiPDszIkD+6OjDAwl+qU3kyS6mjG9yQWP4wz/p2iiLcV ZWjWGUGEfldnXQUQXPsgNUnKcpEqwVXmHXjmthlBs6J1smjJbgbrwucYOuvqZxwH1aZz GvMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HBgooxc0T8xR3a6LCddpzQrYzp6lIglbhu4rq7s0u6g=; b=gsOuZwtvEEonSC6nSUghbG55u3ZBY1+znGW3WXsfL3kaVALm230s8GQCN1iAvzSKw5 ctCqsTyR3hzInPyNMnC9dLGlMpPMJ1s6VzXOpOZP8s6GoViZwl46P8xixjTZcal0IQQJ jo3XfU0BtQEbuIjTUU+PELw8NF/e7Xa4w8v6s2Pak/HkDEa5PXQojQo3uWvDpoaBiBTR 1YniVmnoRWRD44Lnh8PCv6nwyPGvQ1A5XUX4v2rOh9iLRF2Ugmi75e0fCddKWmmuUajT hPFqb75UPh8jn0evMikKpUJjUmaHk4L0QLxEx+oGDmCcH+TXi3hlmb9mC6A0qm8GChaV vfOQ== X-Gm-Message-State: AO0yUKXvd7QWnh9AwCR6PzoP0rV+ZlEnAFDZ5MwSHHflDkHeKvm6fYTj fw5dpWunjTC+4CuFyHyXX/0ptAoQsCjxh0Sb5AU= X-Google-Smtp-Source: AK7set9b+dVUyCJB6vApvDHFGz5DxEUMKinwWM9x06h3G8+Iy6tr5nZNJoGvTj4ukeUpCcN0mwC8IVuFE8KPomfixtI= X-Received: by 2002:a17:903:22c1:b0:196:6319:a029 with SMTP id y1-20020a17090322c100b001966319a029mr3284169plg.12.1675981316316; Thu, 09 Feb 2023 14:21:56 -0800 (PST) MIME-Version: 1.0 References: <20230208164011.2287122-1-arnd@kernel.org> In-Reply-To: <20230208164011.2287122-1-arnd@kernel.org> From: Andrey Konovalov Date: Thu, 9 Feb 2023 23:21:45 +0100 Message-ID: Subject: Re: [PATCH 1/4] kasan: mark addr_has_metadata __always_inline To: Arnd Bergmann Cc: Josh Poimboeuf , Peter Zijlstra , Andrey Ryabinin , Andrew Morton , kasan-dev@googlegroups.com, Marco Elver , Dmitry Vyukov , Alexander Potapenko , Vincenzo Frascino , Arnd Bergmann , Kuan-Ying Lee , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 95BD2C001A X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: s6sf3jcoy8n1oiyij5qzstnxrnm3iyxx X-HE-Tag: 1675981317-846568 X-HE-Meta: U2FsdGVkX1/F5kfr4BGG29W8XXLFl3Lk5B0Wzb8GJtsvtlPTmrilUFrnRtPqx6gEPk90BTkXFemEYYahD/PbjsESmU1KsB9bBoEDzJI7B356U1dOCXpnTin0kCP3gbwWBI1T5TJ3JGEsGL+revBBhZKxQEZHaR4IgGBseVMQB0xJ4/YYndoOEtwQxRLerP1MK0T0fgKhoVYbG87xh8ZEmAkbpnxekBzC7j2asK2rmZADByCiaVEvx1cLHCfid+s1JwnYnN2wtQTj/GuW/A2Yyg7KZrHpz1/JjpSp6Dz46rTfDVSg9Gl0+wQSJTrgINvDBxbOkW5ygdw0c1ixtiWNznReR6MfoZk3pOn99Fefr0tI9budSzE4MkK/Mkymuf/sAW76WXl0cigTxKVcSXih7+3dkDlt/OEXDNzH3gsnF/CPJ8eqENsWGcYbyh2wIsJcQpbzGmUffU31NoYPwcLuJ4KlB3+bcDqly62UXTACnHxSqSxcxG3Wp7dD/OsGin3A3LtILSnJ+JXAneUPD2kpCAO25dz9oI7xSzlee+wOIPkShbGaUjVLL2gw1YP8/VG3kzwH+FYXd5eXbu3Uu/0x7k9ZE01RhZD8gqP7H4fn3uD40/netnuJdZD9MJKc4LagbSzAxe8dGSrgURA1lc8hm/6tbctKqA+StqeF9vRqyYoZN2AusrWj97Br7iemGANeUlpXtnBaFTVXHK/X7fCSmAbX83w0HAuyC6WLyBAGhi5M9Z7FUOcJedFItRTcWNla8FyMbRX3jR7i2EZUq8FVVoglctRTAgqIjWO9ChMNRn1E58SkE6ajeG617Ky26F+6KFyqjg/OLlzeB+q0uRDS2s/nfFpnJgtWxMEDFChOHtglvp03VYp5WTgr8qDkHNo73JHQEQ0pjWlmiHpO+VDlUPWneaV0T4h9kNDUdX6+cLTqVtHU5n8XhD1oOQKKmfa+2PuM9Vw3Iz2aYVT8IYO Esx1Hg5M TSs9JZOdO1MZU5OTFgAK+yRgi7vUC9SCdnyYBjq/vR1XbYVRyGDAnvEi1OqfBQupe6ASs52J6u4rBKnCslKCA4yZdGEZmQ+0pwbotmtRcn7AybZbXh2QQSj6Hk/so0BCcd2uHK358Cd4ogfoits9tTLA9EhWZhM75E8kWd1aRZPM0ezDdMsV0tFT9WB6HGqPNAqzyIF0MW5otGpu7153UgjsqTEEJAQ4aHzATbasgcBnXN/ekleXpKWlSN+sUZT+UNaQFrWKMlca4Ya5Uy6tA+79oecmbRvaI3hC9SJsjOj6mJWPSEnREVd6HG5gxvmFnq4MkJHW4qgsyeuzg6jliI1akNaeQlX3oO8UJ9AFA98BDMP13BlmtNgYyYeL4Xcm8T96hH/P0B/Eh1+0Bnv84YI91fwnBV70Elmvolu6IWhtaYjTFaZb0VM6GYhK7cKyhwqKxU0BQXwODuSgV6mP+NgdvV/zpYiHcBuEfv6nG0FS95oTlB5Xl/o92P8oL9i+Ll0y2kB1PKleIHo/NWnWs9TCXNzvn7/nshB28jInbO0LKNY6gdIsWOkSpo6ztVhS/y2ez X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 8, 2023 at 5:40 PM Arnd Bergmann wrote: > > From: Arnd Bergmann > > When the compiler decides not to inline this function, objdump > complains about incorrect UACCESS state: > > mm/kasan/generic.o: warning: objtool: __asan_load2+0x11: call to addr_has_metadata() with UACCESS enabled > > Signed-off-by: Arnd Bergmann > --- > mm/kasan/kasan.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 3231314e071f..9377b0789edc 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -297,7 +297,7 @@ static inline const void *kasan_shadow_to_mem(const void *shadow_addr) > << KASAN_SHADOW_SCALE_SHIFT); > } > > -static inline bool addr_has_metadata(const void *addr) > +static __always_inline bool addr_has_metadata(const void *addr) > { > return (kasan_reset_tag(addr) >= > kasan_shadow_to_mem((void *)KASAN_SHADOW_START)); > @@ -316,7 +316,7 @@ bool kasan_check_range(unsigned long addr, size_t size, bool write, > > #else /* CONFIG_KASAN_GENERIC || CONFIG_KASAN_SW_TAGS */ > > -static inline bool addr_has_metadata(const void *addr) > +static __always_inline bool addr_has_metadata(const void *addr) > { > return (is_vmalloc_addr(addr) || virt_addr_valid(addr)); > } > -- > 2.39.1 > Reviewed-by: Andrey Konovalov Thanks!