From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6047ECAAD3 for ; Mon, 5 Sep 2022 20:34:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1DA4380201; Mon, 5 Sep 2022 16:34:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 18915801E6; Mon, 5 Sep 2022 16:34:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0565380201; Mon, 5 Sep 2022 16:34:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EAC21801E6 for ; Mon, 5 Sep 2022 16:34:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C07F9140197 for ; Mon, 5 Sep 2022 20:34:50 +0000 (UTC) X-FDA: 79879185540.05.9C266A9 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) by imf12.hostedemail.com (Postfix) with ESMTP id 6647C40081 for ; Mon, 5 Sep 2022 20:34:50 +0000 (UTC) Received: by mail-qv1-f54.google.com with SMTP id q8so6993640qvr.9 for ; Mon, 05 Sep 2022 13:34:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=LWWc9wTEKH9JOgE9QE9gnp320f8DJyBjkMZd1oJSX5c=; b=aUO5ZddJfxJ10nryf9XdZbQw1y2YSk+UHvlVfXgDO+BVJJSkhZpGJqMZ4fPB0/HqMU wSkCUn+/8z9Ud466Avg/II4gvMT/9nMnMyYgyvdaj0q20NtCoBrbhqZaoyp+CRyUwT5a Xun1cBn5kG6XI3oGSS507HAQaMaANellkpaeWOBxTrCCjeDpQPb2Sc8l/H1q3QakQ1WV 3wR1Yqr4cC0dVIeocb8v8ZVq+fF3F4YyH+PxsUgjZdv1dcD/Si3Mm4H4GfVSAoCW0Wm/ sKhxG9PpHmx2I9ALNQcrQC0TlY6tPs0u4zgDriCfI7tU8q50lJz7I6lUYdm4l5eAW3OC qKDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=LWWc9wTEKH9JOgE9QE9gnp320f8DJyBjkMZd1oJSX5c=; b=E03jyz+1Rqg9lLrst7VTGII3J0OSlKBaTOyZ/m989tUdsfaXzBF+BXsORG7gNP5rml dptf1Tf47g6oB+Q6hhENiTYwwUEnTsL/cAhN/sL1E01w9ZOssUONK8YtvDJzs0ZGsnd1 qjikEknd4JRdtpP1Cg3ZHUhHNmBmgynwtN/+Dh50PZTn+EP9VWp3J9MvoOSEPvGObsy/ 7k+HtuPLeL/GkFbKVEuM/l87DhOlHoWUDQfte2ypmwj+3H+Y2DYbyKTiYZQki83XFrqx G325tXWLnAtM3ykb3LNkNpPywYLf+Kml8Qveh78Y0p6ppsptP68pq4humYTWS/x43LEH 8yVA== X-Gm-Message-State: ACgBeo2jfht7cG1Q/NWBLE69gg+vEZmYx3IMOzqpcP1yDK3dPwkig3jY ptmHCVcPMenhvHG8/wNwx5i9IP2ncyD7ZqJ/20M= X-Google-Smtp-Source: AA6agR7OVjCdl5OSG5AINDybw+DNSQ5AiNnH9hQXLrz7NsLRRi1FvBfW3eJLPGV3ZUy3hPHY3ir0bx/BOKeVmgmSQJE= X-Received: by 2002:ad4:5741:0:b0:4aa:4772:8835 with SMTP id q1-20020ad45741000000b004aa47728835mr2393789qvx.56.1662410089701; Mon, 05 Sep 2022 13:34:49 -0700 (PDT) MIME-Version: 1.0 References: <4db564768f1cb900b9687849a062156b470eb902.1658189199.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 5 Sep 2022 22:34:38 +0200 Message-ID: Subject: Re: [PATCH mm v2 32/33] kasan: dynamically allocate stack ring entries To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Peter Collingbourne , Evgenii Stepanov , Florian Mayer , Andrew Morton , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aUO5ZddJ; spf=pass (imf12.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1662410090; a=rsa-sha256; cv=none; b=NM3gHlShCid+B1/tvHxsvrTG9DjieEtKePLW61OhJQNx258g3G4T9SZUpnmVwAqn1tjdkI mOJTez9ZaEUDLy2kh0cRP6iLTKFMPSot/bKC9i/sRk7f1eI2JivdXtlTqCCtowfweeBEY6 ExvG1d5pEu7LViQGDcFN8+XoZTaZ2VQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1662410090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LWWc9wTEKH9JOgE9QE9gnp320f8DJyBjkMZd1oJSX5c=; b=nFbDlGXxYpJYORoj7Iag8QrC4ZjWlvauQ7ify6c8Qqsd4RvsrfhXGr4pqeSTpsGbKVhCRN Y7/ecVSXRmbQrggqUaVLMQvIULaBfoY2WhtHx/oxIM+sK17tNxYwg91HkOxLbU7IlbHKfc 4/XeMXduWwVicTZtq+1DrR1HkDIN+yE= X-Rspamd-Server: rspam02 X-Rspam-User: Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=aUO5ZddJ; spf=pass (imf12.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.219.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Stat-Signature: d3cu6fpfwj8d33sr1yqaa5obqpzj8br4 X-Rspamd-Queue-Id: 6647C40081 X-HE-Tag: 1662410090-599490 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 3, 2022 at 10:09 PM Marco Elver wrote: > > > -#define KASAN_STACK_RING_SIZE (32 << 10) > > +#define KASAN_STACK_RING_SIZE_DEFAULT (32 << 10) > > > > This could be moved to tags.c, as there are no other users elsewhere. Will fix in v3. > > +/* kasan.stack_ring_size=32768 */ > > What does that comment say? Is it "kasan.stack_ring_size="? Yes, will clarify in v3. > Is it already in the documentation? Will add in v3. > > + if (kasan_stack_collection_enabled()) { > > + if (!stack_ring.size) > > + stack_ring.size = KASAN_STACK_RING_SIZE_DEFAULT; > > + stack_ring.entries = memblock_alloc( > > + sizeof(stack_ring.entries[0]) * > > + stack_ring.size, > > + SMP_CACHE_BYTES); > > memblock_alloc() can fail. Because unlikely, stack collection should > probably just be disabled. > > (minor: excessive line breaks makes the above unreadable.) Will fix both in v3. Thanks!