From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21E1FC636CC for ; Tue, 31 Jan 2023 19:01:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B40C56B0078; Tue, 31 Jan 2023 14:01:43 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AC9C76B007B; Tue, 31 Jan 2023 14:01:43 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9440E6B007D; Tue, 31 Jan 2023 14:01:43 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 820636B0078 for ; Tue, 31 Jan 2023 14:01:43 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 5B030C0C5C for ; Tue, 31 Jan 2023 19:01:43 +0000 (UTC) X-FDA: 80416013286.10.78992BD Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by imf10.hostedemail.com (Postfix) with ESMTP id 1EC08C0023 for ; Tue, 31 Jan 2023 19:01:40 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=c7mxTGGa; spf=pass (imf10.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675191701; a=rsa-sha256; cv=none; b=OJogyRwhTmjOkkiAoYbGA0Lc+/C5MNLJCwBWrPgpmKjOF6V49E1HtDUlbMrQR7tgRQ2cnx b/SV5N2DSdVobBYxKyqy53eNml6H5Sf1F5dumbCa/47YwJx2jPflEV2lkjpOoWNklqWN55 BN0UtI0C5L0OXxn8AoMrfA0pwchcTBU= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=c7mxTGGa; spf=pass (imf10.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.171 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675191701; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JEPpab3psC6bj9jl5RKXgLUqYW14UThmzVF6DuOiw/8=; b=kFcq3Ro8uESclROszGA1V2s/8zAAP3z64ldADy0MYl4gpOZVLRblyIjdDzn+3NlAPTNCJP QhRTqbWLeGzApy6WfdUxsQFQVV/Nxcg+NGd3CTFBrNQGGaKzLQHjUxjxdNZzECIdc+50Pq tEr6GMi5JMsAN06nt4J7FAuW6XPkC0Q= Received: by mail-pf1-f171.google.com with SMTP id cr11so9240868pfb.1 for ; Tue, 31 Jan 2023 11:01:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=JEPpab3psC6bj9jl5RKXgLUqYW14UThmzVF6DuOiw/8=; b=c7mxTGGa9A1LwUkWB4akK2UlSlprQ/F4wZkQfISs+OsLhsm0YaC/hBtxD3IxCIIDr2 jmhevDnuLoyCl9vqRo2x7NswXwz/mwwg6MMYxNYfF6xwwnA+1D3c4zXK35chb3UQp5ZN BHGi1RSypx30sJFir4RnlAmwP1qES2TGLyxdBrYbqshr4W0yn67WMrXf8Z/ZDKI2C0pI g1BSvGjsH69RyROe86IfM0cffETBNHgqVQdyR30TIxM3NEF7iqdzciV4zYHr/1Ct3rmB MV5PPMLlYGUKSUCD8iSerY19ufBwtIG/K0Sd97VspYvKrT4OBuEhua1lVD14V9qmi8Q4 T+lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JEPpab3psC6bj9jl5RKXgLUqYW14UThmzVF6DuOiw/8=; b=LqpVVtq7Nop2MUJAN9sByAW9kiZPldaw7DZvntVTC5oJoMgEYK3luKERLoysNAc9Q5 yoRCKoi+cIKsQ4fVPfGg+JHoxTaMYoSJeP+pHQrDdK95b1c6LHDDhcSLD2qWbjy4OGqQ QJlF9uaHy1Gzps/1gMeJK2L9L3wQXj7KetXIzMcjQ+fPDVLo3AHKFWQFw5EFq9gwPLlg crVtCsoytcmwKqhUmVSYzA/KZfYldPOCVx1UgEAkK/7OJ7gZS1D6OAgV/mY+DOunF/mU dpxlVgsBHg59/ti/FqG0oyJKJLQO2MPqVLsJWlKbP8m+tWtLAJTpY73m4nzsYAPu6tGx jgnQ== X-Gm-Message-State: AO0yUKWPNkm1V/gDk+pKiqSJ92J5GftG1ocC+TZ1KTwk3xrXFBt8PIId PRrxKaE5R66IOlAA99BMLCCKgBKuDRVVTb4ZS6c= X-Google-Smtp-Source: AK7set9nFO7AbCFSBUnBwbXDh0Sd63kphwuYMRjlW/W05MiWN/UbYOMWhlAruqIK5rkPIWrq/r0++vnYzYzaSs7iy50= X-Received: by 2002:a62:1dcd:0:b0:592:d71:74ec with SMTP id d196-20020a621dcd000000b005920d7174ecmr3537457pfd.43.1675191700062; Tue, 31 Jan 2023 11:01:40 -0800 (PST) MIME-Version: 1.0 References: <4ed1d0828e837e15566a7cfa7688a47006e3f4b3.1675111415.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 31 Jan 2023 20:01:29 +0100 Message-ID: Subject: Re: [PATCH 08/18] lib/stackdepot: reorder and annotate global variables To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: 1EC08C0023 X-Rspamd-Server: rspam01 X-Stat-Signature: 94dd81zfj7bxh5i7abuzi1orkc318ty9 X-HE-Tag: 1675191700-792229 X-HE-Meta: U2FsdGVkX1+4aYUZ0LX9IENLaFM9Og3VvEEp/OnnB2T9bwF2LL3mu5su3k4GI9QUZPMb9jP4sKynB5pkBin9zDItMhdiqQRAlGuTRtcDa5deyNSm1Egu2VVQTqak7jfpUeP7JWTezTZxmMHt67hgfPMSIX5CoKb8n21BwYCLmde8zHXG8hT/GBhdYklU9lx9rL3uF3Rp+IQVRhTRy9vMoQlqu5IBmngTi6jjQRnx+WEtj8PhXAKs6eCDtY1xpNbuHI8o76lg3zkFcApFZEOvMR0CsTVs3Qn2xnWtDy3MJosIA1JucWEYBFpEYC6ZjKaSuaxJDvKPyRMMMGzCdNa4gtisTDNTGfMC0QBo+tChSR+VznWph3qyUFGTgdgIhDVpaRCkfymTP0FzKkRb81SgoRFBnlGCdF8hyCfzc5jfSXpHFJw+F8feyymRuofjnljHKTaGb1hqOEsiXTobKvXA6QxdAZ8wVNn8Xr+oAWMtQgX0adu1BW6G2Os/6uuoalgRS+t4oBGwrisvtQMI6Ju3wHIJOJxcGQCKWcdxcmRGxO71jMH0wI6ns4eQCZjzZbMnHqGWVktDxw6JVmr2sfmLEgw8565wD0lApVkkokoKcQnkRK1HEDrUGf5ymbuLRT7AzsWSyyPEyl66p/PQhutjGYf8BSkyQgJPcNV4caVMCSalOzGSUjwbl+pBtM3ft+0PMN/vEbwjQrIxG2BlkvaMnZXs0gtSMC3TfooDj6+nlxJ0CDKUJ+z7hER4EVLzsbq5rL10+68A5tBT9xFtnoQvNxKoCvEwEp4qNOs1dh4pyUJcIxm0u0lRMbMRCiKjX2p0/tcq5gBSh6Osbx7ljpLzC1SQoifzFBn81dnIxsWoBso4okY2V8c4g6Hskg3FTXuuViBPhKzciQGCEMGck3uZdaBd/crRUFkCJJQfyQ0NsLn/5zeF1P8Qy75gwF36bS7hgbEw5DnCkZQCIj2s4rH e/mkE8HQ xrH8Pi60P+MGkqNYxS+LS09N/fG8uRENafz0u7oGmDjof3mVvGOhv8JNmRryRiDMqlvoM3kZEd5BLZd2nU022H/b2kXRmt47Hnae8zubs9k0l5ZRiTJD37/evLIjb43vfScXM3haMPZDBBGU3x6ZM03KEWoN6sYfEte8JsqsY0hgZ8x0/jiqH4QKYphO3aiXeNZa8EM+iS24AIkCeHH5iiJYef2QyxGw+Gtp0cz4yGNX2Ye9HdH9dMLsbvpru+IHtO+aZMGlne4g2hZraZIaEfTcs1w/4q+nu/RMRSQrByTMM81pYpTkS8Z8isSEJSutlfcZXfFQyVWjHPkXpSXD6rIfhhW/Y6IRIuRdE+MoCPpXfdICwWfifZOzz6EEaijKRzj/7H6ACkRS7xICukY3wC11FoNTx6In1DCMNhrRvnTPWl5oajVehgOH+7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 11:43 AM Alexander Potapenko wrote: > > On Mon, Jan 30, 2023 at 9:50 PM wrote: > > > > From: Andrey Konovalov > > > > Group stack depot global variables by their purpose: > > > > 1. Hash table-related variables, > > 2. Slab-related variables, > > > > and add comments. > > > > Also clean up comments for hash table-related constants. > > > > Signed-off-by: Andrey Konovalov > Reviewed-by: Alexander Potapenko > > ... > > +/* Lock that protects the variables above. */ > > +static DEFINE_RAW_SPINLOCK(depot_lock); > > +/* Whether the next slab is initialized. */ > > +static int next_slab_inited; > Might be worth clarifying what happens if there's no next slab (see my > comment to patch 01). Will do in v2. Thanks!