From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDF60C636CC for ; Tue, 31 Jan 2023 18:58:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 63A0B6B0074; Tue, 31 Jan 2023 13:58:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5EA476B0075; Tue, 31 Jan 2023 13:58:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B2166B0078; Tue, 31 Jan 2023 13:58:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3F3116B0074 for ; Tue, 31 Jan 2023 13:58:58 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E24C912055E for ; Tue, 31 Jan 2023 18:58:57 +0000 (UTC) X-FDA: 80416006314.10.B04D8B9 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by imf12.hostedemail.com (Postfix) with ESMTP id 2A9A940027 for ; Tue, 31 Jan 2023 18:58:55 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ksnvyCeU; spf=pass (imf12.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675191536; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TP6A9+wpIMvqF2KNq6LBjoVcO3DYja8lhfZN/jsXFAw=; b=4Ibna4vrxF1BbHhBIl6HvmcNNmhYCivGIpy7UMRTGh24YMOwUxN1nLtKLgEpEzHQ6/mUeV e5qtxpTEjtIy8miWskhaulGQbPulP9EG4ISKK5dCbP92t8k9uuvfhOri4FLRKYbd/pOHl+ Ap92MnwFfg9nyarD1xGeZDEWDoM8G+U= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=ksnvyCeU; spf=pass (imf12.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.49 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675191536; a=rsa-sha256; cv=none; b=O3aAdVlsYpAPAyGSzhePSrjlMdC/NSHHp4QspaT5WGrcVfOTNFP8MSQSf4jiwOGyneFHXf HGegFuVEeWEpDSxrFPP09wr75Gwa5Qq1y44RtLD/71X18APuWRGJaLxQUWAXBVsQuVjB6J EoKD5zUU9J2ff7SUf16HeMql5GzWesI= Received: by mail-pj1-f49.google.com with SMTP id ha3-20020a17090af3c300b00230222051a6so1707221pjb.2 for ; Tue, 31 Jan 2023 10:58:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TP6A9+wpIMvqF2KNq6LBjoVcO3DYja8lhfZN/jsXFAw=; b=ksnvyCeU1RyWc0VKTsa9dgJxB59yOHGjX1cproOM8Mp0Y8nfkqnlmuozL7CBe/ZWah rdN+MiiIujwE1kfpwsxFPDD0y+gVSFDktlxpdznzekylT+20RXCpZNiIXcnQCaFguseq tFH6vGwpn9pNSCCsauN/XDtwxc4eoBEEjz+ejaVgpAwghYyA3IWL0pwH3I8tzq0Rucrt PXswITHQJ0ByasV3kA7AuZbl6VHFqoGX1PewA9mhOdGXX4YmJPMM1Di/KszXCtQ9jLU6 5ThiCtMJKnxDsPlUPhvRPGqaM3xWakLsFrTNwXIubYdud+su0oPhnZc7EF4R5Ba8kue4 d0hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TP6A9+wpIMvqF2KNq6LBjoVcO3DYja8lhfZN/jsXFAw=; b=EHIgExftONpADz0fn6APCUcAxEglKUnMUqzm1PPJ+Z3Y3VjbZBxC9rTZo5EU0gfwyP jDvVMv1707ohz3V14ymUN7213FxW0uFcZ+mtCJdb+ajg8KKeCQPW4oT2RzGcGujcJOHP X62JkMPKELnLTzZBI1Z0Fy9G34p9g2x+EjcEM3lruS7H5ChpHf7OC04xO3mO2d2eG5Kn lFw3Q+qgL/UppwnzweBB4xhfSlFwPIB1QZ92mf1NKvuyve5yHGBYJaMvdPKjUCgG6psB /cT87pWR6ivLH+jsP1O33j62rSpu2uXQ7GmNQdAGoYjg4yjpjvig+uFOImOxlR4vH5FQ k6TQ== X-Gm-Message-State: AO0yUKWM9X94eIBhFUSmifk7Wio4Z86pPR6PFQvmFTVGkGZeR8x2WLWi Ky4ZYYylY/fkAvIY3pJD9bi4bz5GAPDryOLdO5I= X-Google-Smtp-Source: AK7set8XCyt+bK6u6JefsBlIVz/6EymxzMOrBX8XuUIRF3cIGW2hgOy0wXlEZ2nWAqBijXJWrNFkg2XkWsSCoGHya8I= X-Received: by 2002:a17:90a:6ac1:b0:22c:697a:e056 with SMTP id b1-20020a17090a6ac100b0022c697ae056mr2201922pjm.85.1675191534976; Tue, 31 Jan 2023 10:58:54 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Tue, 31 Jan 2023 19:58:44 +0100 Message-ID: Subject: Re: [PATCH 15/18] lib/stacktrace, kasan, kmsan: rework extra_bits interface To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 2A9A940027 X-Stat-Signature: oqitu54bb3mnii5um4mpiknhoedm7yqx X-Rspam-User: X-HE-Tag: 1675191535-859477 X-HE-Meta: U2FsdGVkX1+b/Sa2oIgGjjS9mAuEggqVIZsrz91vtkwVFbXaEqvY24yhThmVGicQzVHOdvWlmJsL17Cxg/+4eQ6yodqaF9HSxu5tUzC9PL+1KNio5tpJecbmYjKbjv9SXP4tlfqCnDK0G/zC+fO1k32M0cz+ZxBXeUpKohdplGA6/02nPT02mQS29r7xXJtkeLS8aMKIYIyC9cnIrt8NI/E+T4rxloitaIf72XYbSM6JpkfhsAZSQC9P1ar1D4Icby55mKOUFHPe2GKfpARjtJkL9px3ZfY512ktTn7Ttm/UtnhoGTFTIiTjA8rm8gJzkVQDx3eEnHcIFgqEtN5PtiRJoOC+41eEzFlO7po5bNGbibd+vyq44bdNMKEeLeG0LF9Q1okp3HBokUgfH+INFP3SAn6uUVbUDiqVxLVx8wK7dx9V+9jBbHt/owOosWUkkR1Rl90HkPYG2mT2wY6eheQm/qS1dtyP7Hi7Rfc4EHghbypLjDLTxOV7ImsAjUrl/Y0p5TlxXx+xl2mtjS6b9kBRqAPvpChBnoI/QOgvEy+NbRaOPlIGi/yEOvry/I5WG4InFgeVk6SDQYszMuW7k1St7jU31jVkVTm8CHVGDmFuVVAUZm2PRUTE7j/jvtD18wPiCBsxbmJeopAHlndkxZ9yFPniTEHfVQbUCtBhdByroFbgTdUmJOibnHuebHCwf97QfMf3mdbJiPp9CSZIbv60IsXncaOgDFNTp6dQiI6OF8WzLGCHxBX6an9Tgp/9JSE/VSwIlKnJ2A25k3F4ojBVu2IdWzfAvHmGgExmgxB3YXq5crABP0z1xvY5O9+B0QCNzqU7M9wFSU73mK2RjgzzVJbrYvStIWHVW2Emg2kliAVoCtxGahtImMgIQrRXRAFcf3r4QN35zvfjFVFnaXGBoROETJeZvDyOmkqPVViaN0H7AwdoX3swkAHRS6Gn1JBJgPizcitYNv72wF2 TenuXLdr FXWuYU2cHF92Eft0tc0qwSN5NoZlUnGV5//I6KmMgM9C40S21zAmHCr7PQGWtq07JcIYEZHya11lEMwE91PKKYTTVtgRxOwoxWaRmObSljDU5Ox5XQrVCxQr4RiF9wlE4IakteraELNu4mHPlHTPYQea+ORqsGZeyQhrBx03L/2gL3zkqt/sHHOYJqtvJR2t2/ZC9zw38LwwVZgHQuVzcudUo9dD8by0agfKeIv7SReNcX6Hckc9MJDHWCpHlFaHBI3x17zmbV1BLfhx15Xo9lIpjz9wruyqZKGWZutzWw58Yf8ADTrNnLbKcab1EQ/OvUglpfbCGnxFig8OE+a52j25h5xwxGFEga7KTnYM2XvqiUG8kj2HGXq+Clxw4Y2dZTMkS2IFor/pSpKBVcQWYjqx3G/K9x5PPe/CZAmcW2goEmc+IUx6YK6tlFw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 9:54 AM Marco Elver wrote: > > > +depot_stack_handle_t stack_depot_set_extra_bits(depot_stack_handle_t handle, > > + unsigned int extra_bits); > > Can you add __must_check to this function? Either that or making > handle an in/out param, as otherwise it might be easy to think that it > doesn't return anything ("set_foo()" seems like it sets the > information in the handle-associated data but not handle itself ... in > case someone missed the documentation). Makes sense, will do in v2 if Alexander doesn't object to the interface change. Thanks!