From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C14FC433F5 for ; Thu, 30 Dec 2021 19:11:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F0606B007D; Thu, 30 Dec 2021 14:11:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8793D6B007E; Thu, 30 Dec 2021 14:11:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6F2196B0080; Thu, 30 Dec 2021 14:11:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0249.hostedemail.com [216.40.44.249]) by kanga.kvack.org (Postfix) with ESMTP id 567636B007D for ; Thu, 30 Dec 2021 14:11:58 -0500 (EST) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 07E5A8995F for ; Thu, 30 Dec 2021 19:11:58 +0000 (UTC) X-FDA: 78975405516.30.D435132 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by imf18.hostedemail.com (Postfix) with ESMTP id EE5451C0008 for ; Thu, 30 Dec 2021 19:11:47 +0000 (UTC) Received: by mail-il1-f181.google.com with SMTP id b1so19585921ilj.2 for ; Thu, 30 Dec 2021 11:11:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0B1QA/OwI2lHBTPwaGSFFWLygKR3T0IMOccEPyW54+I=; b=I5w21MLCIyny4rxcZut+liGLCPTNYQ3E7IG+KbxdKWqko1onajZ1v+6QjhXgAjJ6DN J1LyqJWEhbdmT+jXI+0k5FVBH7gYx3H4cJ+/pGb6UVRAvPdCAq2eDMA0Hl/Bv2uuP0sw kFPjlJHydUm0kmW+9URr6GngKreflsf6DfFWYFd5EcW5A5Cm/8t1lxWJuyDQC9slIUq/ VIbh5xFn62bWRBv008rBi1BMKm7EYU9rpi/b7XEx6C7aXQiQmHJfMabAfYqtxY9GunjR t9VOhfG5CFBQDzmNZhKkWAk0YUzBnHhTQczqCNFzU/OrQO/WLo+lhTASuc0GeIMDeHKt yFoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0B1QA/OwI2lHBTPwaGSFFWLygKR3T0IMOccEPyW54+I=; b=Gokd2W0zA+Q9U5RXkDZllAXR7ckDmkO2Z4aRJiw3w7cA79o5udA3zlWgBGHFqPKcsC ww1RaqvW0w3BCDgyZrccauHHYzVQpH+AgREHkrs+NJTF+o83xOTsObBVNeoF+pVJxigc T5MioIym2c57pIhu/Bs+vrxijKwd1VEzgWlOBFuJ2pKlrAdbgN2HqDmeQfejIFzIhS8O f+hhu4HyNCk3CfagqCphsUnmV0qaKaRrWEfacpXcdIZge+57YJvEd+E/dXfzJtYB/Ecn jN647SBGexaSFPWO3QONaoEM7pCpQnq3PkQHFfCH697RPDwZn+1kDP826+R+S0nwk6wo kskA== X-Gm-Message-State: AOAM530DXSihQdfWOVWiu0eGeK5Qov2G0DLXGb6AFflXsdfQS1dCJNy1 hLXg5mcrRzUUNAatnWzgSHegiE5WAlyQosa83/Q= X-Google-Smtp-Source: ABdhPJw5ADLAvrXVZK304cmwxaKzbBJMO24wmv+StTFc9NwPKDYEdjzTMJrXE4uqSlCxk7s/fyOfUxnWlycBbR0ytss= X-Received: by 2002:a05:6e02:178f:: with SMTP id y15mr14604983ilu.235.1640891516954; Thu, 30 Dec 2021 11:11:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Thu, 30 Dec 2021 20:11:46 +0100 Message-ID: Subject: Re: [PATCH mm v4 00/39] kasan, vmalloc, arm64: add vmalloc tagging support for SW/HW_TAGS To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: EE5451C0008 X-Stat-Signature: 5fccdfmq143bwcqofqrsp1y6drrq78uy Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=I5w21MLC; spf=pass (imf18.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-HE-Tag: 1640891507-575466 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 22, 2021 at 8:01 AM Marco Elver wrote: > > On Mon, 20 Dec 2021 at 22:58, wrote: > > > > From: Andrey Konovalov > > > > Hi, > > > > This patchset adds vmalloc tagging support for SW_TAGS and HW_TAGS > > KASAN modes. > > > > The tree with patches is available here: > > > > https://github.com/xairy/linux/tree/up-kasan-vmalloc-tags-v4-akpm > > > > About half of patches are cleanups I went for along the way. None of > > them seem to be important enough to go through stable, so I decided > > not to split them out into separate patches/series. > > > > The patchset is partially based on an early version of the HW_TAGS > > patchset by Vincenzo that had vmalloc support. Thus, I added a > > Co-developed-by tag into a few patches. > > > > SW_TAGS vmalloc tagging support is straightforward. It reuses all of > > the generic KASAN machinery, but uses shadow memory to store tags > > instead of magic values. Naturally, vmalloc tagging requires adding > > a few kasan_reset_tag() annotations to the vmalloc code. > > > > HW_TAGS vmalloc tagging support stands out. HW_TAGS KASAN is based on > > Arm MTE, which can only assigns tags to physical memory. As a result, > > HW_TAGS KASAN only tags vmalloc() allocations, which are backed by > > page_alloc memory. It ignores vmap() and others. > > > > Changes in v3->v4: > [...] > > Andrey Konovalov (39): > > kasan, page_alloc: deduplicate should_skip_kasan_poison > > kasan, page_alloc: move tag_clear_highpage out of > > kernel_init_free_pages > > kasan, page_alloc: merge kasan_free_pages into free_pages_prepare > > kasan, page_alloc: simplify kasan_poison_pages call site > > kasan, page_alloc: init memory of skipped pages on free > > kasan: drop skip_kasan_poison variable in free_pages_prepare > > mm: clarify __GFP_ZEROTAGS comment > > kasan: only apply __GFP_ZEROTAGS when memory is zeroed > > kasan, page_alloc: refactor init checks in post_alloc_hook > > kasan, page_alloc: merge kasan_alloc_pages into post_alloc_hook > > kasan, page_alloc: combine tag_clear_highpage calls in post_alloc_hook > > kasan, page_alloc: move SetPageSkipKASanPoison in post_alloc_hook > > kasan, page_alloc: move kernel_init_free_pages in post_alloc_hook > > kasan, page_alloc: rework kasan_unpoison_pages call site > > kasan: clean up metadata byte definitions > > kasan: define KASAN_VMALLOC_INVALID for SW_TAGS > > kasan, x86, arm64, s390: rename functions for modules shadow > > kasan, vmalloc: drop outdated VM_KASAN comment > > kasan: reorder vmalloc hooks > > kasan: add wrappers for vmalloc hooks > > kasan, vmalloc: reset tags in vmalloc functions > > kasan, fork: reset pointer tags of vmapped stacks > > kasan, arm64: reset pointer tags of vmapped stacks > > kasan, vmalloc: add vmalloc tagging for SW_TAGS > > kasan, vmalloc, arm64: mark vmalloc mappings as pgprot_tagged > > kasan, vmalloc: unpoison VM_ALLOC pages after mapping > > kasan, mm: only define ___GFP_SKIP_KASAN_POISON with HW_TAGS > > kasan, page_alloc: allow skipping unpoisoning for HW_TAGS > > kasan, page_alloc: allow skipping memory init for HW_TAGS > > kasan, vmalloc: add vmalloc tagging for HW_TAGS > > kasan, vmalloc: only tag normal vmalloc allocations > > kasan, arm64: don't tag executable vmalloc allocations > > kasan: mark kasan_arg_stacktrace as __initdata > > kasan: simplify kasan_init_hw_tags > > kasan: add kasan.vmalloc command line flag > > kasan: allow enabling KASAN_VMALLOC and SW/HW_TAGS > > arm64: select KASAN_VMALLOC for SW/HW_TAGS modes > > kasan: documentation updates > > kasan: improve vmalloc tests > > Functionally it all looks good. So rather than acking every patch, for > the whole series: > > Acked-by: Marco Elver > > ... and in case you do a v5, I've left some minor comments. I will, thanks! > Happy holidays! Happy holidays to you too!