From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EF60C3DA4A for ; Wed, 14 Aug 2024 16:11:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F0EDB6B008A; Wed, 14 Aug 2024 12:11:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E99006B0092; Wed, 14 Aug 2024 12:11:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D398C6B0093; Wed, 14 Aug 2024 12:11:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id ACE496B008A for ; Wed, 14 Aug 2024 12:11:15 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 00547C1066 for ; Wed, 14 Aug 2024 16:11:12 +0000 (UTC) X-FDA: 82451340426.10.E700FF3 Received: from mail-ot1-f42.google.com (mail-ot1-f42.google.com [209.85.210.42]) by imf04.hostedemail.com (Postfix) with ESMTP id D7F5D40025 for ; Wed, 14 Aug 2024 16:11:10 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OFvYhVSI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723651790; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YojC52uHbpPliLtyLOZFETHeNy9jnfDl4e/WZwHCFg8=; b=oOyLoOT3Gh7cPF1SeErvINRS6TKhFnwsYlxgwLbDxVGGSU43N9mOFNvjTimQhtxRkxcJNc XSONnUrkkzIiUEbI0ny3WM6Sq6yOVVpIkJboq4qNZXAsWnHCwJB+smB8aSDyQ8o0QpECJN ltx2j5P8GjqqXFM7unTmFe3Fk1u3H5Y= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723651790; a=rsa-sha256; cv=none; b=D/knovXeq4PIFGnJPbi3pgQbEN2rpi3Eh7jNRPhjtpToH72JFjj9/eet7rlLD7cMI2OkZ9 wbCjMTHERbS9nTrdTvG8QS3FbJWGnr5Kkypj9r/dBs86e7ganrRYuQrStBEBUx6HRN+vf3 gBVjM/K2/iEEpChx8aWqflcLMncRGvk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=OFvYhVSI; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.42 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com Received: by mail-ot1-f42.google.com with SMTP id 46e09a7af769-7093f3a1af9so4125757a34.1 for ; Wed, 14 Aug 2024 09:11:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723651869; x=1724256669; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YojC52uHbpPliLtyLOZFETHeNy9jnfDl4e/WZwHCFg8=; b=OFvYhVSIkegyfaFtFxYBicDIGF7huBdppOGTYHrNbPdb2PTmURXjbuw0gAETmg2LVI DMOsXSKWQEB7gU37+rjmj9amR94NSRkuhrzVm5cO7Xr8gb64gQF0SSoU6Hx60LlVfK2t znM9Cm3sYhia3j/pb+1JaW7KuK6dgQlHs8Z4ETiJc21CNKwXqyd4CuqiMfgHayJpnSU7 qu4By4YfT5Ip1TEXWzPeyfPGCNMh9JgPaW9DocnmUiKTaSkHSceTMFfPYLWJJZGEP+HQ 5agiuE6n6ekVN99CUVRzNnuhSlRs2l2saMEi2t7Mah/YEaJPPcM2M89FeG+5+50iaazc CnYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723651869; x=1724256669; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YojC52uHbpPliLtyLOZFETHeNy9jnfDl4e/WZwHCFg8=; b=O65tohIG3Q5zaKiMy/jtmfjHGXNAPH8zeabrQperhGYPGgDJbyLqf+BHmSQjOS0lrm P2F+4qOvHlEuOnOyd7lC0UKZlD8imlzB0bdhMHcPShDL0PDrCKr8zLQIKYi4aVwF69s5 6+9mfXnRj9W3nN+N4sxTF044I/UpIUQztA827DG810vgJ4CarAktZTKgy7M8APC5gAkN /PiO4tKdRgptResl2fcAeDTy7ELexdlV44HZwvBXJ1sLoAPyPMIs7PWg4EGoVOipUQK8 etuzrOd5s9VnfVjcWYhqWlmJLLsalHWmV8VU56A5+PK1M+prfhMHqa3+nrKKb34mEtLs iZNA== X-Forwarded-Encrypted: i=1; AJvYcCW5jP7btB+c5upP7NepalWr+/Ke+kDdXmxZEJbmQK9RNpoXsH/TDr2gV0UsRi4Hy/exCCSEpBTOrSHtSEX0ZMUx2IQ= X-Gm-Message-State: AOJu0YwA2r3ZCNKMidjWpjdzt+f45FrQirTWXHgIrAg0qG6Vcm/yKQnR x4X4uBjx20GSp2pkYAGhNC74tOURizgejmcS9CD26uz8MulEHC7h7gqcIwHbvfs0IomUWFo74zR XwyxXcDsshcsoppEOMkAuamBGVbk= X-Google-Smtp-Source: AGHT+IEOu0Zcu88kcsI8Ws76Ej67Sjrk+T87Q9CnQkmM3dkYYSvAW3tzOsVVaTPgvwdLIDUc0jgHqvGUeg8M4MIr4Dw= X-Received: by 2002:a05:6358:7244:b0:1a4:ea23:b5f3 with SMTP id e5c5f4694b2df-1b1aa9aacd8mr407202755d.0.1723651869531; Wed, 14 Aug 2024 09:11:09 -0700 (PDT) MIME-Version: 1.0 References: <20240813224027.84503-1-andrey.konovalov@linux.dev> In-Reply-To: From: Andrey Konovalov Date: Wed, 14 Aug 2024 18:10:57 +0200 Message-ID: Subject: Re: [PATCH] kasan: simplify and clarify Makefile To: Miguel Ojeda Cc: andrey.konovalov@linux.dev, Marco Elver , Matthew Maurer , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, Andrew Morton , linux-mm@kvack.org, Miguel Ojeda , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D7F5D40025 X-Stat-Signature: 35fj9at6xob4o5g5zomxwy97hw44af7i X-Rspam-User: X-HE-Tag: 1723651870-896809 X-HE-Meta: U2FsdGVkX1+pZsOTUd0VifIEapAD0/0gvXgZ0C7tNdcSKnfYrUNljOf5SoDl8te5Rzxbqj6drwf0nY3qQ8sDnlly4CkAR3zVjY4HcwCu681QSIXlC3o5zKM7ulpc5ZqODrVGs3NioaVIEDJ3ZMb/cCDfPnpuqT15C0LScGIoYAEhGB8nUwi1pBqaT+E6S811U95zbtxUei8Uceq8LOXBHTW3vy78RLil3UGeC1EL+5XT9YqbqRuyDxCUQpQq3GSh/O+nMDgmo5gZtEhRN6Iuv9SOXka4rjlXKx8m3UDVisyrvcpGRBeg6pjFtu/WGEpOfpS0BFSwytaY+lqf+5+fZVb8G1MkpvtNcvUHlUGfYbA+hXhuvEUXVJWzhKp8AaS4IKqcBR1Dk2NuV4NZSJTSvbAsx8iIrshsDX3HJ1sj0uYHqIySGDp5XAOvuFfop642AeEhM8M9tmU7dccxB2DjCNkWSaUeNM0c1X0ef3vmb0OX6EHqtpXZDyOvKVzJboAFsdX2keAsSGl7p4dLaJPkvyIZdORBfXSIJNSrFGwyNlxGM+5eKrNxEMuBW6Et2wcHoQ97Kpi8WIbI9iVr3tNTKUnEgwSVDYytxwL2GgRdBDwMBy+uUynWXy5uEq0+V5u2Yl4J5q3zQ98s7Z35C33CTn+Xm2otcVkKmuNwAsBFB5Pa1hWZYcctph6dzuMCDh2a/CN8LdV9pHc4g+DoNE7J7RApAE+AJ/zVRkba0k2UpYQ52lx+tcxk7juQpP5E4di3o2zFDU64ZLLVV883pCkpJYLhFJYV394J7TPJl8rU3zpzdvxImgXXJfSpI2YSTSdoEq8o5kmsl3P07uR5crVKyBufWtrmqlhfzn0hjs2RmBu39Q6ZS8HQ8rvlLz0YCVItRyErdyalPxV04Svmv1rQs3KRUPmETL9p/0PBEriP0n265YnQOcHOdNVRLiW3MNba2iY7pzM5aic01NhakHd rg8rh2r1 VLl1gl3UhnL4rIjAqkKpxP+u/xvSXFI71Rdbh45PxMnFqbhkqNZSXvLwcTtcCtE0RNhiLp2ejcGB4v5G6woWIAbNjfC2zZdo8EtncrrDXxpKEI3bxUGvPwLodwfe/6n1bvqgjfq+3gwH+3VKdq4ltoER9+mF53ZZMBGFbpzkecote6qeEOVpHemQjs4577pCW4Q1vsKbz8QgTUXWkheVbiKjESIgNgHI63Vuzc3M5gjsreCK3rWbTXNxxTHU19SRhRBdJZ0M4xUjGKmuqT7LaBtRULdkKMEmrayrqv/CDW/UzC7ge7u7Tsgr9bzxhwzbqX+VKyzEmzYbMvhnxu1j6xNPnFM2F94oRktvzimzpy/GUzf2AP0pp9gITShjzy6mgnzG2W/lgyC7gyYUptKvi9vQqJYWyXRQ1eA0ENE/ei3yCjlg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.003473, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 5:37=E2=80=AFPM Miguel Ojeda wrote: > > On Wed, Aug 14, 2024 at 12:40=E2=80=AFAM wro= te: > > > > Signed-off-by: Andrey Konovalov > > It is easier to read now, and indeed GCC 5.1+ and LLVM 13+ both > support the flags, so `CFLAGS_KASAN_SHADOW` can't be empty. > > > +# First, enable -fsanitize=3Dkernel-address together with providing th= e shadow > > +# mapping offset, as for GCC, -fasan-shadow-offset fails without -fsan= itize > > +# (GCC accepts the shadow mapping offset via -fasan-shadow-offset inst= ead of > > +# a normal --param). Instead of ifdef-checking the compiler, rely on c= c-option. > > I guess "a normal --param" means here that it is the usual way to > tweak the rest of the KASAN parameters, right? Yes, clarified in v2. > > +# Now, add other parameters enabled in a similar way with GCC and Clan= g. > > I think the "with" sounds strange, but I am not a native speaker. > Perhaps "in a similar way with" -> "similarly in both"? Sure, done in v2. Thank you!