From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72293CFA45E for ; Wed, 23 Oct 2024 18:42:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F24696B008A; Wed, 23 Oct 2024 14:42:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED3836B008C; Wed, 23 Oct 2024 14:42:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9B606B0093; Wed, 23 Oct 2024 14:42:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id B9ABB6B008A for ; Wed, 23 Oct 2024 14:42:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4F3F2160A66 for ; Wed, 23 Oct 2024 18:41:57 +0000 (UTC) X-FDA: 82705736484.25.CB5BF8E Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) by imf26.hostedemail.com (Postfix) with ESMTP id 6E17414000F for ; Wed, 23 Oct 2024 18:42:02 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IwCrlA5W; spf=pass (imf26.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729708858; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1Ay/OqGD2GTrz3V0tm8K+95EMKdw2lJQesOojfLv6f0=; b=hMRdEjBgsNe/FT8reacrPzA0EpFMOxwROK8s8/Mv2lLAOePcolxfYXnmQzFt0zR2XNlkrM ghWc5KJcSfXE70z0uVw6+I/2aTkblV3T8F0IvvAqb09k1np3MW5RzCA3QcZ20qytzDD13D 822HUsV1CgxxeAcNElv+DcpkNJ5tbsc= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=IwCrlA5W; spf=pass (imf26.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.221.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729708858; a=rsa-sha256; cv=none; b=C2teJPs/U1jVL76kBHfRolj2oT4Vsc7GE4pVXF5b41Kt7s/XE7bp5iHEmVEHXih23ELE// 3zGR/obe6eZa3gKeEgKaaLn6Nh0iLJwRWeABa71dSvfF+8CAzZwyzP6yVOUY6wABXPSU3I 43LM07x9cG5bSn8MERnwTvhOz86l1wo= Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-37d5689eea8so18031f8f.1 for ; Wed, 23 Oct 2024 11:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729708934; x=1730313734; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1Ay/OqGD2GTrz3V0tm8K+95EMKdw2lJQesOojfLv6f0=; b=IwCrlA5WmdLvvh+ILn5sEDzcVaF7P6RaQVJE2qUA409E7LZJ1ZxqEPi5H95xhYDE3t 1tD8qHfqnd/T+knPCNXMtzdfpFarxwXfdAwSDM+NJ8a9z6Nx4BmMYEA8d+VCpJrUqaLe fumdfYn2yzO0PRGcSuKSNwSen/RDxMR8NCsoKcJylTuv25X3V4eFeVYdNTZfpmPHe/8i UcaNC8Fqw5rol2x+muZgcbTGHT+RM2R6ho2eTRZzmCk1sR8+/Arb4m5E0CZtq5bqGPXL 9yO8vg3WeERT1q24Ny0MS9UlW26j3rUod9YxKprFtNB0ibc3DYWtVAJpqkMi2PdT1oq6 pBsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729708934; x=1730313734; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1Ay/OqGD2GTrz3V0tm8K+95EMKdw2lJQesOojfLv6f0=; b=PG4hY0kUUoOubDcMf9qhfHddikleWQk/GX0RU+jc4WxRr2GtKJdII43048/2VmfFBU E88Twtt+gZ+yXyMYEdIvsUd2IqHR0jnbNUaYcpy2SK6bvCZYa3f5VB5zMq2btTdKQe+z XWSE1t1zMWDBdiykWdDpjJ9l1ZqOw1fFwSV3RroApToi62RPWMsINMrOsZt0RHX5KXcf z+YtPDzasCojkLc6QQxzizjSBHlILfdnFntFOFVnpuj9o2ibWdEdtTp6oDikonPdf1F4 VSEyE59EDxP96WvzRXJrzW8/IYkwP/D0Q3j/oN6LKkX/375WVP2GyUUqRhLc5Fg76FTx yBlA== X-Forwarded-Encrypted: i=1; AJvYcCUZJuCTUhvpwCPcEHspKJOvbzkYr4aIwpWi4nmLNAX/ZuPj0c+HOMUNwlJoeKfNzVoykvPETqNTyg==@kvack.org X-Gm-Message-State: AOJu0YxGaSU9d9LHOsmfaJkl2GciBLIu+pDR8qGcmhvvyruyMfdp+7ox d/FDFngFXlDrkHOGD3lo/D9HxO8icteXHJkmfdrqwDt0m7ABkiyta66D+NNLUgnL21miuzTf6ws tRIEwlVdiLG3E+O32UDFG2ANzXE8= X-Google-Smtp-Source: AGHT+IFB3tSRsLc8IJ+ZLmbBRgiQxMJcijIbkhHI+LcLoWS2ExMHeUZd0pXljEEFRrdcgGNxkIUIlWkiXJ0JtmbA57I= X-Received: by 2002:adf:f5c4:0:b0:37d:5338:8733 with SMTP id ffacd0b85a97d-37efcf7ba95mr2248780f8f.37.1729708933928; Wed, 23 Oct 2024 11:42:13 -0700 (PDT) MIME-Version: 1.0 References: <20241022015913.3524425-1-samuel.holland@sifive.com> <20241022015913.3524425-4-samuel.holland@sifive.com> In-Reply-To: <20241022015913.3524425-4-samuel.holland@sifive.com> From: Andrey Konovalov Date: Wed, 23 Oct 2024 20:42:03 +0200 Message-ID: Subject: Re: [PATCH v2 3/9] kasan: sw_tags: Support outline stack tag generation To: Samuel Holland Cc: Palmer Dabbelt , linux-riscv@lists.infradead.org, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , kasan-dev@googlegroups.com, llvm@lists.linux.dev, Catalin Marinas , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Alexandre Ghiti , Will Deacon , Evgenii Stepanov , Andrew Morton , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 6E17414000F X-Stat-Signature: kqie4y6ni5tr45mfco3zhj94ewie598g X-HE-Tag: 1729708922-320198 X-HE-Meta: U2FsdGVkX189NlPJ9WGkPel24eoXyh8VnzBVkuCT5bgjspyoi5mN6c564+xR2PLybZvRfIRa7Ulsp4wvTrDzJXLb2NHBDR/CBvATya5Qngqxt6ySNNg/YpiquYZ9187vACHNWRHwtNWWnwS0O6VEsT+8Fq2+hjZN1iAZORGUCczgwJIAV0V+lJ1LpZUsBzncKS52d86kAWfIezHW1A69nA11o7+cK/Gy/Wi2pzY0A70VSSGuNcRVAnVwhJXlE8WTGkFSkXoCuDEchz97XIRhz4THsXIMTahE1L8idGk8rI1MiGI0uHYPASH0vF++HLNB7ekRmQZ8xxaKZOQIV5ZfaelYqxmLOfPCkFbVxfAo3KsjzM/ksOpge4egi/gbNr7Le1elr2BA9qrKFRJj7eGmsDHzmVXxRG9k5DD9yCFLhxc8TTkrXZi1lkt65SA12ccR4m9Utuhac8iEOVFwWhZQZHMEd1cMrF43sqGS0nw/I8H+R6smnBMm+67LVmVlC+emNCNzTfGYUwdnQ8PNXxJLSX6pdKs++3k0p4KsvXp5L0qk8CHKjfpBCBlsGUD3PlMkSKbm0cCZt61VIjxqKp81lYc98J0X6mZS20pomZWMZN1HJuuAD/yKSgEuKGKFEp1L9eUuGzq3ugL6xU4Pf4Sfk035ox0gdtp/+GCmy5Au9h4J4apEQdzmcsOyhrROWra7wowRyk2b8GjzfepS0u+5RFnp4SQ+yEW9Rt1866TDWp2LDn69pueQvo1kK6Ka7HTOtvfj67yIDsW/P0gArn2D6sqwkz40HgzNBO23jB+VjiKdCC/sCTOQ7ZLthWWYNLxokNAJp03zNxoJkOX9zqnqySELt/gxEPTB3MlU3muRYMebbK77tCw4dDIRDL4RXMNdOZ/yv/GyeppLHhehu6RyXQFHu00jjsLRv1Kgra3f3MOS/KH6VuW/6rSXofgi2S4cwDP2XCQNLZRodZiZpA7 6Ncphzm4 D3wkaiVIJyDpo83XLVsHHG9FHhpH7MPrX75wOCa8jKF9KDe8vNXbKlzk3FuZ8zgyTgoWFB2TYKuro/6bGDILmZupbABypT3iowPJX2lY/Acbao0/iEryx801KlA+edV1ZaBgcmfqKhX7VaIvwDD47srgR4+Yrbh5V1OMj1C02MhuXoySAA9tWaUQbKxYW1FXcnFEPzfABYWtNEAxEEVY2JvmYyjuUpKjxUWH6j7Yh8uLlJYQ1FOeREfApfyPm52nFjtGlTG4baiDn2f2sxQ18TAPJ+wSxok03LeyVfkAMtmowKSEjVpHjGyg3bnxRIgAcAnNSgljX/Reu/uxX9sJoqCmMCPt8BMPSwdHBM5dnRnuToKlByJUyW2DuFW7J+34io09hYgR26FLtozk2vUXTIFABsK2JenBsvkptDDhs5KgfKPX9+IZVyKftwaUjj+bHIHVny/fDNLj/lzew3OxLe/GgEp9kXGc9SVtBZJBcvjspQCJ1az0Zm8BdQaZDCLIorjGjtH2zWzAJGFE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 22, 2024 at 3:59=E2=80=AFAM Samuel Holland wrote: > > This allows stack tagging to be disabled at runtime by tagging all > stack objects with the match-all tag. This is necessary on RISC-V, > where a kernel with KASAN_SW_TAGS enabled is expected to boot on > hardware without pointer masking support. > > Signed-off-by: Samuel Holland > --- > > Changes in v2: > - Split the generic and RISC-V parts of stack tag generation control > to avoid breaking bisectability > > mm/kasan/kasan.h | 2 ++ > mm/kasan/sw_tags.c | 9 +++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index f438a6cdc964..72da5ddcceaa 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -636,6 +636,8 @@ void *__asan_memset(void *addr, int c, ssize_t len); > void *__asan_memmove(void *dest, const void *src, ssize_t len); > void *__asan_memcpy(void *dest, const void *src, ssize_t len); > > +u8 __hwasan_generate_tag(void); > + > void __hwasan_load1_noabort(void *); > void __hwasan_store1_noabort(void *); > void __hwasan_load2_noabort(void *); > diff --git a/mm/kasan/sw_tags.c b/mm/kasan/sw_tags.c > index 220b5d4c6876..32435d33583a 100644 > --- a/mm/kasan/sw_tags.c > +++ b/mm/kasan/sw_tags.c > @@ -70,6 +70,15 @@ u8 kasan_random_tag(void) > return (u8)(state % (KASAN_TAG_MAX + 1)); > } > > +u8 __hwasan_generate_tag(void) > +{ > + if (!kasan_enabled()) > + return KASAN_TAG_KERNEL; > + > + return kasan_random_tag(); > +} > +EXPORT_SYMBOL(__hwasan_generate_tag); > + > bool kasan_check_range(const void *addr, size_t size, bool write, > unsigned long ret_ip) > { > -- > 2.45.1 > Reviewed-by: Andrey Konovalov