From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AA5FC32771 for ; Mon, 26 Sep 2022 18:08:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F0808E0077; Mon, 26 Sep 2022 14:08:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A10F8E0066; Mon, 26 Sep 2022 14:08:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E83CD8E0077; Mon, 26 Sep 2022 14:08:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id D86D68E0066 for ; Mon, 26 Sep 2022 14:08:11 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A55611207F1 for ; Mon, 26 Sep 2022 18:08:11 +0000 (UTC) X-FDA: 79955020782.25.E2B6AE8 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by imf09.hostedemail.com (Postfix) with ESMTP id 583D1140009 for ; Mon, 26 Sep 2022 18:08:11 +0000 (UTC) Received: by mail-qt1-f175.google.com with SMTP id s18so4618375qtx.6 for ; Mon, 26 Sep 2022 11:08:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=zbTeqblGxrVphEvYs4g+Za5JLZuDmNmIQK0NJlTmwT8=; b=oVxNzol03dnNpfu8QmUcTpPCYwZXy8WzsbfWjT6qo9tTEJ9iGCHEgdXPYUPRVRN2YZ +LlCMbPpzeDXNNo0t6CHPpWw14cpueJclTJ2scnlnjI4Z/v+6k14CtruMcIGHgTWFmYt +gh+eg4XVZ3nM64TeZh1XxY3CwUxU9B7zrcHrf9CRrhveWswrZWYVokVNWw2hYV9J3Qp 3S0AGlHwV+UkIaqzP7blQzYcawju1Qm80RnCAmsrkxLdD7citixAx2Q00PhjeUYD/Z6G /Vm6CcPxGXdXrrGNrFuQFZcgPEMPo9O+OfK9R3Ib27TyKzj2Z8l/hFSusyXtzAoiMjuZ utUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=zbTeqblGxrVphEvYs4g+Za5JLZuDmNmIQK0NJlTmwT8=; b=pmO4ENUSuAzhUwRcXi0BB54hD+Mo4k8+get4e7kOVA443cu4cD+OHPeC3lMkroeY8d WLFzAYWnToXpy0ue5/+c87bv7Vaw2GkoHNObO4mAvy73c5gZed9XAis+2ycDXEtOotFg XsREhvRYskHFFwP+d1fJZx9VWXMS49Wo39L9opmZ+Zv1K7O88KAf8oqJh2VohQv4fzkJ kCUa/gfscE2TIhgUFKERgeVkOK52kqNnJ8rJMJ+EWX8+WXRqT5D4V5a5CV4Sf/guefra rC2XLwHSiuHYF7G6YwXnqWg5osWXi+jEjeWqsuaiehRBGfYKo1zKaObFUp/XOBS5xX0J uDWA== X-Gm-Message-State: ACrzQf3A8M8CHgRGr91kj74vZ8jqqz0z5Wz9fh8lrVvouunJweMJiel9 I8QJmPXibh6qlM6xRSpeoV9hU5Jbf0Va8U8GtBc= X-Google-Smtp-Source: AMsMyM6eatwvx5/wUwL+eLNx14HtahXAw8TMeZ969Y1GO53xCjGzunGRKw9qVUVg1OwbN1vRJZCXK9zcWeDR8JgSTpM= X-Received: by 2002:a05:622a:8b:b0:35d:430d:e53d with SMTP id o11-20020a05622a008b00b0035d430de53dmr3962001qtw.391.1664215690624; Mon, 26 Sep 2022 11:08:10 -0700 (PDT) MIME-Version: 1.0 References: <9c0210393a8da6fb6887a111a986eb50dfc1b895.1664050880.git.andreyknvl@google.com> <20220925100312.6bfecb122b314862ad7b2dd4@linux-foundation.org> In-Reply-To: <20220925100312.6bfecb122b314862ad7b2dd4@linux-foundation.org> From: Andrey Konovalov Date: Mon, 26 Sep 2022 20:07:59 +0200 Message-ID: Subject: Re: [PATCH mm v2] kasan: fix array-bounds warnings in tests To: Andrew Morton Cc: andrey.konovalov@linux.dev, Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Kees Cook , LKML , Andrey Konovalov , kernel test robot Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oVxNzol0; spf=pass (imf09.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1664215691; a=rsa-sha256; cv=none; b=bxmaxzV8vOEQxdmuY6ccvRTWUrDxpdB3YY3KYZi0k+JzXpMm+Cdq5V5wVrC3+fw+aCtVWx Or3BpJvob4Ut9kQBsRuii92P+TCUxAtgXfh1yupqY8KVD00SHc/6GUa3/Omx1HKvdRnInZ TdOxtQsAWKuznj0XkqhMTqFAHB71uKc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1664215691; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zbTeqblGxrVphEvYs4g+Za5JLZuDmNmIQK0NJlTmwT8=; b=a9ExtRFy39IgzRPL6uI2X5aPdveCEjXXMWouDGHR3ypINsRrRkaHx/4gh07enSrtTRcfJk k/cbCXk3hHoIw5mU3qpcnqXbjwLflVuQxatcy0xGLc6SKjXXDjEcY3Sj52OnNnp4SS8lWL eHeTd9ttUqcIGO44LZbEkEWGRiT/54E= Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=oVxNzol0; spf=pass (imf09.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.160.175 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 583D1140009 X-Stat-Signature: 4opjz15gsht1xuhqr8ngy4xwuq4ipszf X-HE-Tag: 1664215691-917173 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Sep 25, 2022 at 7:03 PM Andrew Morton wrote: > > > --- a/mm/kasan/kasan_test.c > > +++ b/mm/kasan/kasan_test.c > > @@ -333,6 +333,8 @@ static void krealloc_more_oob_helper(struct kunit *test, > > ptr2 = krealloc(ptr1, size2, GFP_KERNEL); > > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr2); > > > > + OPTIMIZER_HIDE_VAR(ptr2); > > + > > /* All offsets up to size2 must be accessible. */ > > ptr2[size1 - 1] = 'x'; > > ptr2[size1] = 'x'; > > @@ -365,6 +367,8 @@ static void krealloc_less_oob_helper(struct kunit *test, > > ptr2 = krealloc(ptr1, size2, GFP_KERNEL); > > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr2); > > > > + OPTIMIZER_HIDE_VAR(ptr2); > > What chance does a reader have of working out why this is here? If > "little" then a code comment would be a nice way of saving that poor > person for having to dive into the git history. Will add in v3. Thank you, Andrew!