From: Andrey Konovalov <andreyknvl@gmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: andrey.konovalov@linux.dev, Marco Elver <elver@google.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Linux Memory Management List <linux-mm@kvack.org>,
Kees Cook <keescook@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
Andrey Konovalov <andreyknvl@google.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH mm v2] kasan: fix array-bounds warnings in tests
Date: Mon, 26 Sep 2022 20:07:59 +0200 [thread overview]
Message-ID: <CA+fCnZe3SYq1c50hKdR3eoALz+kHE2MdUkbcbG0dhUFjaKkPNw@mail.gmail.com> (raw)
In-Reply-To: <20220925100312.6bfecb122b314862ad7b2dd4@linux-foundation.org>
On Sun, Sep 25, 2022 at 7:03 PM Andrew Morton <akpm@linux-foundation.org> wrote:
>
> > --- a/mm/kasan/kasan_test.c
> > +++ b/mm/kasan/kasan_test.c
> > @@ -333,6 +333,8 @@ static void krealloc_more_oob_helper(struct kunit *test,
> > ptr2 = krealloc(ptr1, size2, GFP_KERNEL);
> > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr2);
> >
> > + OPTIMIZER_HIDE_VAR(ptr2);
> > +
> > /* All offsets up to size2 must be accessible. */
> > ptr2[size1 - 1] = 'x';
> > ptr2[size1] = 'x';
> > @@ -365,6 +367,8 @@ static void krealloc_less_oob_helper(struct kunit *test,
> > ptr2 = krealloc(ptr1, size2, GFP_KERNEL);
> > KUNIT_ASSERT_NOT_ERR_OR_NULL(test, ptr2);
> >
> > + OPTIMIZER_HIDE_VAR(ptr2);
>
> What chance does a reader have of working out why this is here? If
> "little" then a code comment would be a nice way of saving that poor
> person for having to dive into the git history.
Will add in v3. Thank you, Andrew!
prev parent reply other threads:[~2022-09-26 18:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-24 20:23 andrey.konovalov
2022-09-25 17:03 ` Andrew Morton
2022-09-26 18:07 ` Andrey Konovalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+fCnZe3SYq1c50hKdR3eoALz+kHE2MdUkbcbG0dhUFjaKkPNw@mail.gmail.com \
--to=andreyknvl@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andrey.konovalov@linux.dev \
--cc=andreyknvl@google.com \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=ryabinin.a.a@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox