From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3C39C433EF for ; Tue, 31 May 2022 19:25:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D4206B0071; Tue, 31 May 2022 15:25:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 682906B0073; Tue, 31 May 2022 15:25:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 546786B0074; Tue, 31 May 2022 15:25:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 46FD46B0071 for ; Tue, 31 May 2022 15:25:10 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1743521513 for ; Tue, 31 May 2022 19:25:10 +0000 (UTC) X-FDA: 79527016380.13.97797C4 Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by imf05.hostedemail.com (Postfix) with ESMTP id A28CE10005B for ; Tue, 31 May 2022 19:24:35 +0000 (UTC) Received: by mail-io1-f48.google.com with SMTP id 62so6798158iov.4 for ; Tue, 31 May 2022 12:25:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=laksvj7tZyE5VfjRjxemXKqC6M/6B12dc0r+gd4pLSY=; b=qeNPEzonX3bCWTM4a4Otdhfg66OsyZPyGRQmqwX/A5k5ZHfzwX+DQsB4tuyCbqJtys TgR1d2CJYKWYel6bjsq3sBjTKxWswcu24zyuKGoLmTjMp/GzWD5NQ8BYXC9hxPX080mi 8AzGtOdMMnmIiDTe6N/4iFy8MoX0cbz7tNQT1CVKlxOAa1WD4A+Cxj88/++nNXMI9525 S/V+WoNp/0SmgPIIDo2/VD34+ef+MfP8wvlLJcDpsDgNirPcIySDKI8N/ijTaTtBr0Pn s83naywkoullNDe1942zZF0GrBvgkNXx5BT+vsj81jJ571nfVZKMTu07G6z2Mew+W7kg W1sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=laksvj7tZyE5VfjRjxemXKqC6M/6B12dc0r+gd4pLSY=; b=uOoZ6cP10WnSs6pz9G+txj3jJFVC/pbhvNSQmECuloDZt2IE5Ym4K6Q0ehdFOhR9K7 NaE5UkD4ZM60o6b4etWeV1kW54DtT0ZazSjt+u8ulBCMj7/nR29y1UD19quYaacZvHmg E+uxMPtstXFa8AR2qp8fnfXiSjCFdfpeHrFI49u32u9yW7yPGYEPI89wiNgTloI08Gbx GSwQmCtzrz/OLh8yuWcH+54FcUFrVxXLVeun4HnAnqPKvK8WTfS4dW3toTUVPvwS3l5K CSf4WoaOcDzBLpLeEzH84WHyMtURzs+LY2op1HfG40JCK9x2zpFhz5DErfEU+ZXkrV17 wOCQ== X-Gm-Message-State: AOAM532br/TK8H/AFjdbjKA9slnx7cgdswMPFUiso09P9VJybpQoIZHe W2oMYDtOuNFp0aS8JxAwIFtpbN2S1ZHdPYk/Rs8= X-Google-Smtp-Source: ABdhPJz0rV8XQi8hDUNqCk1ex/1IT3XH2q3iTT9AyvNYOhXkXFQEknTRLjaikUvfKN3J4g9+LJr7k8HXfmXbXta8yEM= X-Received: by 2002:a6b:3115:0:b0:660:d5f1:e3b6 with SMTP id j21-20020a6b3115000000b00660d5f1e3b6mr22025461ioa.99.1654025108757; Tue, 31 May 2022 12:25:08 -0700 (PDT) MIME-Version: 1.0 References: <4c76a95aff79723de76df146a10888a5a9196faf.1654011120.git.andreyknvl@google.com> <20220531105200.587db61db99f19e308a05c5e@linux-foundation.org> In-Reply-To: <20220531105200.587db61db99f19e308a05c5e@linux-foundation.org> From: Andrey Konovalov Date: Tue, 31 May 2022 21:24:57 +0200 Message-ID: Subject: Re: [PATCH 2/3] mm: introduce clear_highpage_tagged To: Andrew Morton Cc: andrey.konovalov@linux.dev, Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qeNPEzon; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf05.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.48 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A28CE10005B X-Stat-Signature: f6ad65bf89ud6ud1qym9p1u5r13m5enz X-HE-Tag: 1654025075-503807 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 31, 2022 at 7:52 PM Andrew Morton wrote: > > On Tue, 31 May 2022 17:43:49 +0200 andrey.konovalov@linux.dev wrote: > > > From: Andrey Konovalov > > > > Add a clear_highpage_tagged() helper that does clear_highpage() on a > > page potentially tagged by KASAN. > > clear_highpage_kasan_tagged() would be a better name, no? Sounds good! Will include into v2. I also noticed there's an extra empty line at the end of the function I need to fix. > > --- a/include/linux/highmem.h~mm-introduce-clear_highpage_tagged-fix > +++ a/include/linux/highmem.h > @@ -243,7 +243,7 @@ static inline void clear_highpage(struct > kunmap_local(kaddr); > } > > -static inline void clear_highpage_tagged(struct page *page) > +static inline void clear_highpage_kasan_tagged(struct page *page) > { > u8 tag; > > --- a/mm/page_alloc.c~mm-introduce-clear_highpage_tagged-fix > +++ a/mm/page_alloc.c > @@ -1311,7 +1311,7 @@ static void kernel_init_pages(struct pag > /* s390's use of memset() could override KASAN redzones. */ > kasan_disable_current(); > for (i = 0; i < numpages; i++) > - clear_highpage_tagged(page + i); > + clear_highpage_kasan_tagged(page + i); > kasan_enable_current(); > } > > _ >