From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7004FC636CC for ; Tue, 31 Jan 2023 18:58:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D673E6B0074; Tue, 31 Jan 2023 13:58:12 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D16996B0075; Tue, 31 Jan 2023 13:58:12 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BDDFB6B0078; Tue, 31 Jan 2023 13:58:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id ADA746B0074 for ; Tue, 31 Jan 2023 13:58:12 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2F50040C94 for ; Tue, 31 Jan 2023 18:58:12 +0000 (UTC) X-FDA: 80416004424.18.C88A9F7 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf03.hostedemail.com (Postfix) with ESMTP id 6D86A20013 for ; Tue, 31 Jan 2023 18:58:10 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dou2Jilz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675191490; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bCWK8k8m5VD33jjUoYPOLmfdpETQJTETp3AURhGUsTI=; b=Q6/A6pGP33De2j7aWSB7RmJ8cfrkqTVjSt1iBtW+Om5bFjmrRFTJIwMZKI5JGK7Wcg1OPg J9rj7UUFEMHS2o6Uc8yXyuinH4lvMmLur7AtqMzYoaLtmdJLfi+WP4IqGjrwRq24kDdENT wBeNsKCEKzwK4phzv12Skbkc4E7yS0g= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=dou2Jilz; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf03.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675191490; a=rsa-sha256; cv=none; b=KICvQFW/WkgLl3Cm3zBWH/1iQyaS42ZYOlaelGmuvxNOSScpIW0IJk3Essrgff6gjI2jng AsSZXz7QiNVrQDogDhu8FSIWjN3OIJpdGsSQG6Z656k5ANasgvWOWj5BsWP/sjsLjdlO5u JiZcrnelt8qB9bR7QNebIeog6gnz07Q= Received: by mail-pf1-f181.google.com with SMTP id g9so10927636pfo.5 for ; Tue, 31 Jan 2023 10:58:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=bCWK8k8m5VD33jjUoYPOLmfdpETQJTETp3AURhGUsTI=; b=dou2JilzlSfcvD6beS/Lc7cUD4v6y1YTLvqqI6xnQ2iXPrGyqyNyFytIfursaV15G1 1CSvEbmrKE7U5Hbxk46wdTs8ETu2idQVtwYxVcZG+HkPWeZiPqWHmkcSYHr8o0WnHVRZ 7nWbpmtPqJ3DO4YjV6aLbJ6K/19Ec4kxOFo9vduSFZSR8JIlMqpkGbNBjAbT5lhsdvnj ZqtVZdIT5mw7ILf5qFHwrZ/IESHzJX1XzLMQ1cHuuVhapZntySbnwoXrR9j2DWxp/UKv CdFlwMop+9m3Mqc14Gxl4E0IvqismmudhrgG70wVQ1ofkgq8bogEJT0mop1XBzYla/jx Lx/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=bCWK8k8m5VD33jjUoYPOLmfdpETQJTETp3AURhGUsTI=; b=eACEtelb7rENDn5qF6mOMVLo5ZvKZMrjwR4ypuz9BMi0A4YaSqmPW7LBJPy835FT9X FxhzeFOaizG25v4e6oWr6cHT96FHjgdGqTlIw8Vr7j70RZKhqHJ1uvREo9NWPiaEHeC1 lBKs7ho+DIThSKDt1Qw6hTNeOjQcnzVCL1QPxzSkOaT5S2UpK/ZONqwo52TCXi8zqYmB rAh+OBLNIQ/1fgXZx8lWYJzjGb2o8E7gvSfmQNeVOK2HuJtY98stnH1lVz0rPa1q/5EC Qy7AxD2ZZDFMthWCuv9GGGxFvEbs6zvuPWQ4OOFNKSIdUNgngQjge936v67KJ5mjPdD7 /3+A== X-Gm-Message-State: AO0yUKWIFmPxhHjvF0kJIDYAB6DPVDjz7st2sf43aqiIrtXGQlPcV03s P9vRazt9GCpsB4Texm2vLnKP3lw0LVdJIw12huQ= X-Google-Smtp-Source: AK7set8dA9Ys2TgYqLX2FGRSRFnPJERimQrle+4WRunjf0aTyqg/0dZcq4caPZM9ksDh+XPYg2QgTXqqhJxAB2I+vFU= X-Received: by 2002:a05:6a00:9aa:b0:593:e0ce:fc20 with SMTP id u42-20020a056a0009aa00b00593e0cefc20mr1061238pfg.28.1675191489136; Tue, 31 Jan 2023 10:58:09 -0800 (PST) MIME-Version: 1.0 References: <19512bb03eed27ced5abeb5bd03f9a8381742cb1.1675111415.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Tue, 31 Jan 2023 19:57:58 +0100 Message-ID: Subject: Re: [PATCH 16/18] lib/stackdepot: annotate racy slab_index accesses To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 6D86A20013 X-Stat-Signature: wed8cionsdrrmnphp3hceeuatfj9yj37 X-HE-Tag: 1675191490-435999 X-HE-Meta: U2FsdGVkX1/HS2oW1hkM/8Sbjr4cxGxYSmFBwmWca/ctlypKr/Pc8HMlJ6FtYmbp/yy7GGzOJthls1UHay1qtFHDYIjBiq6uFp4JsVPTZkaAz9MMDSDSgFISGmXIkofCOpC2vhcZDPBULjNcLbHKGdMIsd8eFf9eoCH7g2EZpO3nV4BvIRppk8nWYXHxO32zb/WksTiJEuN+rD7cLXC4yNAAtnECaVujrzWAD3c4i8rRwoUn/fiEAGZ8/ZVFFg+5gkHj8i/UTNXkFB8BCnujQTzekBVxaa23345x1HyKk78MqKi0i6Bs+kITYF671IKERL/38xJLI5CvofPQg135SFdQWZREJ0y1eOc4aWhB9STpcWTu8PF84khYOUTCftBjShBJ9KQdYydWIcCpc8ZOOefuItSpxlvF0JZ0s4Dk4i0T+1Z7ZyI6FOl+f61PfnLUP5YFweZLX80W9u2lvE4mX3HuZ0OgGzdMnMojSR2dReFJgevvuuoo8J+Qj9CRBxEcJ/zf91544Z0CvxgGqd3a9l85uV1rZoW3qX+CHC3E4jrIuxQ62xoPCzGWmsFMBjz6SXL+mEybfDmM7J6IZjfXsQGb91811imfYhrTiYkwKFezKdLhdMR5Of1jf5wcdreuMnnmBFZfvE5vbtiTb7BLW9EiRRcs2doyi3XvQMWgZi8BLm/bEPZv3Os7ANOkMM1+RFwmAfvUejp05wpUZ5WKSief1RMwVcGuCwLUSxt/gtRTo4CMdG4wATRWMlz8TCam82nANX9N5N3H3XAKPH2H8ZQV9twKWx9j6snrxrx0yjwqQhuKi5GGssr4htYQ4k9si6f4FnqxZQStDOQe6lrxuMPq+xJyqtBMOgUZvFlvXraW3f7Fg1d5YbYL4hQ1PdBcPq1I/rWeK0RRm6tWdwwr1EJIHwVWWO7tZCbhxre2Mp0VHfwcpa9rTSPyJhTGCKkm59DGAmWXuh2b3CZmgyV LuAMz4kw i3Sdj/0ylm6w3NJ0oQ00E1EyoantRxZqc7zP4H13J077uxg00bHP+T93Fc+htLv+S9zA1mTJw8R6CvBQLD3bT4TSsEvWtCmrhZXNL4LPJRclBqJkcAXi5vfRFe9nfyexAeTrnb4n4wwj7wK+OkFCmQ6sDfyS6uAGarbQ1MwQ/Acdmo97E41lZH0TkUrUikD8chJzhC0fgzVu2AZSrflu+VEbSRqy6HEmSZCowjBICiVR3P2+QHSElAsiGzi1TkqNOn+r4PpQGekNSy8gNQD/vMA4wA4RXkTIvU2I+YSoZoAAnPObXx17T21zzNeCtuIayAf6iRlKd478Tt3Og7ZNXDUvrZeEo5kd9OMb9FKL50OaCwdJR5Ji5J7yZIhwhzpwCyHaZXHLOMv54yJivp6zbY58q6Mu5JLXZHKDzAGk3JNRJknN8R6PV7me7lA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 9:41 AM Marco Elver wrote: > > > diff --git a/lib/stackdepot.c b/lib/stackdepot.c > > index f291ad6a4e72..cc2fe8563af4 100644 > > --- a/lib/stackdepot.c > > +++ b/lib/stackdepot.c > > @@ -269,8 +269,11 @@ depot_alloc_stack(unsigned long *entries, int size, u32 hash, void **prealloc) > > return NULL; > > } > > > > - /* Move on to the next slab. */ > > - slab_index++; > > + /* > > + * Move on to the next slab. > > + * WRITE_ONCE annotates a race with stack_depot_fetch. > > "Pairs with potential concurrent read in stack_depot_fetch()." would be clearer. > > I wouldn't say WRITE_ONCE annotates a race (race = involves 2+ > accesses, but here's just 1), it just marks this access here which > itself is paired with the potential racing read in the other function. Will do in v2. Thanks!