linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Konovalov <andreyknvl@gmail.com>
To: Maciej Wieczor-Retman <maciej.wieczor-retman@intel.com>
Cc: Florian Mayer <fmayer@google.com>,
	Vitaly Buka <vitalybuka@google.com>,
	kees@kernel.org,  julian.stecklina@cyberus-technology.de,
	kevinloughlin@google.com,  peterz@infradead.org,
	tglx@linutronix.de, justinstitt@google.com,
	 catalin.marinas@arm.com, wangkefeng.wang@huawei.com,
	bhe@redhat.com,  ryabinin.a.a@gmail.com,
	kirill.shutemov@linux.intel.com, will@kernel.org,
	 ardb@kernel.org, jason.andryuk@amd.com,
	dave.hansen@linux.intel.com,  pasha.tatashin@soleen.com,
	ndesaulniers@google.com,  guoweikang.kernel@gmail.com,
	dwmw@amazon.co.uk, mark.rutland@arm.com,  broonie@kernel.org,
	apopple@nvidia.com, bp@alien8.de, rppt@kernel.org,
	 kaleshsingh@google.com, richard.weiyang@gmail.com,
	luto@kernel.org,  glider@google.com, pankaj.gupta@amd.com,
	pawan.kumar.gupta@linux.intel.com,  kuan-ying.lee@canonical.com,
	tony.luck@intel.com, tj@kernel.org,  jgross@suse.com,
	dvyukov@google.com, baohua@kernel.org,
	 samuel.holland@sifive.com, dennis@kernel.org,
	akpm@linux-foundation.org,  thomas.weissschuh@linutronix.de,
	surenb@google.com, kbingham@kernel.org,  ankita@nvidia.com,
	nathan@kernel.org, ziy@nvidia.com, xin@zytor.com,
	 rafael.j.wysocki@intel.com, andriy.shevchenko@linux.intel.com,
	cl@linux.com,  jhubbard@nvidia.com, hpa@zytor.com,
	scott@os.amperecomputing.com,  david@redhat.com,
	jan.kiszka@siemens.com, vincenzo.frascino@arm.com,
	 corbet@lwn.net, maz@kernel.org, mingo@redhat.com, arnd@arndb.de,
	 ytcoode@gmail.com, xur@google.com, morbo@google.com,
	 thiago.bauermann@linaro.org, linux-doc@vger.kernel.org,
	 kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
	 llvm@lists.linux.dev, linux-mm@kvack.org,
	 linux-arm-kernel@lists.infradead.org, x86@kernel.org
Subject: Re: [PATCH v2 13/14] x86: runtime_const used for KASAN_SHADOW_END
Date: Fri, 21 Mar 2025 21:16:12 +0100	[thread overview]
Message-ID: <CA+fCnZdunJhoNgsQMm4cPyephj9L7sMq-YF9sE7ANk0e7h7d=Q@mail.gmail.com> (raw)
In-Reply-To: <t5bgb7eiyfc2ufsljsrdcinaqtzsnpyyorh2tqww2x35mg6tbt@sexrvo55uxfi>

On Fri, Mar 21, 2025 at 8:21 PM Maciej Wieczor-Retman
<maciej.wieczor-retman@intel.com> wrote:
>
> >To account for this, let's then set hwasan-instrument-with-calls=0
> >when CONFIG_KASAN_INLINE is enabled. And also please add a comment
> >explaining why this is done.
>
> After adding this option the kernel doesn't want to boot past uncompressing :b
>
> I went into Samuel's clang PR [1] and found there might be one more LShr that
> needs changing into AShr [2]? But I'm not very good at clang code. Do you maybe
> know if anything else in the clang code could be messing things up?
>
> After changing that LShr to AShr it moves a little further and hangs on some
> initmem setup code. Then I thought my KASAN_SHADOW_OFFSET is an issue so I
> changed to 4-level paging and the offset to 0xfffffc0000000000 and it moves a
> little further and panics on kmem_cache_init. I'll be debugging that further but
> just thought I'd ask if you know about something missing from the compiler side?
>
> [1] https://github.com/llvm/llvm-project/pull/103727
> [2] https://github.com/SiFiveHolland/llvm-project/blob/up/hwasan-opt/llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp#L995

Hm, I only recall looking at the compiler code when investigating [1].
But as this series points out, [1] can be considered a feature and not
a bug. Other than that, nothing comes to mind.

Thanks!

[1] https://bugzilla.kernel.org/show_bug.cgi?id=218043


  reply	other threads:[~2025-03-21 20:16 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-18  8:15 [PATCH v2 00/14] kasan: x86: arm64: KASAN tag-based mode for x86 Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 01/14] kasan: sw_tags: Use arithmetic shift for shadow computation Maciej Wieczor-Retman
2025-02-19 23:29   ` Andrey Konovalov
2025-02-21 13:11     ` Maciej Wieczor-Retman
2025-02-22 15:06       ` Andrey Konovalov
2025-02-25 17:20         ` Maciej Wieczor-Retman
2025-02-25 19:12           ` Maciej Wieczor-Retman
2025-02-25 20:12             ` Maciej Wieczor-Retman
2025-02-25 21:38               ` Andrey Konovalov
2025-02-26 16:42                 ` Maciej Wieczor-Retman
2025-02-26 19:44                   ` Andrey Konovalov
2025-02-27 12:27                     ` Maciej Wieczor-Retman
2025-02-28 16:12                       ` Maciej Wieczor-Retman
2025-03-01  0:21                         ` Andrey Konovalov
2025-03-04 14:06                           ` Maciej Wieczor-Retman
2025-03-07  1:10                             ` Andrey Konovalov
2025-03-13 14:56                               ` Maciej Wieczor-Retman
2025-03-18 15:31                                 ` Andrey Konovalov
2025-02-25 21:37           ` Andrey Konovalov
2025-02-27 12:33             ` Maciej Wieczor-Retman
2025-03-01  0:22               ` Andrey Konovalov
2025-03-04 12:29                 ` Maciej Wieczor-Retman
2025-03-07  1:10                   ` Andrey Konovalov
2025-03-14 15:57                     ` Maciej Wieczor-Retman
2025-03-18 15:32                       ` Andrey Konovalov
2025-02-18  8:15 ` [PATCH v2 02/14] kasan: sw_tags: Check kasan_flag_enabled at runtime Maciej Wieczor-Retman
2025-02-19 23:30   ` Andrey Konovalov
2025-02-21 14:35     ` Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 03/14] kasan: sw_tags: Support outline stack tag generation Maciej Wieczor-Retman
2025-02-19 23:30   ` Andrey Konovalov
2025-02-18  8:15 ` [PATCH v2 04/14] kasan: sw_tags: Support tag widths less than 8 bits Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 05/14] kasan: arm64: x86: Make special tags arch specific Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 06/14] x86: Add arch specific kasan functions Maciej Wieczor-Retman
2025-02-19 23:30   ` Andrey Konovalov
2025-02-21  8:40     ` Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 07/14] x86: Reset tag for virtual to physical address conversions Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 08/14] x86: Physical address comparisons in fill_p*d/pte Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 09/14] mm: Pcpu chunk address tag reset Maciej Wieczor-Retman
2025-03-20 17:39   ` Andrey Ryabinin
2025-03-20 17:47     ` Andrey Konovalov
2025-03-21 10:40     ` Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 10/14] x86: KASAN raw shadow memory PTE init Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 11/14] x86: LAM initialization Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 12/14] x86: Minimal SLAB alignment Maciej Wieczor-Retman
2025-02-19 23:30   ` Andrey Konovalov
2025-02-21  7:24     ` Maciej Wieczor-Retman
2025-02-18  8:15 ` [PATCH v2 13/14] x86: runtime_const used for KASAN_SHADOW_END Maciej Wieczor-Retman
2025-02-19 23:31   ` Andrey Konovalov
2025-02-21 15:10     ` Maciej Wieczor-Retman
2025-02-21 15:27       ` Maciej Wieczor-Retman
2025-02-22 15:08         ` Andrey Konovalov
2025-02-22 15:07       ` Andrey Konovalov
2025-02-25 17:15         ` Maciej Wieczor-Retman
2025-02-25 21:37           ` Andrey Konovalov
2025-02-26 11:52             ` Maciej Wieczor-Retman
2025-02-26 15:24               ` Andrey Konovalov
2025-02-26 17:03                 ` Maciej Wieczor-Retman
2025-03-21 19:20                 ` Maciej Wieczor-Retman
2025-03-21 20:16                   ` Andrey Konovalov [this message]
2025-03-24 10:43                     ` Maciej Wieczor-Retman
2025-03-24 10:50                       ` Maciej Wieczor-Retman
2025-03-24 21:58                         ` Andrey Konovalov
2025-02-18  8:15 ` [PATCH v2 14/14] x86: Make software tag-based kasan available Maciej Wieczor-Retman
2025-02-19 23:31   ` Andrey Konovalov
2025-02-20 16:32     ` Andrey Konovalov
2025-02-21 14:44     ` Maciej Wieczor-Retman
2025-02-22 15:06       ` Andrey Konovalov
2025-02-25 15:39         ` Maciej Wieczor-Retman
2025-02-20  2:49   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CA+fCnZdunJhoNgsQMm4cPyephj9L7sMq-YF9sE7ANk0e7h7d=Q@mail.gmail.com' \
    --to=andreyknvl@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=ankita@nvidia.com \
    --cc=apopple@nvidia.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=baohua@kernel.org \
    --cc=bhe@redhat.com \
    --cc=bp@alien8.de \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=cl@linux.com \
    --cc=corbet@lwn.net \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@redhat.com \
    --cc=dennis@kernel.org \
    --cc=dvyukov@google.com \
    --cc=dwmw@amazon.co.uk \
    --cc=fmayer@google.com \
    --cc=glider@google.com \
    --cc=guoweikang.kernel@gmail.com \
    --cc=hpa@zytor.com \
    --cc=jan.kiszka@siemens.com \
    --cc=jason.andryuk@amd.com \
    --cc=jgross@suse.com \
    --cc=jhubbard@nvidia.com \
    --cc=julian.stecklina@cyberus-technology.de \
    --cc=justinstitt@google.com \
    --cc=kaleshsingh@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=kbingham@kernel.org \
    --cc=kees@kernel.org \
    --cc=kevinloughlin@google.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=kuan-ying.lee@canonical.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=llvm@lists.linux.dev \
    --cc=luto@kernel.org \
    --cc=maciej.wieczor-retman@intel.com \
    --cc=mark.rutland@arm.com \
    --cc=maz@kernel.org \
    --cc=mingo@redhat.com \
    --cc=morbo@google.com \
    --cc=nathan@kernel.org \
    --cc=ndesaulniers@google.com \
    --cc=pankaj.gupta@amd.com \
    --cc=pasha.tatashin@soleen.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=richard.weiyang@gmail.com \
    --cc=rppt@kernel.org \
    --cc=ryabinin.a.a@gmail.com \
    --cc=samuel.holland@sifive.com \
    --cc=scott@os.amperecomputing.com \
    --cc=surenb@google.com \
    --cc=tglx@linutronix.de \
    --cc=thiago.bauermann@linaro.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=tj@kernel.org \
    --cc=tony.luck@intel.com \
    --cc=vincenzo.frascino@arm.com \
    --cc=vitalybuka@google.com \
    --cc=wangkefeng.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=x86@kernel.org \
    --cc=xin@zytor.com \
    --cc=xur@google.com \
    --cc=ytcoode@gmail.com \
    --cc=ziy@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox