From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E195BC35274 for ; Thu, 21 Dec 2023 20:22:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 843B66B00A2; Thu, 21 Dec 2023 15:22:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7F4886B00B3; Thu, 21 Dec 2023 15:22:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6BC366B00B4; Thu, 21 Dec 2023 15:22:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 5AB0A6B00A2 for ; Thu, 21 Dec 2023 15:22:41 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 08576C06C8 for ; Thu, 21 Dec 2023 20:22:41 +0000 (UTC) X-FDA: 81591948522.03.82CD2D2 Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf21.hostedemail.com (Postfix) with ESMTP id 3DC3C1C001E for ; Thu, 21 Dec 2023 20:22:39 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QCQDM5SF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703190159; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=TJf9nuaR/XCC7BWiN5csd+/5Qq/ivgehUMmQB0WS6r4=; b=6lTtZDtJa5Uk9MoCSRtwIIV4NDJPmf5WMGzst2R4FNtP0gSVIMQJ2eLkqwUHg7h4ldg102 CnSaRBDC5hGL9H2X6MUxLHuyd6Mva+4xNYWQ6gSnXgfHMLQH5RFQ3QnnP0W31yEa07c95r SRcTLisdCNeT1aT5pvSil0aB/ZZZ528= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=QCQDM5SF; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf21.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.210.182 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703190159; a=rsa-sha256; cv=none; b=ra9QbdDMXcfX2FnHRdsTmWvS9hDwC4AwlnlPcjV5vaKfnLLH4yHg7Bgv3xao/SnvSPSgaJ yf2F4Xsykk/zw47NBHT9F5SHDCl01SXHE7XcMGXD3G2jliNe/SYaQnkPVSQIFpGw/hk+Pm 5iRkhvkn7dLz46ZOT0pPHB3AlPYIrGU= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-6d728c75240so1109183b3a.1 for ; Thu, 21 Dec 2023 12:22:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1703190158; x=1703794958; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=TJf9nuaR/XCC7BWiN5csd+/5Qq/ivgehUMmQB0WS6r4=; b=QCQDM5SFxeJZKg47651bfSCr9u0sn2CydJQhpQ3YRbaBRArttPDa8qMxUoNyoBvpvN P0gB/fUOxfpS7OqZoBmk9TEmX8lCcpvp+W97sGXayXrjLRMrFc+TKTdnh98cvAFYl1dN etNai/LDT23NaBpurYtbu5KtK+teyx8vVZyZmjHFUkUGhmlCJOv5Fj8qzT0Xw0l1ku4G /RUsN8jamod/NrnBX2v7A3aL7mDAh/vKLhTg5NTGeddOEMjK2H+lNbVltfGycVvxtyTV /QX2k5/q3eyR0G450/yS/K6H1V2cM3SYelnS3I75kgGxKA6EZ/50iI47zU6CW5hQtIna y9gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703190158; x=1703794958; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TJf9nuaR/XCC7BWiN5csd+/5Qq/ivgehUMmQB0WS6r4=; b=JtBGy99aRtaQXH5SfzxjeK87WZ5g16T/O6c+bVpz8aXk4Y2kFW4GlYeBFL66icz32O txHvUF/aR/nEBnbK0Y7COvB9JPFn0IaNbtNBjlJGzTVLkWBPxIq6lnIusJWdV8Sly0Ya 82op/cgrD4D3EOmtIQ1tGVAfekypbjX2dTOEzknAaHIHyL4Pzs20Kvlhrhd0ayeGuXIu qKk46n4zQQroGZEkmh6U1hXo44CjxN2JFRahWcawTJaetZiVl3kRUFb487IojVpReyxP 33lmyAaSbHw66r52kK+Y92ec4FrGTTijH8yc+SJo+33KadPObK/cAemKZlRQ4Ap+Eefi 3VsQ== X-Gm-Message-State: AOJu0YwOTej/1/KOW4M1Oy2v/0r0KNyWLq+WFY1TDfnHARqYt76C7mPP Gw5HLZo/iEuTHONkqEXqPXM0b2y+R+1T+Q1L+Kk= X-Google-Smtp-Source: AGHT+IEH5hVzh22rIwbxWBhyTyjJeCwSanEeVGFAP/K0tRx8IwKn1kh1xbcWq7dft2QuQpTODH5edaTU3AkW9xg6y6Q= X-Received: by 2002:a62:e703:0:b0:6d9:4598:d1f6 with SMTP id s3-20020a62e703000000b006d94598d1f6mr236967pfh.18.1703190158185; Thu, 21 Dec 2023 12:22:38 -0800 (PST) MIME-Version: 1.0 References: <20231221183540.168428-1-andrey.konovalov@linux.dev> <20231221183540.168428-4-andrey.konovalov@linux.dev> In-Reply-To: From: Andrey Konovalov Date: Thu, 21 Dec 2023 21:22:27 +0100 Message-ID: Subject: Re: [PATCH mm 4/4] kasan: simplify kasan_complete_mode_report_info for tag-based modes To: Marco Elver Cc: andrey.konovalov@linux.dev, Andrew Morton , Juntong Deng , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev@googlegroups.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3DC3C1C001E X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: y5idb3if49b6d9skojn5oa1c4dhe9hp1 X-HE-Tag: 1703190159-349675 X-HE-Meta: U2FsdGVkX1+e82OSGRIii9IjtHkFba8lNfAZYBZZoDV29OhgNNyTuQEmdFAUBXDNHnmn81RbEB6zhBQiNSsirtrWTocH0N3znXXa6xl9odftxDtCScdlb083sVfoDP8wTLKjIojebvc7KSeP3qtEpIG0uIM88Okb0Mbfx7Tf+aLUcG1iFcCZRPaJoUQicJZrA9nYL3iKzP+VKq2eTzGXllw4Jcq82Zw/y+765g3cGfnSju74TMnkShe5eORV4D+gR0MASe8+PRwFdJtxI5pSpxntpVHID0kxudh0ybpwMSVMppVqwF6eTMnE02g9dOnrOc1gYaW5llM3J0gkMCw3cpLYy4MVBj7MJ51McmJlnzVi5iyKkgRKZ7jFQuXcDSC9O82NxyB58MsqgtQNCnpS7Hr51p4wTlPK56BZcvDQHjqIF/uuhcBczrimE8uPKVujb6Fcoxlma9mJPoE8qFKR/ZIU07bd/MQp3MEP6Pi6ZwJOCYLIdTb4bXmLrLVJ/aB2b5iaUK+ivcJ7U2WVBfIssvqZN8sbjbMp9NRexMMxD0cGADDQUjbeLW9/1cT+NwxF7fHLvCgvLSdA0gQyMP/Xjt0htMKrasQ7oWr+tYmIQ0e8jUwB9JdKEK/E90yGsZoxp+Hs+2bVARqbMsYqT67SsrcMnjsa52r6RKToJSksjBPhxFYClKVVzdeeCIGsQUebBDj8cOCSgl5ocWpb7pPcu7rXpkuD/gF2XhPfJ7dYT9QTjTqjPLuxghnUpyo4pw2k7P8uAzOKF3njx8qo0s8kipP7D8jX+6yZX3CKk/NdEjIrcK77aEuf/ljyJOj7srTuesn1R9wBl5S2D6wgoT/B5TAP19jhMnG8jzlJ6bETNKDI6yNju3pJJJRnANIRJqzi9tLbwuI3wl7WeaDJ1rMhudFTDw+ngv6HY0Z51sCcJjp6yQUt95e0twCJOzO7bIFnPZrB1zUDL7VrZZZwaCP 4tPgkeIJ MPMSdYOaHklyf5oE48+5tvTcbT4R0iVQqyZX4vVF9LKtMDdKtlz9/FWguOsU9od9A1tDkPhdqK+UfH0rF2NuHhxQ+RcEh3Ql5nAxgdxmXr6kLQs9Dl9hqJSQL4fqagJiEqe5jWVp/L9nMcbsdkMJLXhJg6tUN8K1QiTnL6JTuI3eaIzqBDB+j47mq99tAJsZFHU8bYel/8PgTpET/bDIFjnXOqKLWVazNkZYCCsiS/RvBbaW5wpbQLQbR2UDJMdukpXwyYk1hZ3MYnxehRod0tKF1vr+K5gUPIfOV5Ih703htV1cCH//7kOSZ21ObEXOaQBHQvMrdj0JtCod4OtCLeTWECpbYrPOKtSjZsfhLnrW/3H93WdwKnYAQ7c22Y4cPCDq8Exb0bVC90FRx1ipsPRFxEEoqg1cBz7TLhhOnVKdu1mgCFce6WvUPGKY/dONM0eDm8YQ48tE5XW+L5aAIbdIvsYXFgyhI6jbTHWQw86Hca688FI0m4t2fK79HxYFQFEgTDfd4BHLohDL20PQKQO1mew== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 21, 2023 at 9:14=E2=80=AFPM Marco Elver wrot= e: > > On Thu, 21 Dec 2023 at 19:35, wrote: > > > > From: Andrey Konovalov > > > > memcpy the alloc/free tracks when collecting the information about a ba= d > > access instead of copying fields one by one. > > > > Fixes: 5d4c6ac94694 ("kasan: record and report more information") > > Signed-off-by: Andrey Konovalov > > Reviewed-by: Marco Elver > > > --- > > mm/kasan/report_tags.c | 23 ++++------------------- > > 1 file changed, 4 insertions(+), 19 deletions(-) > > > > diff --git a/mm/kasan/report_tags.c b/mm/kasan/report_tags.c > > index 688b9d70b04a..d15f8f580e2c 100644 > > --- a/mm/kasan/report_tags.c > > +++ b/mm/kasan/report_tags.c > > @@ -27,15 +27,6 @@ static const char *get_common_bug_type(struct kasan_= report_info *info) > > return "invalid-access"; > > } > > > > -#ifdef CONFIG_KASAN_EXTRA_INFO > > -static void kasan_complete_extra_report_info(struct kasan_track *track= , > > - struct kasan_stack_ring_entry = *entry) > > -{ > > - track->cpu =3D entry->track.cpu; > > - track->timestamp =3D entry->track.timestamp; > > -} > > -#endif /* CONFIG_KASAN_EXTRA_INFO */ > > - > > void kasan_complete_mode_report_info(struct kasan_report_info *info) > > { > > unsigned long flags; > > @@ -80,11 +71,8 @@ void kasan_complete_mode_report_info(struct kasan_re= port_info *info) > > if (free_found) > > break; > > > > - info->free_track.pid =3D entry->track.pid; > > - info->free_track.stack =3D entry->track.stack; > > -#ifdef CONFIG_KASAN_EXTRA_INFO > > - kasan_complete_extra_report_info(&info->free_tr= ack, entry); > > -#endif /* CONFIG_KASAN_EXTRA_INFO */ > > + memcpy(&info->free_track, &entry->track, > > + sizeof(info->free_track)); > > Not sure why the line break is necessary. Ah, just the old desire to use 80-column line limit :) Let's keep this as this for now, but I'll fix it if I end up sending v2 of this series. Thanks!