From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23FF9C433EF for ; Thu, 30 Dec 2021 19:11:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B3D96B0074; Thu, 30 Dec 2021 14:11:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 916EF6B0075; Thu, 30 Dec 2021 14:11:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78F116B0078; Thu, 30 Dec 2021 14:11:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0024.hostedemail.com [216.40.44.24]) by kanga.kvack.org (Postfix) with ESMTP id 680026B0074 for ; Thu, 30 Dec 2021 14:11:47 -0500 (EST) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 266CD181AC9CC for ; Thu, 30 Dec 2021 19:11:47 +0000 (UTC) X-FDA: 78975405054.16.B5E6A4E Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by imf11.hostedemail.com (Postfix) with ESMTP id 2F6D440006 for ; Thu, 30 Dec 2021 19:11:43 +0000 (UTC) Received: by mail-io1-f42.google.com with SMTP id q5so30597448ioj.7 for ; Thu, 30 Dec 2021 11:11:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0fiv6RL03GYq28gBLTG+oAUxzJLFmuBgFQ32/iqru78=; b=fHvkh4VbM8vMN4jMQ0x3mlFVPT+dqyKP7tPF3+OIdnJfSfsSr5rPuCpvTs23Gmt5c9 hrkw9T2uMFs0NK0MGguQg3+QGr4xZv+AmIq649MWpbTWQo25cFMIiRUB6YG0XcyCFBZB 5lQnW6wzFPQM/mt9O7JVJ9Q3oZ51NyrMTrYbzT7dbvn371+8vONU+iV04J6N8I6itBw/ pQwJhEaMjSqaB3a6hE4reQSK9HdMFt2BNqbvZOL4YlTje+bsZWCCfAvMPuy5hR+6brzl 0Q52yE3uK2SW6xQ1m7sjZu8HU2NZTrFadwhwRnO8ng0u5Rzd26POu0O4bo8AtPSSYxb5 mrIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0fiv6RL03GYq28gBLTG+oAUxzJLFmuBgFQ32/iqru78=; b=jtTgWjmdfzqu8TC+IEqfmeMFPvQ0Hn/gqHOFjJe81o8FqRdcHVprZPeTZeHrpbcNd2 qhtZI55QphDJhpX8yWdA+mnyU9m0eiIdaL/tUbgHXqKVm372zdLGbX3c8YHnHAfPEs3O BBlo1aQ+ixLKtFML8ximwOGyI5D/jWQmm/AKjDh2IaBV4Q0pUP7K7zq1GRQxKOPo9mye mbIl4xWly2XqqMYcgAj9EEIEGN69bWkQllBvKIT0ZFI0mWgf8uFC8grE1h3ZJuEhlQzz Qxwqz9ws8CRS7uSZmu38geU80mqymE732gYFKeVIY5dviorOpOTBuJzgEmv5xdupAV68 GzBw== X-Gm-Message-State: AOAM533tLgn6bFQiaslpBr7ha/aoW74PMzjduzM74CC9Fnxryg+l/f3E 0+Sm/BRN7+SNzv4TLODwMEIu2jzEexVvcuSRPVU= X-Google-Smtp-Source: ABdhPJy0XlHoc6IPNyedHtl279SyfKStumMeOkCGBsJTLPIBAlT3ptpCJGmDcw2JSzuhMXJuV5WnoFlyCg9SpNnDMi0= X-Received: by 2002:a6b:7e03:: with SMTP id i3mr14544209iom.202.1640891506249; Thu, 30 Dec 2021 11:11:46 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Thu, 30 Dec 2021 20:11:35 +0100 Message-ID: Subject: Re: [PATCH mm v4 29/39] kasan, page_alloc: allow skipping memory init for HW_TAGS To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2F6D440006 X-Stat-Signature: nkrngesg5gi4dwqjqnjybw39xx7utxmd Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=fHvkh4Vb; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.42 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam10 X-HE-Tag: 1640891503-347984 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 21, 2021 at 1:12 PM Marco Elver wrote: > > On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > [...] > > +static inline bool should_skip_init(gfp_t flags) > > +{ > > + /* Don't skip if a software KASAN mode is enabled. */ > > + if (IS_ENABLED(CONFIG_KASAN_GENERIC) || > > + IS_ENABLED(CONFIG_KASAN_SW_TAGS)) > > + return false; > > + > > + /* Don't skip, if hardware tag-based KASAN is not enabled. */ > > + if (!kasan_hw_tags_enabled()) > > + return false; > > Why is the IS_ENABLED(CONFIG_KASAN_{GENERIC,SW_TAGS}) check above > required? Isn't kasan_hw_tags_enabled() always false if one of those is > configured? It is. I wanted to include those checks for completeness, but maybe they just cause confusion instead. Will drop them in v5. Thanks!