From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0F9DC021AA for ; Wed, 19 Feb 2025 23:31:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5544244018A; Wed, 19 Feb 2025 18:31:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5042B280276; Wed, 19 Feb 2025 18:31:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A3E244018A; Wed, 19 Feb 2025 18:31:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 19E7F280276 for ; Wed, 19 Feb 2025 18:31:04 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A177FC03E5 for ; Wed, 19 Feb 2025 23:31:03 +0000 (UTC) X-FDA: 83138292006.14.1B2E714 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by imf06.hostedemail.com (Postfix) with ESMTP id 99676180012 for ; Wed, 19 Feb 2025 23:31:01 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XF6xr0Il; spf=pass (imf06.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740007861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4dUybulOhS0kE/3bK++ET9eEzpvtsmycFrLhnO/LKN0=; b=qV8ewW3rWUGAqXaNXLe9LGe/YrchET8RJ+ORN/sS2Wo0VfL5Vzj+39DOYoRDueiH7unPfX 8oEwxTe4cVtyo85F0PEVrQrJPWXCoVC9V+RWwh9U2Y5iq2nWC8iMeSoFeBjN0Rk+w5FPei 9QhuURWv2xJ2Jd9AWsuzx5u7HzOgQns= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740007861; a=rsa-sha256; cv=none; b=qSB4ULn5ObyGQAtjA7H644CIB36N+wGz4QaZr7AmWzhetyAl4p8lqdh0ZmixE97t+hie4h ZHRQAmrwf7mOqH4TFnA/hwDSfewTkc9BmlZhU68Lpbjy99HK7jolapOaaYMp5gR/M2cSjj 21HOPyhz+a06GYKKCgVv+9Qv+TmtrWw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=XF6xr0Il; spf=pass (imf06.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.128.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-439a4dec9d5so551195e9.0 for ; Wed, 19 Feb 2025 15:31:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1740007860; x=1740612660; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=4dUybulOhS0kE/3bK++ET9eEzpvtsmycFrLhnO/LKN0=; b=XF6xr0IlThl1iaHiTAVj5c8jl/GK3bcxNsbgYjd0U5ov36ib+AfK5C2ImFkibhApla o+E6IFd+5xZck34yneEvOtG7dMvkK/34b/lSGtpMsW5VgRszMftcHd2gG8vxmJPe5RAk /zPChqP+8Kdz8vyw0JMlyqrfdg8KLlbT7sWkdtqODyCXroYudlA70iePdaN+D64y9dgy /KiC48Y57eB3fBlIh0KLdqIOuXbb2OEQqalIznF46jRFJ90USh88JRLVzhoL94b8H+Nn O6uhHvtlTmxixi4rWWSEnQMjuBkmaKFJnVh35cpwNxOcDvgrx6bm21+eHT7RLiGNUCfL +xVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740007860; x=1740612660; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4dUybulOhS0kE/3bK++ET9eEzpvtsmycFrLhnO/LKN0=; b=vTPmAQhT5TN1eLNaTFpnPAJKUwAUpmvE7+v0n+05S9+IXMnX2l07aso7F26HWXJxxF F+kXPkl4Vmn2fcQfBGY7+4m9FrzQUM+nTrUJaDKPufLm/Ql3CbtY6hLJJmdoiMHIovPU /C88mC1f+nrlP9GhhfzbCS7ULhcAovGarCixjgLzCXmoYS32my+t9iDZy9qrl/K0ShiN RqjxDeg36IgX13fFmeX/TR74GHBeSd+noHneW8Iojx/kOcinJ61nbjP+5p0cyH03b2WL jb1mN7qU1HKJIqKDBt8cweQUX3zHCPU/Ry2xau+P5GNQgWPG4ZumOGCnH+zQOPmFPZsW kc2Q== X-Forwarded-Encrypted: i=1; AJvYcCVup7rJNAItIhUhpm9KODb3aJYzS9Jn41g6zg61+jKmc1Vj6qL8b3U5eB+bXwzHVvBImxEKAtuLGQ==@kvack.org X-Gm-Message-State: AOJu0YyPdOWW0GJPuYvUcIIHk0b8XBBb1pncFAAzODjTbbKl0dz1CxB8 D6Ye9/eaMAvkgSXLpTUfaMMIOb/1xvJly8Nol0foaSEXkFeBWsbJbu6LsyUkK3ps0gpiHcmoEQs zq9pIldlErEcx0+i4jLN8/ua12o8= X-Gm-Gg: ASbGncsRAeWnf55ur8tFOq00HU8yz5ZGQlplbY2CmtkZgLVjznw0zg2T0+LOYFnIGEU IZuAL4sJFF+kgS50Xc/5Po9ohQNZerb/ezEvquXR039nBYvr5K+F9zh/McJkbfd5ef/8juLXz8j I= X-Google-Smtp-Source: AGHT+IG1BHmj8hJr/EIeAG45G5dk1X7q0NRly/wfy8NOAsFrU4xoOf+BepllUdF4Fr5/tdIMeI62DxfMSontKQGQR5s= X-Received: by 2002:a05:600c:46ce:b0:439:a255:b2ed with SMTP id 5b1f17b1804b1-439a255b574mr11307125e9.9.1740007860050; Wed, 19 Feb 2025 15:31:00 -0800 (PST) MIME-Version: 1.0 References: <7492f65cd21a898e2f2608fb51642b7b0c05ef21.1739866028.git.maciej.wieczor-retman@intel.com> In-Reply-To: <7492f65cd21a898e2f2608fb51642b7b0c05ef21.1739866028.git.maciej.wieczor-retman@intel.com> From: Andrey Konovalov Date: Thu, 20 Feb 2025 00:30:48 +0100 X-Gm-Features: AWEUYZl1gRQjDF8bP12LoQKOk6SUSp8U6yzsjJnNm_UbyNhEUb3N5bt4_wbtQpk Message-ID: Subject: Re: [PATCH v2 12/14] x86: Minimal SLAB alignment To: Maciej Wieczor-Retman Cc: kees@kernel.org, julian.stecklina@cyberus-technology.de, kevinloughlin@google.com, peterz@infradead.org, tglx@linutronix.de, justinstitt@google.com, catalin.marinas@arm.com, wangkefeng.wang@huawei.com, bhe@redhat.com, ryabinin.a.a@gmail.com, kirill.shutemov@linux.intel.com, will@kernel.org, ardb@kernel.org, jason.andryuk@amd.com, dave.hansen@linux.intel.com, pasha.tatashin@soleen.com, ndesaulniers@google.com, guoweikang.kernel@gmail.com, dwmw@amazon.co.uk, mark.rutland@arm.com, broonie@kernel.org, apopple@nvidia.com, bp@alien8.de, rppt@kernel.org, kaleshsingh@google.com, richard.weiyang@gmail.com, luto@kernel.org, glider@google.com, pankaj.gupta@amd.com, pawan.kumar.gupta@linux.intel.com, kuan-ying.lee@canonical.com, tony.luck@intel.com, tj@kernel.org, jgross@suse.com, dvyukov@google.com, baohua@kernel.org, samuel.holland@sifive.com, dennis@kernel.org, akpm@linux-foundation.org, thomas.weissschuh@linutronix.de, surenb@google.com, kbingham@kernel.org, ankita@nvidia.com, nathan@kernel.org, ziy@nvidia.com, xin@zytor.com, rafael.j.wysocki@intel.com, andriy.shevchenko@linux.intel.com, cl@linux.com, jhubbard@nvidia.com, hpa@zytor.com, scott@os.amperecomputing.com, david@redhat.com, jan.kiszka@siemens.com, vincenzo.frascino@arm.com, corbet@lwn.net, maz@kernel.org, mingo@redhat.com, arnd@arndb.de, ytcoode@gmail.com, xur@google.com, morbo@google.com, thiago.bauermann@linaro.org, linux-doc@vger.kernel.org, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 99676180012 X-Rspamd-Server: rspam07 X-Stat-Signature: 6uitf9bit4rdimtbkak8whokju75qwxp X-HE-Tag: 1740007861-829263 X-HE-Meta: U2FsdGVkX1/5oZY4fgovTIx9o3fFtYDhzaUhz3NNxDO1Scz/ATIb/uhch9Z4ViCxYRKvPMB2s9d8BsGkmNb2a01pL/2cz2JY7wupw2uT6y/tris9AQHyQrMYri72PY45nwreIHnB2RgEIXP9V07Md9tgD7yw+U/TfXoWGVwi4XSOm463xKzAkRkHqRoLkeithOrXtwzQLcbECtmOmL2S7nfm2p88li0GdemZpTlbCJfGju/PL6uuqPmwHN8+8gLYLre78/1KSOngMaObbzr4jDUCvrpE6FJvPAGGEuZNcBayLnRFKtcah9YlTBc/6gxPi091rlke42OFeiuDrx5cWiKe7BL5I+Vj129ZNjTvswY84U0q2vAunaDqLMO8NBiFm/+0dtcLHIyk7ZiOARPEHIBEDjw65dUI78kWiCCy0w8U8GRwelV8rv/aWzb4NWvy5/j6y9Wx1iREO9M2wq7sHfpzzuqFaZiMX90lm7PiQI0N0MDx5VmYh4bzxJXnVUawPoBT9mWi5YmuPqmVgtu2i142ZSlWlei42kvhzNYtR6FHG3DPfEya7K0B3gV8lpBmV1Eq3Py3cMAow95lTWaSeMoPSreph7ad/r4NMnLNa0iinvY2x/GbTGeczlKq8aHs6kMXp0yesWZsXx0IxKYPVKxInQcqBToDqgg4j/PwnAjxR/u2+eVP3CLnFjmMiWm+DgHvszSmDV/L6Oaqk5v1q71rYlAgRaTEZuWadi6hm1Zs0zWjtHsTnJj2CMyBtU0EIY2aJuOZ3ORQ827Aw8LgL3HrrGlqDblyyuqVpHpvzyiO01uJGTigBnlqjPrYgWN7eefSxITntDaBSQ0pt1I4qKLy7ayL7wJ2VtSMTY1x7DCZyDZInhS4F5FVCLT6bOlb62rBwGgNn9aZ0MXBEjMJEBwPlkuSLI1ajUj9NKOGBZtArBHDwxXnwifCsO8O4XG41Nz+0EMwfct7KS2dF4e Q7xWhoxo 3h11yQHtXrKf6KePlagz0ZIQhcwTlHh8/+NGhcJ6vgZPmjlX0LipVUfjm6yPa8o1gOgZRJZ2fyW2enmmHn9iofiXA4z90zD+TJZO3S7gc2sBpSeo30ShACI/ilVFedWc98z9dpgpKqpZQIQx3VEdAum1SlJnnHovo1Px/NNbsvMGHiBNAUxIuJOaJl3lHUPDVc/KPQRPXkr8DRfbBm1qMdwFhvwCU+R3wd8NlMgbmWffeENYLJaHr7WtlGR/Scq8r0WWxRNtvyQXYxb5hsPBRS6LH++EBVgUZZh2At/o1D3673b8TtAMhc0xARuUo+XfSDJqJuzZz2I4fk4dK9qd2z/7PVPYgXpgqwucfJCRso7gt6Iq96qSDOLwQ1PpZyfKiybLDWIBXQOvH8DfqHJc9jftygKd5+iAZGGja X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Feb 18, 2025 at 9:20=E2=80=AFAM Maciej Wieczor-Retman wrote: > > Adjust x86 minimal SLAB alignment to match KASAN granularity size. In > tag-based mode the size changes to 16 bytes so the value needs to be 4. This 4 should be 16. > > Signed-off-by: Maciej Wieczor-Retman > --- > arch/x86/include/asm/kasan.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/x86/include/asm/kasan.h b/arch/x86/include/asm/kasan.h > index 8829337a75fa..a75f0748a4b6 100644 > --- a/arch/x86/include/asm/kasan.h > +++ b/arch/x86/include/asm/kasan.h > @@ -36,6 +36,8 @@ > > #ifdef CONFIG_KASAN_SW_TAGS > > +#define ARCH_SLAB_MINALIGN (1ULL << KASAN_SHADOW_SCALE_SHIFT) I believe ARCH_SLAB_MINALIGN needs to be defined in include/asm/cache.h: at least other architectures have it there. > + > #define __tag_shifted(tag) FIELD_PREP(GENMASK_ULL(60, 57), t= ag) > #define __tag_reset(addr) (sign_extend64((u64)(addr), 56)) > #define __tag_get(addr) ((u8)FIELD_GET(GENMASK_UL= L(60, 57), (u64)addr)) > -- > 2.47.1 >