From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 932B4C07E99 for ; Mon, 5 Jul 2021 11:12:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 3A28E6135F for ; Mon, 5 Jul 2021 11:12:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A28E6135F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EC0E56B0011; Mon, 5 Jul 2021 07:12:43 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E71546B0036; Mon, 5 Jul 2021 07:12:43 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D11756B005D; Mon, 5 Jul 2021 07:12:43 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0213.hostedemail.com [216.40.44.213]) by kanga.kvack.org (Postfix) with ESMTP id A8C8D6B0011 for ; Mon, 5 Jul 2021 07:12:43 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 333E018297713 for ; Mon, 5 Jul 2021 11:12:43 +0000 (UTC) X-FDA: 78328271406.06.B4A4DF9 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf13.hostedemail.com (Postfix) with ESMTP id E649A1000F45 for ; Mon, 5 Jul 2021 11:12:42 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id l2so3836277edt.1 for ; Mon, 05 Jul 2021 04:12:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CaX0flpcWSf1BxIX9YKTaXTNjn37cg6419yg5j4auho=; b=jEnaley92nsYz6JbSlRThV2E1YRPY06sNCdtkau2fgB2TykXtcwbJCOtCezAV/vc8w 4hDhe7kUwItFuUTLiiagNALF9ddj3LvI9kkEuJ9R92C/whZQ3vkZkwX1vCXIm8Ku1qzp z78re286Qlfn/qoPoSuG6qaVge0tBY4ZHgiys64KOnqifOQt6boJwkcYJgyBEhRGQYp4 7o+/a95mXCP6Lwx41+T6LEZqahRtOluMr+qhtfwZLUiiBnUsCxsvQ/qj4BW0MsdnTych 3Nm/eSxg8yMU1KdU9GSuJma36mm9SRV7maxOFBYk2RMuFpGkaJzQSv4aIRUBJXK2jp6M 8c/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CaX0flpcWSf1BxIX9YKTaXTNjn37cg6419yg5j4auho=; b=S3QQQEe0QIo5KGz+Ari4msm7RaFDCeefeq1fgYXRwCsd9mlc43lcICOrophT80MVGl Sk9Q970athH0sFeZyqMmSDZwSMZlIQR7iYJmmwg6HnTGfALwzJFoJvAkb37uw3kv1WE4 AEQ3RoDb1NBvBL4m/qqY48KRG+vCjAzczNWUHWLOdZuID4m35RPymqKriaUIGxi/aFAx BkviQPJIPxiI7Pvho9bWtma65XiFmwL53h2DuKE/u8iLJO9r3xYnwAOjO35fXy/uc5WW UHbMil0Anc8gLSzNXsAWEG+oYNDeQiORZA1+kr/hzbtlMRDlXXPtRBnsDjDcuF5Jy+Ky HvLQ== X-Gm-Message-State: AOAM531TmpzJgGm/T3oPD+d/H3qS80z66IQVtUogkA7uoKAuzwKgepra rp5a0ktCls73Ua/r+OKn4aPcb4RViZ2lz0O5xvI= X-Google-Smtp-Source: ABdhPJy1aBflyEaVGfXBsnIY/o25eWlDAwK3mLAMTUP6Iud2PfckMEFvKMrhc6r3H3jzgXvU/DLBkOCb9vEH/JghMVM= X-Received: by 2002:a05:6402:5c9:: with SMTP id n9mr3075816edx.30.1625483561668; Mon, 05 Jul 2021 04:12:41 -0700 (PDT) MIME-Version: 1.0 References: <20210705103229.8505-1-yee.lee@mediatek.com> <20210705103229.8505-3-yee.lee@mediatek.com> In-Reply-To: <20210705103229.8505-3-yee.lee@mediatek.com> From: Andrey Konovalov Date: Mon, 5 Jul 2021 13:12:30 +0200 Message-ID: Subject: Re: [PATCH v6 2/2] kasan: Add memzero int for unaligned size at DEBUG To: yee.lee@mediatek.com Cc: LKML , nicholas.Tang@mediatek.com, Kuan-Ying Lee , chinwen.chang@mediatek.com, Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Andrew Morton , Matthias Brugger , "open list:KASAN" , "open list:MEMORY MANAGEMENT" , "moderated list:ARM/Mediatek SoC support" , "moderated list:ARM/Mediatek SoC support" Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20161025 header.b=jEnaley9; spf=pass (imf13.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E649A1000F45 X-Stat-Signature: 8q5knriy3bw73mhy7z75qhwn9aca3ujo X-HE-Tag: 1625483562-596251 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 5, 2021 at 12:33 PM wrote: > > From: Yee Lee > > Issue: when SLUB debug is on, hwtag kasan_unpoison() would overwrite > the redzone of object with unaligned size. > > An additional memzero_explicit() path is added to replacing init by > hwtag instruction for those unaligned size at SLUB debug mode. > > The penalty is acceptable since they are only enabled in debug mode, > not production builds. A block of comment is added for explanation. > > Cc: Andrey Ryabinin > Cc: Alexander Potapenko > Cc: Dmitry Vyukov > Cc: Andrew Morton > Suggested-by: Marco Elver > Suggested-by: Andrey Konovalov > Signed-off-by: Yee Lee > --- > mm/kasan/kasan.h | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h > index 98e3059bfea4..d739cdd1621a 100644 > --- a/mm/kasan/kasan.h > +++ b/mm/kasan/kasan.h > @@ -9,6 +9,7 @@ > #ifdef CONFIG_KASAN_HW_TAGS > > #include > +#include "../slab.h" > > DECLARE_STATIC_KEY_FALSE(kasan_flag_stacktrace); > extern bool kasan_flag_async __ro_after_init; > @@ -387,6 +388,17 @@ static inline void kasan_unpoison(const void *addr, size_t size, bool init) > > if (WARN_ON((unsigned long)addr & KASAN_GRANULE_MASK)) > return; > + /* > + * Explicitly initialize the memory with the precise object size to > + * avoid overwriting the SLAB redzone. This disables initialization in > + * the arch code and may thus lead to performance penalty. The penalty > + * is accepted since SLAB redzones aren't enabled in production builds. > + */ > + if (__slub_debug_enabled() && What happened to slub_debug_enabled_unlikely()? Was it renamed? Why? I didn't receive patch #1 of v6 (nor of v5). > + init && ((unsigned long)size & KASAN_GRANULE_MASK)) { > + init = false; > + memzero_explicit((void *)addr, size); > + } > size = round_up(size, KASAN_GRANULE_SIZE); > > hw_set_mem_tag_range((void *)addr, size, tag, init); > -- > 2.18.0 >