From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAAEBC636CC for ; Tue, 31 Jan 2023 19:01:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74A6B6B0075; Tue, 31 Jan 2023 14:01:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6F9C26B0078; Tue, 31 Jan 2023 14:01:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59B2E6B007B; Tue, 31 Jan 2023 14:01:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 4CDE16B0075 for ; Tue, 31 Jan 2023 14:01:31 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E75E8140C2D for ; Tue, 31 Jan 2023 19:01:30 +0000 (UTC) X-FDA: 80416012740.13.385D6B6 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf29.hostedemail.com (Postfix) with ESMTP id 0F955120031 for ; Tue, 31 Jan 2023 19:01:28 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XvW89yFH; spf=pass (imf29.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675191689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ee8VrbotWmdr9Bi0GM3TMNLFcbwdi2SIi4lojz2pU58=; b=8D+mOXzkC9pbdFTZXRzzkMumj4K2EPLFL2G9eEAQJR10it7Nvxr1ULJ545Zor2Xnel5ZzB NBliIf7zCJzyGtVt8rdNSC2A7wNNpoVW6TLfkzNkHq2lJBwWFy2d5zU5bqBKzTrqRcqcnt qnMB35eTxFNw3URhWRkl3accuOKmMUE= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=XvW89yFH; spf=pass (imf29.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675191689; a=rsa-sha256; cv=none; b=GiydnWOxvgPzOuw85UpCr2utBOTKp6gsaWBYM86515G5CwvUWv/G7D296hsTYeIF14oJw7 TbazuhKx4LoGapAjoFGoX747rh1BmCM3YmU+vp9DKbVbEaQq3fqdoTkJFOsaW1cTXEM5Yi EwcRw+LhanY2N+lj0Gbe2DXP3FSondw= Received: by mail-pj1-f47.google.com with SMTP id e10-20020a17090a630a00b0022bedd66e6dso20115378pjj.1 for ; Tue, 31 Jan 2023 11:01:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ee8VrbotWmdr9Bi0GM3TMNLFcbwdi2SIi4lojz2pU58=; b=XvW89yFHLvEH5FtjCjRzR1OcJ9e6Q58euegSx2t/bvrMiQ5qefxzakEVcB/6eZBa9L aB0SonjcniQJivx3I+EUo9hrv2nvPpkD998u35GBnao5S0MJNobwq/9gCgLctoVY7pxg 3iQFaU3hKm9nvR22Zi/bfyCtcuCISGSCboUIshOy8BEvkAmPsznDfT7TeamE0exui72G 75PgLUdYiT0OSJne1pbDFsnekXMhCVyNJBks6dMjfyf9AWLGr1F4oMbIIbWQczDioaDl vw1zrXclFSM1gAquI9b4DkESWnFEoT4iItwB6Fgz/Y/wV7j3MjDSs25KdI/gXkZV4RM+ GCdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ee8VrbotWmdr9Bi0GM3TMNLFcbwdi2SIi4lojz2pU58=; b=ACDnbJGt7rmb10FRgcbXBD0wx/tNf62rLXw89fTccdjqw54t6C63FK34pyigPF61nl 6h6MeDv1U2SVWkmcyU0jpn0koFMHYKIu2xKtGim84daK9xPo1JcpwKF7klneka4ZOez5 CMekzguprNULgtJ4v5Sl44wNzQl3ayKlV1bt6npDsRWm2/o7GMKE9Gq+USEOLYS66XT0 9eMZbD/Cr7k64pO6dpmFcuJCqe4r/gzInzaRzCji/CuQXkGjn6zqzBa+RO2JtBCWKXff HAJ3JM9vVUZXm7lg8P90do/nELeeVI1omNgpof+e10jel3XsMBWIY1UaIeRP7h32+bh3 rDcA== X-Gm-Message-State: AO0yUKXAhij8dyY8g5VXPkO34BaGDUv1uBCKUHU6/RROJknFI0CTCF2+ UDlqD+NJm7eS03o/0xapUqdrs2Lg6mbY6DOrbxw= X-Google-Smtp-Source: AK7set+yUD4D01GYukAfSV3dRkXZgkK9SbG2nkRlsQJ0msHz2SU+hB69wi+HMHIV6g6rIgPYOsJAPCBLTQlxMWGR0UU= X-Received: by 2002:a17:90a:cc5:b0:22c:4462:fb92 with SMTP id 5-20020a17090a0cc500b0022c4462fb92mr3208121pjt.44.1675191687937; Tue, 31 Jan 2023 11:01:27 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Tue, 31 Jan 2023 20:01:17 +0100 Message-ID: Subject: Re: [PATCH 06/18] lib/stackdepot: annotate init and early init functions To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: rb9g955n1mrhyd3busq5w4e7pgrdyf7a X-Rspam-User: X-Rspamd-Queue-Id: 0F955120031 X-Rspamd-Server: rspam06 X-HE-Tag: 1675191688-891148 X-HE-Meta: U2FsdGVkX18fZgUNq/Yj0QRkz3Lz2Lv32Q666vWPgoLXpaiobU6R2wcWV4RDVlXCkEe+Lba7uBwEOCtyvkyWfM6oF74Ur9VTBMtwb9A7djBcGwyHtB8NUjH9cHxEjenQ5Qge1sSg6bYz72QGVXCacfpfZQT2ETgcp7WOC/M2JbLcUrWNfE1TyrThzyYuiP3EcRyMSMWJntve5HcJyv9KOoLW/gkrTYj/n8h05cIGrOdQqtj4Zt5+ovnUjhJElLkIuz9YqX0pv5hYywHddl9IYv3Y4awWMd+CSYsCepo23+7GHrjiz0E5H+saz+Gmy2d7DJKvsaGuxwZ2Mh3+ywfKIujZ1PmZhdTosDa9tl6F/JVNWVgnYja85sk9CjcDOXk4Swo+DO6IK1HTXpuhuEQo2G3t2aFtICNvtFv2w8ZACXHAIToPt0r/JN/pUXW3GRosdbx7701tACi/n1aqvRqsDObjUg+lDt3zK1/3BVkAkETSB1VTUE51cUVNXGuLaQOIj1pKwkxpCWYP98C6gQLl6cPsnSx74eP+w4pUlVfxfccElDQ3t0lL+0O0iHpYQlhFNtHavNLow8/nfrtGGHNO4WRKy8AnnMa76zlXftY91HZ4w84yMQAsae7xsxGijVDIDWz4g1rQTf2a3zPgsLVlRsNSeQTlEgGE30IXPW4LqfvFFDeW8VDLncwtV6Ds2irO+9+SSPqWcNfhebfCMeVMPzAxeCllrPOsNiJcTFcEJSPB+1lCauRIJXStGJ+SF8ifnJ2IcLJsKZoM/vTpt/vY+SwhMLCLdAaBfDwH1a34tw7nCdrSy4bNU5k/v1NFeet86SeoFDmCBuPhogNz4t+nLAgSIXwnfCaHxTlP9PUQgKe03jkRsnfJQ/68Oe4AQ+z/TzE9c1FUJ2QWeWbrTHCyF99mlmhPpvvkdpKQ8q6I6VaICldGjykevMZct0DA6hdsRPxSsE8j8mw+Alr5YYl tpl2Rk5U JfOHEG2kf/zlxLCVEReKMuqNCI+2GE3oymnvL+RNB5rjThn+hGoBIfLLyesPYzvGlJz0E8Dq5JBY3Fj/zo4/crrI1dSBox5WDlAQJOogovwHDfCRVaBjco2ZEbYDq9kPvWXVLSVf5pvP8MQtFIEhpaGVE+Af0MNcLV5j0NxVL0wuFTpomXBwOXVjYe+ZGshdWq9+s8lfFWJXcY6EKro8vB63DvyDRp756MHreICbK3r0Uvt6yRB8vUbwFKQ3KHDs67/ewfMICukrFDPNc/nPyeRJkds+/iRIscc1gHmBUOkhS27LOF+/pj9IDH1YpJceavR88VRJ9pGnmV7pcCMX6Soks+cvuDBjf3JBf3xWCm+UzqOUxBrOtFqJrAmXs2xyt6apwvnFsoMFEaohdw6F4kLZ4RuQm1uaNz5Cv/Z/IoPexcDs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 11:31 AM Alexander Potapenko wrote: > > On Mon, Jan 30, 2023 at 9:50 PM wrote: > > > > From: Andrey Konovalov > > > > Add comments to stack_depot_early_init and stack_depot_init to explain > > certain parts of their implementation. > > > > Also add a pr_info message to stack_depot_early_init similar to the one > > in stack_depot_init. > > > > Also move the scale variable in stack_depot_init to the scope where it > > is being used. > > > > Signed-off-by: Andrey Konovalov > Reviewed-by: Alexander Potapenko > ... > > > > +/* Allocates a hash table via kvmalloc. Can be used after boot. */ > Nit: kvcalloc? (Doesn't really matter much) Ah, right, forgot to fix this. I initially wanted to point out that early init allocates in memblock and late init in slab or vmalloc but then decided it's an unnecessary level of details. Will fix in v2. Thanks!