From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0EC3C6FD18 for ; Thu, 30 Mar 2023 02:56:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D3B4B6B0072; Wed, 29 Mar 2023 22:56:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CEB136B0074; Wed, 29 Mar 2023 22:56:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB51C6B0075; Wed, 29 Mar 2023 22:56:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id AB2336B0072 for ; Wed, 29 Mar 2023 22:56:11 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 81A7240502 for ; Thu, 30 Mar 2023 02:56:11 +0000 (UTC) X-FDA: 80624050542.22.4F7ACB2 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by imf29.hostedemail.com (Postfix) with ESMTP id ACA4A120010 for ; Thu, 30 Mar 2023 02:56:09 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Zec5lJk4; spf=pass (imf29.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680144969; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zcIEVyxOQ9ThEvdTZ3QimlrlYxsMccblwZq0nJEQf8Q=; b=bpTdn0XbkePk0/hpQ5gctNfZbmoclXkGi/ctEzKIHzmakCEcGQYh24h+5EmZwk2RETqGso q1679ktbc5bKQYTSVpRiTDkWtjawFQq4s9ZteqKJXs2TiB6kYEDhY5PDBv4M/uN4jwuLsG /qqn82o1nn7RJVzZtzHrs5S2EwVtJlk= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=Zec5lJk4; spf=pass (imf29.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.47 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680144969; a=rsa-sha256; cv=none; b=AygO9+DkDMWS/zf4az0iBKkYHc9M+FDz/6bvUbf6Sb2Rgg/hxcH85oxGCz/5XM1/MXGVui r3XRxp92PwnJJLEpmEFMszqcgfGRFyG1nQVMjM17kim1wILGdHaZRtRsYW4XALwjceqsRf gue6lftYmbmJ9m9mMXKVs/KMe7AQnow= Received: by mail-pj1-f47.google.com with SMTP id r7-20020a17090b050700b002404be7920aso16582727pjz.5 for ; Wed, 29 Mar 2023 19:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680144968; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zcIEVyxOQ9ThEvdTZ3QimlrlYxsMccblwZq0nJEQf8Q=; b=Zec5lJk4rXTCbA+qbB6XLLMkQsH0baL9XmFKOIVsa6DGOJodAy/QjlUIPA+YuJnisG BLviy5bd66/mXjAw691bc1vI4BTemWYukYKjCZ1+jPr0XjLytUY1NT/zNqXehvPbHQ60 u//4jHceldp9UErdH8WTE+kZplg5WaFpToTSV3UlAnqAe5F6GUY6hMTMdwhuQqDTtOD2 u3vm2zcCg1Kk0SMP5H8FbNCOoU5dUs/LXyL76kqX2uLO96d7wuz5Ri66atDLcCfotByZ DA0qxNlVVaf2BFurz3bXwPR7biZ4WJlZrmKAdrpggFJhgH5bTzqvysSpK1iQKoTWivaM qsbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680144968; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zcIEVyxOQ9ThEvdTZ3QimlrlYxsMccblwZq0nJEQf8Q=; b=UYRo0r36YgH0Jc5mi/vy4aWW6Z2ig9r5I15+ekJ42WbEtXoELcxbJ0vEfRhbq5XX5M HQTHHa46epeV5k4vSCG//t6NBgPrFwhWnqUDd7xXN5F4fApmu0gjaHKZCuOVHbSksMCq mYaHPFfyEM+5iXZChow0+O0oYe5668h3ViqNUep6oUpIZM9FoSnrqQePVj1NSxvgDK+G F+lfVnw/8GwS0shiXpnhKc5D8PYndr+T2JRV9zus67oyRPJeJeXNEjRBQQvci6yMWdfn cv8UF7qo+GjOeLhdtq1x0JgLFSbyfx5yNQhKVrCXGeQ2YyMaCpxMkzA8aes+xkMncub2 z3Jw== X-Gm-Message-State: AAQBX9frRg+4m4EfspOmKkwXe4fi50BeXowcuu/V8RRB071qp9amkJCE 6j5UKpYlr8nPGwkgCcDDPLAB5jsob+LgeSVJn4Y= X-Google-Smtp-Source: AKy350aaSitWK+oMnPBGI/HdGFv4oj337IShewGHsQKImjbS99hwBRaF/179UbwYduEu4LT8WrbvDdBJHlGFglrepNY= X-Received: by 2002:a17:902:ecc2:b0:1a0:7630:8ef1 with SMTP id a2-20020a170902ecc200b001a076308ef1mr8673024plh.11.1680144968218; Wed, 29 Mar 2023 19:56:08 -0700 (PDT) MIME-Version: 1.0 References: <20230328111714.2056-1-zhangqing@loongson.cn> In-Reply-To: From: Andrey Konovalov Date: Thu, 30 Mar 2023 04:55:57 +0200 Message-ID: Subject: Re: [PATCH] LoongArch: Add kernel address sanitizer support To: Qing Zhang Cc: Jonathan Corbet , Huacai Chen , Andrew Morton , Alexander Potapenko , Dmitry Vyukov , Vincenzo Frascino , WANG Xuerui , Jiaxun Yang , kasan-dev@googlegroups.com, linux-doc@vger.kernel.org, linux-mm@kvack.org, loongarch@lists.linux.dev, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, Andrey Ryabinin Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: ACA4A120010 X-Stat-Signature: 5z8h8u6kgzcyy39hsp669potx4f4judy X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1680144969-463144 X-HE-Meta: U2FsdGVkX1+0oZJgwTppQv/wBLiC4A8ctB0k7oSmbqm/yxmMVZ9l0FnM7UHOxBWG4kOg9ry3uBzoOUuWW3WxVSyzVN1SK/DBcQ7EODs527DT3vrvZyEniNRa9po2h7DDOwCphnYiLKD4BqTCVB8p+yftiHmqa0CyxR2N185e+5350L2Kh72jk43BbXkseAn0qCoNcEUoPQ1Dc3VUR2IrJnzUUZkYaikzLe6TdFhBwchOqZ/FqpWYAvjoLGlttNviHhYK7ggEUuiroSjN9vnYwyQf7f26Z2B0pq+OlmZdQfcLpt9SYGffewk9ne/gEXtMAiVnkWjQc1oUCyrBdg0VXs1iff5KVYamqKhAQrLIvJr9uk4zqa3A01odokHfxXZhA8aKhIwlex3nIwgarU/qEVHCVD89nnJTzFYSXI2S9vQ11kvt+FuMSjOWObmZ1IAucngTVrOScrEs3A8w2mbCKkjq710yP3AyO+gpCcxV6trWdxtdQZdvGcq25Kd2/l3+tRRVWOE3xuC0BdJ9E/mZ5M5SDeFPGV+ko5ui1HR4wlE7V3aokxSzDmPE8gel+Ccxe7bqa6/eNReqRlxw3mgu3AoU86s+k9pV5d03W3RSo56o9tlszlaHNhFoC85ZmMGiu1tgvcRxASvH7CsavFlAaDhGF+jmPi0YSlbrFQ9WVWAO+5zAqC0BQ3oGdym5q+Jea/xgC1GszFDdOlkhPk0+UMeEo2GfgXv3Y/I/Zla+3ZXKBNIGjmfhm+ACAQc/oe6XuNdF3+nmVtR57lu1VzzOpXQbXdSNKh92zoGFZ4j4eG50XqA0G3S5RhX15os/rkzOR1vj/Yk6yL58TJB2FCRg42Yjrkr4i3tzQXWb4pU+0lxloU8iKkmweLZVeAWQ4mtIxaWBVXVRQCgTlZ1xB4zGUDPZ8C6GM8t9/cG7gLcHUinUxOuhoIPQdtefLsMLHAdm2I201mw9ee4knmaEDW7 fYfoIs+9 dV1fVS+2Bj7hWKq/YE06YfgsMRDh8k4j1vdsPqT+k8vTHFbf/Z711BQ4IuOBx7HHENyuKrq65TuaBGYpmVPmltTLN766LcWdEFwzqKLthwUk7vZWHmHRiVQ4kohjXQIpCN7qHtqK+C7ZctgzLJU1a8cYkvZn9dg/jPUIQgNCELgS/f24MNqpjgYbzIP8FP/5X7Jcd0Ay9tBO/knvy6FTjOZ0wbKe9gbBDOYmGSAoIXDfjlxiDHBki20thumD5Ba1AbFvdxk56wjb+vuPlVfNoqywbkiosLhsYA4f67QxeCa5BTccUwl9jGJIOwn0ixIJTApjvAd40c9DuxdVCQSy3mG9NHhIBNJBXiRVDlCckrgpa9l94/3bEt8I/C5peE3OO4GaqOV5uehg9Il228ML4IcZclmsvrkXdsY0Zmf2Bxq6UIV89xFt4BY3Uaw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Mar 30, 2023 at 4:06=E2=80=AFAM Qing Zhang = wrote: > > > But I don't think you need this check here at all: addr_has_metadata > > already checks that shadow exists. > > > On LongArch, there's a lot of holes between different segments, so kasan > shadow area is some different type of memory that we concatenate, we > can't use if (unlikely((void *)addr < > kasan_shadow_to_mem((void *)KASAN_SHADOW_START))) to determine the > validity, and in arch/loongarch/include/asm/kasan.h I construct invalid > NULL. I get that, but you already added a special case for __HAVE_ARCH_SHADOW_MAP to addr_has_metadata, so you can just call it? > This is because in pagetable_init on loongarch/mips, we populate pmd/pud > with invalid_pmd_table/invalid_pud_table, I see. Please add this into the patch description for v2. > So pmd_init/pud_init(p) is required, perhaps we define them as __weak in > mm/kasan/init.c, like mm/sparse-vmemmap.c. Yes, this makes sense to do, so that KASAN doesn't depend on definitions from sparse-vmemmap.c. Thank you!