linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Konovalov <andreyknvl@gmail.com>
To: Sabyrzhan Tasbolatov <snovitoll@gmail.com>
Cc: akpm@linux-foundation.org, ryabinin.a.a@gmail.com,
	glider@google.com,  dvyukov@google.com,
	vincenzo.frascino@arm.com, linux-kernel@vger.kernel.org,
	 kasan-dev@googlegroups.com, linux-mm@kvack.org
Subject: Re: [PATCH] kasan: migrate copy_user_test to kunit
Date: Sun, 13 Oct 2024 00:49:23 +0200	[thread overview]
Message-ID: <CA+fCnZdasETx78HOLViEQHDZV1JS7ibzTbmfPzCb--3uN+tLiQ@mail.gmail.com> (raw)
In-Reply-To: <CACzwLxj21h7nCcS2-KA_q7ybe+5pxH0uCDwu64q_9pPsydneWQ@mail.gmail.com>

On Fri, Oct 11, 2024 at 11:12 AM Sabyrzhan Tasbolatov
<snovitoll@gmail.com> wrote:
>
> This has been tested on:
> - x86_64 with CONFIG_KASAN_GENERIC
> - arm64 with CONFIG_KASAN_SW_TAGS
> - arm64 with CONFIG_KASAN_HW_TAGS
>
> - arm64 SW_TAGS has 1 failing test which is in the mainline,
> will try to address it in different patch, not related to changes in this PR:
> [    9.480716]     # vmalloc_percpu: EXPECTATION FAILED at
> mm/kasan/kasan_test_c.c:1830
> [    9.480716]     Expected (u8)(__u8)((u64)(c_ptr) >> 56) < (u8)0xFF, but
> [    9.480716]         (u8)(__u8)((u64)(c_ptr) >> 56) == 255 (0xff)
> [    9.480716]         (u8)0xFF == 255 (0xff)
> [    9.481936]     # vmalloc_percpu: EXPECTATION FAILED at
> mm/kasan/kasan_test_c.c:1830
> [    9.481936]     Expected (u8)(__u8)((u64)(c_ptr) >> 56) < (u8)0xFF, but
> [    9.481936]         (u8)(__u8)((u64)(c_ptr) >> 56) == 255 (0xff)
> [    9.481936]         (u8)0xFF == 255 (0xff)

Could you share the kernel config that you use to get this failure?
This test works for me with my config...

> Here is my full console log of arm64-sw.log:
> https://gist.githubusercontent.com/novitoll/7ab93edca1f7d71925735075e84fc2ec/raw/6ef05758bcc396cd2f5796a5bcb5e41a091224cf/arm64-sw.log
>
> - arm64 HW_TAGS has 1 failing test related to new changes
> and AFAIU, it's known issue related to HW_TAGS:
>
> [ 11.167324] # copy_user_test_oob: EXPECTATION FAILED at
> mm/kasan/kasan_test_c.c:1992
> [ 11.167324] KASAN failure expected in "unused =
> strncpy_from_user(kmem, usermem, size + 1)", but none occurred
>
> Here is the console log of arm64-hw.log:
> https://gist.github.com/novitoll/7ab93edca1f7d71925735075e84fc2ec#file-arm64-hw-log-L11208

I don't remember seeing this issue before, did you manage to figure
out why this happens?

Thank you for working on this!


  reply	other threads:[~2024-10-12 22:49 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-11  7:16 Sabyrzhan Tasbolatov
2024-10-11  9:13 ` Sabyrzhan Tasbolatov
2024-10-12 22:49   ` Andrey Konovalov [this message]
2024-10-13  6:33     ` Sabyrzhan Tasbolatov
2024-10-12 22:46 ` Andrey Konovalov
2024-10-13 13:02   ` [PATCH v2 0/3] kasan: migrate the last module test " Sabyrzhan Tasbolatov
2024-10-13 13:02     ` [PATCH v2 1/3] kasan: move checks to do_strncpy_from_user Sabyrzhan Tasbolatov
2024-10-13 16:04       ` Andrey Konovalov
2024-10-13 13:02     ` [PATCH v2 2/3] kasan: migrate copy_user_test to kunit Sabyrzhan Tasbolatov
2024-10-13 16:02       ` Andrey Konovalov
2024-10-13 18:20         ` [PATCH v3 " Sabyrzhan Tasbolatov
2024-10-13 20:25           ` Andrey Konovalov
2024-10-14  2:56             ` [PATCH RESEND v3 0/3] kasan: migrate the last module test " Sabyrzhan Tasbolatov
2024-10-14  2:56               ` [PATCH RESEND v3 1/3] kasan: move checks to do_strncpy_from_user Sabyrzhan Tasbolatov
2024-10-14  2:57               ` [PATCH RESEND v3 2/3] kasan: migrate copy_user_test to kunit Sabyrzhan Tasbolatov
2024-10-14 23:10                 ` Andrew Morton
2024-10-15  1:18                   ` Andrey Konovalov
2024-10-15 10:53                     ` Sabyrzhan Tasbolatov
2024-10-15 23:16                       ` Andrey Konovalov
2024-10-16 13:17                         ` [PATCH v4 0/3] kasan: migrate the last module test " Sabyrzhan Tasbolatov
2024-10-16 13:18                           ` [PATCH v4 1/3] kasan: move checks to do_strncpy_from_user Sabyrzhan Tasbolatov
2024-10-16 13:18                           ` [PATCH v4 2/3] kasan: migrate copy_user_test to kunit Sabyrzhan Tasbolatov
2024-10-16 13:18                           ` [PATCH v4 3/3] kasan: delete CONFIG_KASAN_MODULE_TEST Sabyrzhan Tasbolatov
2024-10-14  2:57               ` [PATCH RESEND v3 " Sabyrzhan Tasbolatov
2024-10-13 13:02     ` [PATCH v2 " Sabyrzhan Tasbolatov
2024-10-13 16:03       ` Andrey Konovalov
2024-10-13 18:21         ` [PATCH v3 " Sabyrzhan Tasbolatov
2024-10-13 20:25           ` Andrey Konovalov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+fCnZdasETx78HOLViEQHDZV1JS7ibzTbmfPzCb--3uN+tLiQ@mail.gmail.com \
    --to=andreyknvl@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ryabinin.a.a@gmail.com \
    --cc=snovitoll@gmail.com \
    --cc=vincenzo.frascino@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox