linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Konovalov <andreyknvl@gmail.com>
To: Peter Collingbourne <pcc@google.com>
Cc: Marco Elver <elver@google.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	 Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: [PATCH] kasan: update function name in comments
Date: Tue, 22 Feb 2022 17:38:18 +0100	[thread overview]
Message-ID: <CA+fCnZdST16jVZ8rdHQR5BhcoxosjebPY-uONY0upPGSEQjxzg@mail.gmail.com> (raw)
In-Reply-To: <20220219012433.890941-1-pcc@google.com>

On Sat, Feb 19, 2022 at 2:24 AM Peter Collingbourne <pcc@google.com> wrote:
>
> The function kasan_global_oob was renamed to kasan_global_oob_right,
> but the comments referring to it were not updated. Do so.
>
> Link: https://linux-review.googlesource.com/id/I20faa90126937bbee77d9d44709556c3dd4b40be
> Signed-off-by: Peter Collingbourne <pcc@google.com>
> Fixes: e5f4728767d2 ("kasan: test: add globals left-out-of-bounds test")
> ---
>  lib/test_kasan.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/lib/test_kasan.c b/lib/test_kasan.c
> index 26a5c9007653..a8dfda9b9630 100644
> --- a/lib/test_kasan.c
> +++ b/lib/test_kasan.c
> @@ -780,7 +780,7 @@ static void ksize_uaf(struct kunit *test)
>  static void kasan_stack_oob(struct kunit *test)
>  {
>         char stack_array[10];
> -       /* See comment in kasan_global_oob. */
> +       /* See comment in kasan_global_oob_right. */
>         char *volatile array = stack_array;
>         char *p = &array[ARRAY_SIZE(stack_array) + OOB_TAG_OFF];
>
> @@ -793,7 +793,7 @@ static void kasan_alloca_oob_left(struct kunit *test)
>  {
>         volatile int i = 10;
>         char alloca_array[i];
> -       /* See comment in kasan_global_oob. */
> +       /* See comment in kasan_global_oob_right. */
>         char *volatile array = alloca_array;
>         char *p = array - 1;
>
> @@ -808,7 +808,7 @@ static void kasan_alloca_oob_right(struct kunit *test)
>  {
>         volatile int i = 10;
>         char alloca_array[i];
> -       /* See comment in kasan_global_oob. */
> +       /* See comment in kasan_global_oob_right. */
>         char *volatile array = alloca_array;
>         char *p = array + i;
>
> --
> 2.35.1.473.g83b2b277ed-goog
>

Reviewed-by: Andrey Konovalov <andreyknvl@gmail.com>


      parent reply	other threads:[~2022-02-22 16:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-19  1:24 Peter Collingbourne
2022-02-19  2:00 ` Miaohe Lin
2022-02-21 11:15   ` Marco Elver
2022-02-23 22:30     ` Peter Collingbourne
2022-02-23 23:35       ` Marco Elver
2022-02-24  4:07         ` Andrew Morton
2022-02-22 16:38 ` Andrey Konovalov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CA+fCnZdST16jVZ8rdHQR5BhcoxosjebPY-uONY0upPGSEQjxzg@mail.gmail.com \
    --to=andreyknvl@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=elver@google.com \
    --cc=linux-mm@kvack.org \
    --cc=pcc@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox