From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7E0DC433DB for ; Wed, 24 Feb 2021 15:36:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5269C64F04 for ; Wed, 24 Feb 2021 15:36:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5269C64F04 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A612A6B0005; Wed, 24 Feb 2021 10:36:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9E9C96B0006; Wed, 24 Feb 2021 10:36:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8DA076B006C; Wed, 24 Feb 2021 10:36:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0164.hostedemail.com [216.40.44.164]) by kanga.kvack.org (Postfix) with ESMTP id 74BB66B0005 for ; Wed, 24 Feb 2021 10:36:54 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 389474DC7 for ; Wed, 24 Feb 2021 15:36:54 +0000 (UTC) X-FDA: 77853564348.08.27BFEC4 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf12.hostedemail.com (Postfix) with ESMTP id 038F8132 for ; Wed, 24 Feb 2021 15:36:47 +0000 (UTC) Received: by mail-ed1-f51.google.com with SMTP id j9so3086521edp.1 for ; Wed, 24 Feb 2021 07:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ji4BzJAQTuKp7DKTd2/l/jJe85G+oyb88MSqcOQIPcA=; b=nhJ2TEc9D954m2fmyp5t8t7hJTdxfopcBqtHu9wVsn5KLseijAl9KUPnpG7ywhzlTf fkr3SJqtGld4KfbBPtR6j5y/QNVK86Y3shePJVsksHlmISu3GKmyqfhPNMTrAGP/9a39 vB0Y2AOegdmTaBbqQlX1U1pfff3bLA7a/7D3sW4xzWO5XHDpJr10lEjYeZ+HlNYkF2QC tG/S3KajEB1wgoan1EdBGf04KkkGOP+Z56FiRauMXPmRobp/OusHvxMICffzZ/72G8ns HgdLkUJ529S1AAwkudZDrI0RVWpKo9XrTopc0hbWcEronl6tqkds0ii74/HZyC9IpYBT Y/GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ji4BzJAQTuKp7DKTd2/l/jJe85G+oyb88MSqcOQIPcA=; b=i+bvslLRVrrT0iB8ztAbuugFPQhzfCEcRolPGllruEqVrR8tMa+DjFhw1ppDwD4XDV AuV+XSuaWaIPH8raYmIwqnwCNmKFOCmLtzooGy8R0ULLxMJjutiS5nvKGAmIp4QItkum hY+RB5CBY/Xtt3yAwCcKZQnycxzwv+NnqQbjzCy7nsXgc8Hd2lV0p7cVRLx6zlh229pZ sp73u2mNcZPE6OTs6t3i6p77h2pmuP3hgsiR6v8+xV/2qfK1AUE8yoFLfdgibnCZRxfO 0HDYsSOYzPfMj6yo2o1McWEg5HzvKZYSf4UyunI4gvyhp0FiX4t80Uhv6dBV8j7gcuxp Bbig== X-Gm-Message-State: AOAM532J6d+WKK2cmgH3jC08oZmL0tjaJ0yBaFBJ4qYfCJPVcb+QFkkJ cOlrGedQVxwcmAXwwGLvDSqyoC8K8qS07d3VwY8= X-Google-Smtp-Source: ABdhPJypVFQDXuXdKTrlFsegIYz2rvz2bQ+ux+ytJLboHYJ5K5LYIJdTg0KTOkN/Uqpr5HMy4a8QBQ6NeGXKFqYoRHM= X-Received: by 2002:a05:6402:348c:: with SMTP id v12mr11144995edc.314.1614181012339; Wed, 24 Feb 2021 07:36:52 -0800 (PST) MIME-Version: 1.0 References: <1613970647-23272-1-git-send-email-daizhiyuan@phytium.com.cn> In-Reply-To: From: Andrey Konovalov Date: Wed, 24 Feb 2021 16:36:41 +0100 Message-ID: Subject: Re: [PATCH] mm/kasan: switch from strlcpy to strscpy To: Zhiyuan Dai Cc: Andrey Ryabinin , Dmitriy Vyukov , Andrew Morton , Linux Memory Management List , LKML , Alexander Potapenko Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 038F8132 X-Stat-Signature: gh7j1ufynointanz4p7zd9pyrzdkq4qm Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf12; identity=mailfrom; envelope-from=""; helo=mail-ed1-f51.google.com; client-ip=209.85.208.51 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614181007-427746 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Feb 22, 2021 at 8:45 AM Alexander Potapenko wrote: > > On Mon, Feb 22, 2021 at 6:10 AM Zhiyuan Dai wrote: > > > > strlcpy is marked as deprecated in Documentation/process/deprecated.rst, > > and there is no functional difference when the caller expects truncation > > (when not checking the return value). strscpy is relatively better as it > > also avoids scanning the whole source string. > > Looks like a good thing to do. > > > Signed-off-by: Zhiyuan Dai > Acked-by: Alexander Potapenko > > > --- > > mm/kasan/report_generic.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/mm/kasan/report_generic.c b/mm/kasan/report_generic.c > > index 8a9c889..fc7f7ad 100644 > > --- a/mm/kasan/report_generic.c > > +++ b/mm/kasan/report_generic.c > > @@ -148,7 +148,7 @@ static bool __must_check tokenize_frame_descr(const char **frame_descr, > > } > > > > /* Copy token (+ 1 byte for '\0'). */ > > - strlcpy(token, *frame_descr, tok_len + 1); > > + strscpy(token, *frame_descr, tok_len + 1); > > } > > > > /* Advance frame_descr past separator. */ > > -- > > 1.8.3.1 > > Reviewed-by: Andrey Konovalov Thanks!