From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA8A9EED619 for ; Fri, 15 Sep 2023 16:46:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26D4B8D0009; Fri, 15 Sep 2023 12:46:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 21D5E8D0005; Fri, 15 Sep 2023 12:46:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E6218D0009; Fri, 15 Sep 2023 12:46:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EE6A38D0005 for ; Fri, 15 Sep 2023 12:46:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B97FCC0B70 for ; Fri, 15 Sep 2023 16:46:40 +0000 (UTC) X-FDA: 81239410560.20.F949963 Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf11.hostedemail.com (Postfix) with ESMTP id 048F34001E for ; Fri, 15 Sep 2023 16:46:38 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UZMRUwS6; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694796399; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YSRPmYTgQYAS8/W7DnTR2CfDhO5J0xkkJUsesS4GK9E=; b=FglAZ4pVvlDbOUYjhFKfJDxPkyUdmSU1UW0h69MoYm2uxP4x6MGo11xPJ7C4JXh76XZX81 LInuz7h2bvX4JGLTTPcqZg+wgGVmWhss64JwIk5Lm9Us9zVa+PnTJlVm2d2gsikg+6r9CC tbdGQLXF8elTn5Nm7jjsVgvGbkaj+lc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694796399; a=rsa-sha256; cv=none; b=Hvz+seYbCdbM+4nt6FYf1G419bxNtC9tXzip3MJlgkPpupmc4IiVklck2nFLcFQBmN0zRB jKoBCfObM3e89VCCY6Qg3qokzK2zSENgzr0KrAOgSbmTxDQzlqWd2mxZTnAK28IpJ+VCbU sKzz3uZqv5JcD8lPy4au8IQvNSA+1hw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=UZMRUwS6; spf=pass (imf11.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.216.52 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-273e1aec35aso2056986a91.1 for ; Fri, 15 Sep 2023 09:46:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1694796398; x=1695401198; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YSRPmYTgQYAS8/W7DnTR2CfDhO5J0xkkJUsesS4GK9E=; b=UZMRUwS6uyGkSShMLXwJRTTjrkh+5zorG/D4EEYqEYRXW9wqM8zmddVBoUNfdX/k+Y /nIuJZUY/9m+8SISKS52hQgjhhBYvaz1AJiUf1mZwafxfxo7iv9MUBzYAlJvHiiw7rP3 v7/tGcjG6v8Q//GdgxrcQwzqhzO2NwEesa9c/KIAsTm7vxE/6jhaEjpPEtUU2m2YIXPz bciArcB3Cer6iUmaekK06sCZcaAPow5WdS4/nlCD9+dGBj/PgvnujYSMEjEntdvw7MHJ MkGwYBE8kENhhhvjjLmPG7SoWj0Hk4NbpbFjFoY1fFR66ZYYB03AygdvZsQBtpwcj5AZ TTmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694796398; x=1695401198; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YSRPmYTgQYAS8/W7DnTR2CfDhO5J0xkkJUsesS4GK9E=; b=lp4NYPQZoBAvMbHT6Nwgj3hBIoPbYGhJuDX7AspBqaVH2DAfu7/bnFDVD8Kth8KXat bE4Z/briFZ0WmCwPjPBvata/NVefitRGrwFFsSQIDDTvkg3G9PulBvSPZ5H00sa67Y/A RYFVrN5lg5cmpg0R83Xpqib6UGi62hkpNCtgSgRVYSceG8C+2tUZNzTRRU/uy6TFfByP WlkiPDJKidw7b5gf+mA/M3KhYvgM8x/TzdMvCy/kIAjOX4foqgcmKkVhpFxgSfzofH3s zX4HeOWEq7KDXaudARR1R+Clh5VWcK5savjsKqme0155LhmG/IMfKYGwB0Jg/UcMwfJL nl6A== X-Gm-Message-State: AOJu0Yws4v2MgLPmz4Pm6OJuzWcgfE5m7sIadCKokZm3Aurc40Lzr1nn LNUHyh70eE+8sVuWcPv+jISIjc2+UNULllmW6nY= X-Google-Smtp-Source: AGHT+IEOtjirqqcCLbCJZlVginOX7AS80MzI8LVvOQ0btY7fBc41HeWsM460QdZ43c9w8NOJfuT3+XsWmuae+ebovy8= X-Received: by 2002:a17:90a:300e:b0:274:922d:4b35 with SMTP id g14-20020a17090a300e00b00274922d4b35mr2051394pjb.1.1694796397759; Fri, 15 Sep 2023 09:46:37 -0700 (PDT) MIME-Version: 1.0 References: <658f5f34d4f94721844ad8ba41452d54b4f8ace5.1694625260.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Fri, 15 Sep 2023 18:46:26 +0200 Message-ID: Subject: Re: [PATCH v2 05/19] lib/stackdepot: use fixed-sized slots for stack records To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: dhzayab43yq99xcejqcxeninash748ao X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 048F34001E X-Rspam-User: X-HE-Tag: 1694796398-70563 X-HE-Meta: U2FsdGVkX18NEnXHVy5KfKant6OXFkKDtnVywlOg3XLgZGRay+2xO+6hvEXNSNtf5DfM0Qug6EKPigSNgODOZGjmQoq8wrH8yHSrNXekdrg5Rq9AxODkx/XYvh031mtxfZ6e/746WZ/G+nlhET0KOScOcDwMgj/kf6fJ/tFFYRVDywwkJvFpoOjgjGgjsJnxU5xOrL7CoDrmMCCLrYYj69w34LYNrnZFbtfrX6/hA2yvQdOBSN9k7TGXWD5xjD3ltQKS/Ca96Uk7b0BoisV/NCJKper9WpyGwuNwcuLIVH+LBzVZJ7ZsqKqF3cblEVu5OPYI/XEfo4s+/7BO6u46f+XXwW6eDk00AC1NysfYYO+/KpMy4Z8scR+R+R25t4UoBkFyUKyCZ2VDxkndFdYMNvLiNVRdiVn+ovKkSrK+iTQqvG0GonvRZ4Vn3qkB6NJkoXciyfuF0ssA9k3aNQCAJF26Ju/4B9g2oTok6XYKgsFykrMmVxVlPesVS+0ldutYt2HHGoXA6VHUHuYKbmrJkoj4wvg9fpRFt8cZGEeMnGGRkdk+sG8AV+HmlZVR240cMNdRNq6td4MVRz0wyhsQ/8o/4N2/AXL4FPmO41+ZJJY9ivm5L0Yoqt6cFLy3nF0nx4vl70npT7YqNXZbmzskOPDbFwj7QJPm5fnP9jwVk2csXUkJYDit+4zxAH9JSBdNhDWLGUo9Dh/WUArDgWqLsDfGQ1Lqr+8y+RFwQ9D6ikS3YtRCxtdz7ma/m9rhTbdM+YwxmFVHrtyc0/n1DWUo5xQ9z0xSuJ8aZ25CQQd/dHRUKCjMZXuC5I4umbB3NpYAX7bVxfqF9V07MQwaD7Eow04StobwOA+5QkTm9nunKvIn5iV7mW7G7yFmBLR3+tM2092aFNxuHHlaxhacOp6CfbCQU3tYG24363I3AX3mdpoOfRJsEwcjjKJVI+SfyYlnRnUZADxFHLrOMOvctZL SD4NNbtz CgmHuvdhvzrbdky3irtG7SaYghxw4WQ2jdU8ivnwkP4DlksKwtmamTniBKjo8kTRGhmjAIJ3UD75ocgjDXnDrJVuEPNU1WJPBxsFN64z/RbDfDmj11wi5skIENnSzCqcsz6cf+V9N8/H04hVdf0KfufqdLKiX7u/p2J6xZlkfXoHaiZp1DqmncJjYm4M8RCCJJT/24hstVSpQ6CSPDbDNJBkFuviSflYedlkcGADW6G/DnGlawy3wCnOTw2Tp77zOG7Ets1iTJsVJdqynRw/CBw42sS3/WYcXCfSZyNtW0A7y07QRPz3ra86fiSTrDgLPi01Zz0MpSPXdu4o2sv67cUXJx93opnD3sm+qcPlgjTE+t8gEZ/phdy9X8ZYEWn6OzJgIXcI3aDrPHWwFgmKvIe4xFLvIKXtvITsyC21wD5rWGNIbmOiTVMvJRSdNY96gw3OKARdLmpZI7T+/linx8wNMfRIda93v6HlhxkA6n657s315qaytc8k8VfqYQenS5pAq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Sep 15, 2023 at 10:56=E2=80=AFAM Marco Elver wro= te: > > --- a/lib/Kconfig > > +++ b/lib/Kconfig > > @@ -708,13 +708,19 @@ config ARCH_STACKWALK > > bool > > > > config STACKDEPOT > > - bool > > + bool "Stack depot: stack trace storage that avoids duplication" > > select STACKTRACE > > > > config STACKDEPOT_ALWAYS_INIT > > - bool > > + bool "Always initialize stack depot during early boot" > > select STACKDEPOT > > This makes both STACKDEPOT and STACKDEPOT_ALWAYS_INIT configurable by > users: https://www.kernel.org/doc/html/next/kbuild/kconfig-language.html#= menu-attributes > > Usually the way to add documentation for non-user-configurable options > is to add text in the "help" section of the config. > > I think the change here is not what was intended. Ah, didn't know about that. Will fix in v3. Thanks!