From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44E67C4332F for ; Thu, 2 Nov 2023 14:59:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D45398002E; Thu, 2 Nov 2023 10:58:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CCEEC8D000F; Thu, 2 Nov 2023 10:58:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B6FEC8002E; Thu, 2 Nov 2023 10:58:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A3D6C8D000F for ; Thu, 2 Nov 2023 10:58:59 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 7247240F10 for ; Thu, 2 Nov 2023 14:58:59 +0000 (UTC) X-FDA: 81413321598.17.C6B7E7C Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf25.hostedemail.com (Postfix) with ESMTP id A2A28A0017 for ; Thu, 2 Nov 2023 14:58:57 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GI0JiIOu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698937137; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=V4u7No3WKyf2rx02w8WP9k4VSXCaz8LOG7ZTnqR2+ek=; b=meMgush6CVTrTWepazqwE8Ae+E+1a7DbnkHo11rKUzYswAl5y5NII0CkmbC3T92scQ2vg0 6I/auhdxLQhFabHh/5YpSxCa6hM3rsnWSEgajyKRChszaP490Z0Ej7yCgOiGDDbNyejv03 6fuA4V9giY7Sp7cBpCDtd1TqQ1Y5kso= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=GI0JiIOu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf25.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698937137; a=rsa-sha256; cv=none; b=VbL8J5mHuhA95DD8q+uTCt2/3zYbKAIbV/uyJj8xzTg2UJlh9jHMNBZZJ1VSW6tKYhEb9A GrPMVbsv2L4h0vm4/JHsWTDNWMsnapQRk80gexNnkkBIBViUmTGrKMhtkGC/WhaTgogjFs R068pLX7Lg0Ow2RxPjOkGbNifP7GTLw= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1cc34c3420bso7934245ad.3 for ; Thu, 02 Nov 2023 07:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698937136; x=1699541936; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=V4u7No3WKyf2rx02w8WP9k4VSXCaz8LOG7ZTnqR2+ek=; b=GI0JiIOuerwRkRjeFeIWdICK41gk8V6hzgCXyUkIGAv4mBw5WwdsMybHkHaXd1jSXX vU8b5My4cRhrelccauJufr3YMS0OyOpgFwQw0sIv4z+XZMfmMUqEEV7yqZIr+MCu534b SQn96tM0eSFSzVB5XOx8fwyn25SwJN/o29V6lR0OWEYNdWUM71AS//TGyHSeaIkUzgNZ yzJ2ozDQ7uZHJGeElKU2LQRIRybAOpg4lwkgpuHmdU/I9MvRlf4EGdvrjqkJp6wMR8nl Ff2J0m4+zgNLTv8QsuqNzk2U6SrwwCbIAowtXw2b46P9HcV5wvd7ASwk5mMrNGF9PzL+ x6kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698937136; x=1699541936; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V4u7No3WKyf2rx02w8WP9k4VSXCaz8LOG7ZTnqR2+ek=; b=Mm8uiPNiULf4z1lr1HpHawsJFFyv80IB8ltuRydv0WZuv3dQMeRwzshBaofxHNJW4x 9UQa2xkykrhXviyBZGkgTSTCIcHwDE0Ls6eGy14r5/sCmhYjSqzy1KwJ674dxvvx0YbQ DVNpgO7pB8XU0gzMVavEfeUmYlss4nXi1+rEzaScFhonC+bI9eNQiw6sYgu2as9iCluI K00U3a0COPidJUTOGdM74nFSG+3DvryhcZ5uQl4NawRw6KQMzWUq0zb1Yk0IU7671n43 kDhxDsNh3edE5lvdE8D+8PNDgzTKN8eXdmBrbKadK2jjoekvF/xYRdUayIFfaPf0ZCEE 3CEg== X-Gm-Message-State: AOJu0YxG6MWUBiORzTpkbE2VqaTEDcB4aIitCe5AzwmSM9J0ozmP/x9I fCUUe7u7d7VSx3TWJo+RHMRGsxVfXkbD0hkAd9E= X-Google-Smtp-Source: AGHT+IHdvPSy+RpNAcSrHdhaIDNs4asX/ZQ6VV/5u4vPmHrxV/dewik6XQ8cKyVnVlKlZ3jtll2O6CpvbNNzou36uSs= X-Received: by 2002:a17:90a:ec03:b0:280:664d:cd9e with SMTP id l3-20020a17090aec0300b00280664dcd9emr10351944pjy.19.1698937136368; Thu, 02 Nov 2023 07:58:56 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Thu, 2 Nov 2023 15:58:45 +0100 Message-ID: Subject: Re: [RFC] mm/kasan: Add Allocation, Free, Error timestamps to KASAN report To: Dmitry Vyukov , Juntong Deng Cc: ryabinin.a.a@gmail.com, glider@google.com, vincenzo.frascino@arm.com, akpm@linux-foundation.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, "linux-kernel@vger.kernel.org" , "linux-kernel-mentees@lists.linuxfoundation.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: A2A28A0017 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: nfxp3y5171zfnk8jyzo977s6on4y5g57 X-HE-Tag: 1698937137-927618 X-HE-Meta: U2FsdGVkX19hdsHlEyvxkdYypjpbujfdEeYCL/6XIUFK0szcYefaIOPsg0F84t4yJdtvUGudDOSRVVP/NrFiQSDAn9o1GhX+tSnqYhzWUShFNB1vznVwfy2gDfRAzJMMwia8VoPfL+b5p6UF6GV1ejAiUnRhDQqUtlvocV0dsEBvj3MxRx+NDffm/H0lgfF2uN5yp21OrPZen9/9nMds5TdY1A8EqbkRFqNMb0vP8OkTJJ5MJns9fRwtVQnfx5pox5rU9zWkXYI/XuwKRNxashcjIKe7bRggQcNWvXLk7A8dkoDCDQtzbjRwrCSZbP3I77IaHyxCyDT10+z4VSzoswvLi9hm9bhxFtz4ch7xmJ/vxqNpem8fxTQrLIxd4yI2QhygGd+e7WmpAAhq2VLkE3cfGVZ/JeteWMxEfUJOdDD7iLAO7cfJcpKFFUhEF8WQPHghMukTFDOf6atJQ/hegaL1FIxw1P2GUORpu6nJMWyzJSV6NfjRYL+RMxPia5yAAX8OSLdW958wsy82UP68rt8b9dTAP5PPfRCwaQsvxxGbQVkxtnkl4/65CygIdteyvebQcWUkLzIqFUrJzXz6DLjFy69Y8nzq1K1U8hUIseRoun183eE/65aDTd0nZhVdDR7s4rPAv3b9irXjGdpXoseKIZNs63VSSsX8I7JOrsT6hkoYGLZbiMXwD8+dOFI/6xZ9Pl0ns0wkxwKGaCBshv5XJ0FB6IXdY5mp9AdUouD3eeyy479ffXBOY2h7aq4eio9DuSIQAYHNcLWzjVcQn6fm83bg5iBNZgT+bIInLjSbp8hXG3apaHUXHbSCNWvkdg+R1io9V79vEFQzopdB43vs9RhEjHw8eYtDjdFnNNpr2EDFd5dZOBSLUW8ylD9bEp1tEgA7AGNGAuibhsDj6MSsM/KyfOZ2zKc1CVmfB/0qG2B9z5IY+uaWFFTNpOVBvoi7vvo7rrfUJJybvyK TFaSxvZ2 shPXh/eKEozrkEzNklx9rE0CwHGJabZAoG5tuazDCL4MPpdemRQeXZkPWjJ2wxrXdmaU+bFNTUC9UEyJC40IyJ4qX4SFvZK9fp8F4VC7gXF2pPoo2H4u6MN8l+ZO0ZZhWuZX67B4+CYT3a63O0rQps3bCi+O+ZAsbEK4F4po59HIrxU+K9+PUuidSPXt2ne0s2wmdkTCQey5LRjqUx5Vk7SNhEHWCtXAvlFd4u+WkeHINaATCuhUNRZrWAisdH5RqbkfHlke9Da8/OQLjUvt7ezYLxMphEgDE6GEsduA2dARXYJh0316HHE5t1uMNh0S2hnuO+RE/ki3PgL6fsR4UNibo+Ku85OQtcuAQXCfAx14pD1u697VwwkQ3HQbJRz20jiFrqQO9L4kRZcw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000148, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Oct 31, 2023 at 10:46=E2=80=AFAM Dmitry Vyukov = wrote: > > > >>> There is also an aspect of memory consumption. KASAN headers increa= se > > >>> the size of every heap object. So we tried to keep them as compact = as > > >>> possible. At some point CPU numbers and timestamps (IIRC) were alre= ady > > >>> part of the header, but we removed them to shrink the header to 16 > > >>> bytes. > > Do you think it is worth using the extra bytes to record more > > information? If this is a user-configurable feature. > > If it's user-configurable, then it is OK. FWIW, Generic KASAN already stores the auxiliary stack handles in the redzone, so the size of the redzone header is 24 bytes. Perhaps, we should hide them under a config as well. However, the increase of the redzone header size will only affect small kmalloc allocations (<=3D 16 bytes, as kmalloc allocations are aligned to the size of the object and the redzone is thus as big as the object anyway) and small non-kmalloc slab allocations (<=3D 64 bytes, for which optimal_redzone returns 16). So I don't think adding new fields to the redzone will increase the memory usage by much. But this needs to be tested to make sure.