From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F118EC636CC for ; Tue, 31 Jan 2023 19:06:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 856846B0071; Tue, 31 Jan 2023 14:06:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 806DB6B0072; Tue, 31 Jan 2023 14:06:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CFBF6B0074; Tue, 31 Jan 2023 14:06:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 602A06B0071 for ; Tue, 31 Jan 2023 14:06:10 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 34FE71A0C38 for ; Tue, 31 Jan 2023 19:06:10 +0000 (UTC) X-FDA: 80416024500.25.8446380 Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by imf08.hostedemail.com (Postfix) with ESMTP id 355A7160020 for ; Tue, 31 Jan 2023 19:06:08 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RFEEyNFB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675191968; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k3nPPwIeG38k9HpNI9M5BUtMRo8jsnar37fO5F7Z5gc=; b=iwxYMGcRn5V6Y54AuFVQR9BONj+28Wb4rh9uawSP2frl4tptSCtvlsOGB18VbHUcBzHr1B AJBeAvXCUB1q4pf4JYCGHbN7EGq17QLofNp9DBGYvp54Jm6XJnGN+gBC2bAFarwEPs4PTE MXYyuQYzKRpQvuUh0gnyAYk3lv0OOuA= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=RFEEyNFB; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf08.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.214.171 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675191968; a=rsa-sha256; cv=none; b=l8a8jKAiw1upAw5SbSIt2TuAt/OkkgAyHDytdahXHZAAZe5p/NHMpX8lgjaIQWEYSZp/cb fKHIfUiqutIgUxhsNhB9PtAa6X7FY69oKPyIt8GwaG4kDVin9kWHrCFJq+DKlMLhSilDDc Sw/F58amEbefbVKCLoO3/tknqIdxxlM= Received: by mail-pl1-f171.google.com with SMTP id z1so8541989plg.6 for ; Tue, 31 Jan 2023 11:06:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=k3nPPwIeG38k9HpNI9M5BUtMRo8jsnar37fO5F7Z5gc=; b=RFEEyNFB81EgPiRNzaeYAzqI+azGULXszG2Ji5ZwlGVtcjwbupN4DEwFbw0wDRipRP uNdu+V5jNDUvqfw+erX6USk3NxD8N9B6hzz/3tO8qVCip/R7rFufiYwIK8FQzPIUuOOV mTRxaHXB2dFg7bhU9yz3fdoQ3eRl79OSgxs+u650ciDMoL8KA7R5jVp3q9lreq6KqcgJ P6S+gQcN8ZYDroi4/D5ZJ1PwtzmjVWxVIinriKrTC/e8g982JTMi0nYZ7d0RSBmMdR1D CDSPube4YWzqj3/s/U5Fog7qpVYrEHYiVIHGmjuejoubqCKOqNlDecZSEHMoKXNTnqFT uG5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k3nPPwIeG38k9HpNI9M5BUtMRo8jsnar37fO5F7Z5gc=; b=gsPWS+BoZUjYoQW8n/OgLv9oLg23kVG9gzJT/d0sjSQGjNoYpEaCJ6+YDNktXOnKR5 j+7oEhImY4X+f7weGJ2bkeT+E5inRqAtYhReTo2iOplBZW95v/Vx+XLK2RVZExbVvf5B Mx2emaPnRJmp2SgNdXWron0mTZe8k0/5Fau+77JHsvB+BqN46Otwrqrk7+lX7BEfC1gS VOnOzBlhTMWjl4u7OEv3iTmDdnCTAXut+sB7y5tk9vg4iK8BG457ojTDpZYA+4islkIf YzDH160k7/zL9h8UlvNl3vSftQl4P+wHUJrlfckx/AR1CeunENlhsb2lUE3ja9WSFMy1 D3bA== X-Gm-Message-State: AO0yUKXA90XaN66AM9a7EymQ652tJ5O2Q6+yfSEKqEfWP707EElBtNO2 oOD2siY8dWFHZQRWlEmy9I0SNGERk5czkh9Aeb8= X-Google-Smtp-Source: AK7set9zweHjaZM6LJLNtf5MlxPUS5wJZ32kQ43HCMdESj6IxM2UzpbKCeHQWgCyJdUGKcUcEoJ9YmfmRE5opkS1OKg= X-Received: by 2002:a17:90a:9316:b0:226:e191:4417 with SMTP id p22-20020a17090a931600b00226e1914417mr64670pjo.16.1675191967117; Tue, 31 Jan 2023 11:06:07 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Tue, 31 Jan 2023 20:05:56 +0100 Message-ID: Subject: Re: [PATCH 11/18] lib/stackdepot: rename slab variables To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 355A7160020 X-Stat-Signature: xefuhzzx3jd68gn131nm99umxotkk1hw X-HE-Tag: 1675191968-525566 X-HE-Meta: U2FsdGVkX18kJaoCM1P2sDoftzJ44OzEJcywW5nzBgICq70keGxvvk4+zHqwaoa++3oloMfm12U6oFHBXytTgG6wOdlbwqA0tu2hyjfbQOYIQ5uzIpgsCpkad4QcLJpbrFqNrT5FyWtx2BgHix1ZRWNJwU2W6z6sWSX9Fmr5qHYUqhAxNVGzqWvgjgH0Ny/72hDJmu6kbFQsVuMsU64LUQEvYDDNmhBPVYMS8JwfcKneWvg7D/Rf25ROTyPbkOqwXkOnqgRmEtOS1SkBGXVt/6Vbry+MNUgMA+cecg0fP5/s0hckWQgoHmtzB8qhUZC1/KcekK6ibK7wLW1KWDq2N1KyN8NZiBQ2SmJZ0pQWD/0Pu/nxOKhxjzC/+YZbBtj6h1jo2lzGZpQSzjTKfWGBxiHLm45EVPOQTgp70srluLHb7NqyAiONW9DacNk4HjAavk3cS51YAJzKbigGaHMmSUmjnU23IKfF5sDeRsyPvBUmlmwzB0wvfcEPkLwWMY8VXh7WW3t0DdhO2ZUhPF6+m1njFMxkwJfD/04lxKrzLINCkl8RXIIlnwAkh0PudNRVGnNSNE6iiF4BgV3HZ7HpBAHpLxOlJ8CgEpIyIBMoArnkccUiXYfEJ8N24ErFqgWHpqSTYrmScCPwGrl8XqZ2trKQG5u1NE2bRawgqLLoUpzLkpGQT5yUcC1stk+eVgRfMNiIW0ICjWFUFW/nqdfqX3ttHXfmoLdFzvM24ymnbV0C0T1cra/WJ9FiWjxg3p7lMxo06ICyHVEGk7/xJWeQ9q6NOWTilmuy9lN6yOLopr6Orhw77LpLRciVS8r/EgGsebVB4M5XNvQU413+2vw8yV43v3zIdQNUCCY3HCQSGSVdyLrrWA2UGyIy1errb5tahqp3k6P2mvDSo0HakBaLPm6+VX8GxKjBZfgGzwLh4eu1Xu3yK/MFv7Jx4/atDLzU9Ui+hNZcnrsL3YdjvNv fJLM42we tZWHzWAkF/pBIN0ja3ojfEGspWlGckT4P4eyTiUzqIiAF57FQaozQMNRe7uITWAC+oRKkvbngR+owVRrFMAX9IN3bJQ88nGiSzhq8RDrAKPWUguI+JDL5fRn8W5z9Z2HxL1xjTlYdVjiLQtLEPF5TuZpPYj/gxNVfg3tjdpm/0QaZjStWlxH8UjKXezFzOypyzxLfNM34BJ9FVy3s2kNFvFTxGxdzsKL9XrioKSR4DxrRFvoJ6CkCeiFFCDDx9ZiQj3tBssZComWru6xmcEey4x1mjd/zBAX/25WU/ep4tIjHzsePIntJnnrf1pZcSIrC/rYrTOc3EWVjJfVeP21jRvLvYaJ6MzAKiXwAslD5weMkB3ns9MX+9xHqtVwT/BDYzgyArAl6RUPr+k0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jan 31, 2023 at 12:59 PM Alexander Potapenko wrote: > > On Mon, Jan 30, 2023 at 9:50 PM wrote: > > > > From: Andrey Konovalov > > > > Give better names to slab-related global variables: change "depot_" > > prefix to "slab_" to point out that these variables are related to > > stack depot slabs. > > I started asking myself if the word "slab" is applicable here at all. > The concept of preallocating big chunks of memory to amortize the > costs belongs to the original slab allocator, but "slab" has a special > meaning in Linux, and we might be confusing people by using it in a > different sense. > What do you think? Yes, I agree that using this word is a bit confusing. Not sure what be a good alternative though. "Region", "block", "collection", and "chunk" come to mind, but they don't reflect the purpose/usage of these allocations as good as "slab". Although it's possible that my perception as affected by overly frequently looking at the slab allocator internals :) Do you have a suggestion of a better word?