From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5C45C433EF for ; Fri, 19 Nov 2021 14:36:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8A7FF61265 for ; Fri, 19 Nov 2021 14:36:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 8A7FF61265 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id DD27A6B00AF; Fri, 19 Nov 2021 09:36:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D5A136B00B0; Fri, 19 Nov 2021 09:36:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD3E36B00B1; Fri, 19 Nov 2021 09:36:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0001.hostedemail.com [216.40.44.1]) by kanga.kvack.org (Postfix) with ESMTP id AD9396B00AF for ; Fri, 19 Nov 2021 09:36:28 -0500 (EST) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 728BF184F4E63 for ; Fri, 19 Nov 2021 14:36:18 +0000 (UTC) X-FDA: 78825930036.13.3EE2625 Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf09.hostedemail.com (Postfix) with ESMTP id F3D083000110 for ; Fri, 19 Nov 2021 14:36:15 +0000 (UTC) Received: by mail-io1-f44.google.com with SMTP id k21so13012516ioh.4 for ; Fri, 19 Nov 2021 06:36:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=n3UlTJrvd9wmoZcXID/TPD0zD7tHGOLcuQUqvmY9UHk=; b=kSPHLFXVWfzWglKACW4IQ1sWePw7oEXzQO7hndWLP7OmApguWnkuYU8/Xwa2yDY2vN wmz57OvC4RYDxzYNroeOA03UauNZtu0lV7xl0UP/fxOESZK6jWV3dOZET1VMTNnNVQ6M YhdOnt+eqp3r8+fm93rXsDAEwJKl5+cqgbJF10+UBaUiGkxxnOZLtMhxIQkGlO9gmoRr ZczfEabzLHmT+EzHPY3YczhJIqWMOLLmntpR3SI+1RluJN5TbYKZF7jaAhu1rpC6FXMA W1XgHWS9Dp9HozuvF9yU+PEcRIYA0Bj+GOPdavzRWpwYI8ML2rmCIUpABDBCbBddZPiw 4SHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=n3UlTJrvd9wmoZcXID/TPD0zD7tHGOLcuQUqvmY9UHk=; b=vCergMcNMyAwpsweXjJ3q2DwqODliEY/Zza2F6agpVvEd6xVlVdK3bh5FnbLO4pdOn eXDP/eKS8dPUD3JJYbyIZjejmGvbS4rC+ufJ1mHTuqaCtydl5h+nrXVBy6/kDRz8mu7G /Lb74C/dFofIGaDmFKCiuQFiAg9HRcckVLpnQO2qapBn+kChXFFreQkzmHSNe9AcPo6v kCYVm5dRR+ArJ+5ImWbWxGo7x0naZP7x5yXj8eP2cCMqGVWNaCsh8RYat4OAi4iWxtlU aEng+aC7lxu9HXESqgyprsm3yzBzWN65XEOnvLNCcIf9j4FOox5qxv2PaiV9JSKrhjQI r6lA== X-Gm-Message-State: AOAM532zJL+dU1AZCHY9apjfw7J6xrBmoEVg/MONdbGQkGBt7w89Dldk NbxjEnWe2uQU06SMtM3DHo19Qu1bwzkJAkhVOB0= X-Google-Smtp-Source: ABdhPJxYIb29H5/N4PP6Hk1ou+ayTZqWgvtG3irnnOOFXkfqXb5bbtUNRsJProIfPntAcGTGiAojHNXwON3406kEx3Q= X-Received: by 2002:a05:6638:2257:: with SMTP id m23mr28211802jas.17.1637332577526; Fri, 19 Nov 2021 06:36:17 -0800 (PST) MIME-Version: 1.0 References: <20211119142219.1519617-1-elver@google.com> <20211119142219.1519617-2-elver@google.com> In-Reply-To: <20211119142219.1519617-2-elver@google.com> From: Andrey Konovalov Date: Fri, 19 Nov 2021 15:36:06 +0100 Message-ID: Subject: Re: [PATCH 2/2] kasan: test: add test case for double-kmem_cache_destroy() To: Marco Elver Cc: Andrew Morton , Andrey Ryabinin , Alexander Potapenko , Dmitry Vyukov , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , kasan-dev , LKML , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: F3D083000110 X-Stat-Signature: wyfy6oa7ue4z4ccj9a41wqeszhcjstsw Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kSPHLFXV; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-HE-Tag: 1637332575-187000 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Nov 19, 2021 at 3:22 PM Marco Elver wrote: > > Add a test case for double-kmem_cache_destroy() detection. > > Signed-off-by: Marco Elver > --- > lib/test_kasan.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index 40f7274297c1..4da4b214ed06 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -866,6 +866,16 @@ static void kmem_cache_invalid_free(struct kunit *test) > kmem_cache_destroy(cache); > } > > +static void kmem_cache_double_destroy(struct kunit *test) > +{ > + struct kmem_cache *cache; > + > + cache = kmem_cache_create("test_cache", 200, 0, 0, NULL); > + KUNIT_ASSERT_NOT_ERR_OR_NULL(test, cache); > + kmem_cache_destroy(cache); > + KUNIT_EXPECT_KASAN_FAIL(test, kmem_cache_destroy(cache)); > +} > + > static void kasan_memchr(struct kunit *test) > { > char *ptr; > @@ -1183,6 +1193,7 @@ static struct kunit_case kasan_kunit_test_cases[] = { > KUNIT_CASE(ksize_uaf), > KUNIT_CASE(kmem_cache_double_free), > KUNIT_CASE(kmem_cache_invalid_free), > + KUNIT_CASE(kmem_cache_double_destroy), > KUNIT_CASE(kasan_memchr), > KUNIT_CASE(kasan_memcmp), > KUNIT_CASE(kasan_strings), > -- > 2.34.0.rc2.393.gf8c9666880-goog > Reviewed-by: Andrey Konovalov Thanks!