From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51865C433F5 for ; Mon, 6 Dec 2021 21:11:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D40BA6B008C; Mon, 6 Dec 2021 16:10:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEEED6B0092; Mon, 6 Dec 2021 16:10:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B90576B0093; Mon, 6 Dec 2021 16:10:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0046.hostedemail.com [216.40.44.46]) by kanga.kvack.org (Postfix) with ESMTP id A90306B008C for ; Mon, 6 Dec 2021 16:10:51 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 6174486994 for ; Mon, 6 Dec 2021 21:10:41 +0000 (UTC) X-FDA: 78888613482.07.F1E4F7F Received: from mail-io1-f44.google.com (mail-io1-f44.google.com [209.85.166.44]) by imf13.hostedemail.com (Postfix) with ESMTP id B294A1046284 for ; Mon, 6 Dec 2021 21:10:40 +0000 (UTC) Received: by mail-io1-f44.google.com with SMTP id b187so14522219iof.11 for ; Mon, 06 Dec 2021 13:10:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kwRwUjyY6hc655acCUnran3GDnVqWndaVhYkx0l7k24=; b=mwEsGhvX6mKD+PVSJnfyedkcuQZfQ85ka5ZM+pIUTJvypKSVlZbwvZQnoLOIdLLSfz d53QGen/VHPQHZHJnJML4AAGs50OvW/T3mUwMX4hPmIlLy17bXza5ibkFUB5gaNjj/gL UscROk83VQmLC/10OHyPmC+uFXJao4vSiRu9MPJPSmJHVuzRvfc30x9wymJJ68+xUZkP k5RIX1nMa/9ne6312KPMRSdIRkPMxC7giU2CEbpGh20bQx+IANVWekzCTfnliiKfhkxs 6ogDSgImlcO/ci0PV/MA+YmId6kp/hdI5FpJZAUt8exGQ6BG/9PylF4h5FBZsOpATG9x lCNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kwRwUjyY6hc655acCUnran3GDnVqWndaVhYkx0l7k24=; b=B2De6fJBs27mDoSWJZeBCY2SZvnbpgaCgCGQNbFtCFuZ3e1ZtGzLjiH06vxRgAig2B bQK2+T9vOai0mZA4qWFvJL/MyeIprbgNnIAq+o1E6Jyx9BUN75gEoVZXkcGvamFUTU75 W1NfGXToAgbtXRa592c+HFHuPACaiTOfyaTsXp0J5WzLrS9xsxH26tqWJ1Xo4f0/VQS1 ZDZnvVPtnXIiJX98LYUZYc/N/SGKO4hZ0l11f7dQ0HhyEbqoEEK4ayU5XzWGxA+w3SAf RVLkxVkfpKkda3TaZZII7Gfla57zKDYK2coDpOR7WKQp8puGDwkdJU0/tJP2B5oc1ys9 xGcw== X-Gm-Message-State: AOAM533OyPvI43600yDT1CNeV+HJR/E6VS6JMocLDmYj/xA2W9QFsA8t jyhIMPrbEavAzxj0wS4YUU9+qH7Z1Ct2LmE3UJU= X-Google-Smtp-Source: ABdhPJz9/8bJnfrPY/6R3plha0QHLKoEihYxy3HjH3SBNEAb3ptkLzGgT0n6k8AW2FJDSpHv5aZBS4DEePnWzJICXJQ= X-Received: by 2002:a5e:d502:: with SMTP id e2mr38338219iom.118.1638825039996; Mon, 06 Dec 2021 13:10:39 -0800 (PST) MIME-Version: 1.0 References: <8afdf7eb0bae77d2e94210d689d524580cf5ed9a.1638308023.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 6 Dec 2021 22:10:29 +0100 Message-ID: Subject: Re: [PATCH 29/31] kasan, arm64: allow KASAN_VMALLOC with HW_TAGS To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Vincenzo Frascino , Catalin Marinas , Peter Collingbourne , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Andrew Morton , Linux Memory Management List , Will Deacon , Linux ARM , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=mwEsGhvX; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.44 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: B294A1046284 X-Stat-Signature: ftjhgjh39zgzeishs5qeq7r848p9fgop X-HE-Tag: 1638825040-867315 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Dec 1, 2021 at 12:35 PM Marco Elver wrote: > > On Tue, Nov 30, 2021 at 11:08PM +0100, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > vmalloc tagging support for HW_TAGS KASAN is now complete. > > > > Allow enabling CONFIG_KASAN_VMALLOC. > > This actually doesn't "allow" enabling it, it unconditionally enables it > and a user can't disable CONFIG_KASAN_VMALLOC. > > I found some background in acc3042d62cb9 why arm64 wants this. Indeed. Will adjust the description in v2. > > Also adjust CONFIG_KASAN_VMALLOC description: > > > > - Mention HW_TAGS support. > > - Remove unneeded internal details: they have no place in Kconfig > > description and are already explained in the documentation. > > > > Signed-off-by: Andrey Konovalov > > --- > > arch/arm64/Kconfig | 3 +-- > > lib/Kconfig.kasan | 20 ++++++++++---------- > > 2 files changed, 11 insertions(+), 12 deletions(-) > > > > diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig > > index c05d7a06276f..5981e5460c51 100644 > > --- a/arch/arm64/Kconfig > > +++ b/arch/arm64/Kconfig > > @@ -205,8 +205,7 @@ config ARM64 > > select IOMMU_DMA if IOMMU_SUPPORT > > select IRQ_DOMAIN > > select IRQ_FORCED_THREADING > > - select KASAN_VMALLOC if KASAN_GENERIC > > - select KASAN_VMALLOC if KASAN_SW_TAGS > > + select KASAN_VMALLOC > > This produces the following warning when making an arm64 defconfig: > > | WARNING: unmet direct dependencies detected for KASAN_VMALLOC > | Depends on [n]: KASAN [=n] && HAVE_ARCH_KASAN_VMALLOC [=y] > | Selected by [y]: > | - ARM64 [=y] > | > | WARNING: unmet direct dependencies detected for KASAN_VMALLOC > | Depends on [n]: KASAN [=n] && HAVE_ARCH_KASAN_VMALLOC [=y] > | Selected by [y]: > | - ARM64 [=y] > > To unconditionally select KASAN_VMALLOC, it should probably be > > select KASAN_VMALLOC if KASAN Will fix in v2. Thanks!