From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D63C7C004C0 for ; Mon, 23 Oct 2023 16:18:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D9846B00F2; Mon, 23 Oct 2023 12:18:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 68A096B00F3; Mon, 23 Oct 2023 12:18:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 52BB96B00F4; Mon, 23 Oct 2023 12:18:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 41B776B00F2 for ; Mon, 23 Oct 2023 12:18:06 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1E7044010C for ; Mon, 23 Oct 2023 16:18:06 +0000 (UTC) X-FDA: 81377232972.01.2EF47E8 Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by imf09.hostedemail.com (Postfix) with ESMTP id E5630140017 for ; Mon, 23 Oct 2023 16:18:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=l76I22Um; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1698077884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BPMyERwOm/NcnB3A4LMRfhfW5xHZDfVqvzjxqSuC/ik=; b=F3dBIMNLKJiclVHcEHOvnDCFvOqP9pneDY9j5gR4fzgAyk2G4+Ba2Ywy2LsByuAAIf/EoB uCnA2FZJVLCZv1z0N5r6URbc7OfDwTVvraqbekNPr1dAz0Enzk+hU4kriUJcJnialSDAoE /cTX9IS4EEHHEKyMBOTw9VPZrcnQLLU= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=l76I22Um; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf09.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.215.182 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1698077884; a=rsa-sha256; cv=none; b=pIVpyPBQlSdFICJxgJLtVz0gra+U83+4QrU2BrIu/UbR/bKUxhfBmhwZ5Ji1nfXfhYzRIU d9MmYpV53JyLWENPs86agbmDIEPFpu1+m5mcATfZiTZVta+mTq4+Kopmy3me8XD7yta47U bd8jMctlPZ0cxaRH37hmk4DNkKolcyI= Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-5aa7172bafdso1925240a12.1 for ; Mon, 23 Oct 2023 09:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698077883; x=1698682683; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BPMyERwOm/NcnB3A4LMRfhfW5xHZDfVqvzjxqSuC/ik=; b=l76I22UmtJLCXIF/5ssT/jZCxP+LlF37fBqkVyUl8eYpmx/wyRYoznNFlgHmUMtqnx gnMBpkggRRaqW/MRnQzuJXE0k5BuHxvvUd/G7KP1MonaDS6Hk2kziCJNeB1qTKfug1kH mj/q4io1Tgj9m5refWtthiHjl5IdcJKY/pYtpPpXSzExmG+9RvbefyBPCLv9XRfT5GpN H6GSoSPI4YSyH/MTBkDOQlwaAerePcdE7L8Zllr9t5gA8N5DurJTHaw1jdSsWdll1k4I FLNHANUQHzPe1yuLm2GHMqxW4Phm2+gVOLWosGLv+UlpZR+VD38rVmQcx7YKBXOS9LNa m0LA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698077883; x=1698682683; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BPMyERwOm/NcnB3A4LMRfhfW5xHZDfVqvzjxqSuC/ik=; b=myqjJukD5Ny3TEXlhTmU8ewS56Wu+yiGcu6oBdgh3Y8tnoN87hS65oDV0MGL284DUA l6cNhg2JBcqcNFKc9jHf+dTIPbw3Yb2BWsyR0aEK1hMWqz4z8gUMOn/7qnq1cKHbUjeg OY/Bmmeuq107U3Zf1TDASkuFbaHy9bb6ocpm4Gv1N/F7qSZXIVJab1nawsobLAuXo7yF 2aMdqXehteB7vNM8QDh9rjDu4GcSWG4Nqy1kOgBF5acqEctLFL7j+Rpwtlbfisjyxmk6 f5G6YQEvC3cGDCLWhQddLyBxCFtEP83FCDOM12+f+mjcd826iW1FrX+TwNqvzgK+pOr3 y16w== X-Gm-Message-State: AOJu0Yz4ZNlroTBsusQwFbtXENygbCCDGFClnmWbqtYOMrmGZjc9qHrL jOuV7Vf4G1K+GmCot+ElmvoBUZUPGYN3HJdPTk0= X-Google-Smtp-Source: AGHT+IE5ETbhrd+Qz3X/nlheL6PwYn82j2ISE6ffyRQf9e0BfzUw0DqqFdMAtYaMQ17eb/+pgEAdEaITjOO5/dKN12k= X-Received: by 2002:a17:90b:51d0:b0:268:b0b:a084 with SMTP id sf16-20020a17090b51d000b002680b0ba084mr7386877pjb.46.1698077882806; Mon, 23 Oct 2023 09:18:02 -0700 (PDT) MIME-Version: 1.0 References: <6e2367e7693aa107f05c649abe06180fff847bb4.1694625260.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Mon, 23 Oct 2023 18:17:51 +0200 Message-ID: Subject: Re: [PATCH v2 19/19] kasan: use stack_depot_put for tag-based modes To: Alexander Potapenko Cc: andrey.konovalov@linux.dev, Marco Elver , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E5630140017 X-Stat-Signature: etf84b83a3ka9mac8j763pjdrip67s77 X-Rspam-User: X-HE-Tag: 1698077883-960022 X-HE-Meta: U2FsdGVkX1+WR2OZ7dObew+wwE88xeX9EpZn+RhdkEhEI1aCsjajvBIh/t3n5REfBhRwQCb7uei2lvaKRDsWYZGA/vmKZgdEIoP88XToKwvE3gIHJbFT6g4+CD8BE/7YO7siTrOdY9IpaBa53A1BwyeRt4+GLwohL7lgYZPhzbgU+QJWlqiLO6xeXsyKv7KViRbA9eChyha4VYSrCIcCTGUjZdmCe4k1qKVWgxUrP5GynwY7NJvMELHt1Qxf3/MldZ4vtH3DuFuOOFzYQCYceW6yB9heQWoNqNgsohKigrWIgOJ0e+nwmS7wRScS/zZoa3LATah34oXyB5FsTE9t8suPQVZJYVE1rLpZYw14ENCZLFSqG/PbwDDJv20NrJ5JlM2nIWPZxSIRyI0WWeA/Ogrw6GHZFyPDawRfcsra0RJ8GkpAt72aEDd7a9IYHNmj75Nu5zc6uH3RuidhoIXxxN/RPg9oZ13H6LU+uko75hAE4mdcaMidinvSfQNskokVSUdDeJ4BGAHlhutD2RZ6bBfJn1R72nX2E+tZZYfl7L+Jmo8WuWIjVRSIQ6W3tSRHBUeaSpwVSebzKAVHZHuq0MU1PthkpJCi2Tp4JVOdngWbkn2TDvlpPSM5bxv/is499cdF8OH22NGXyeA0cNggJuWwxmFQfrFLcmkzZ3cgOKGMkMWGHlP0S+ZS5AfzDzczBa/LXX7Tiu3mZxooNnEsXW5AA7PbWjKLHZQskAVphfBpwt3m3reBEGuXsrlbOu9hKR/68FAtOMiVVPQ534cMWTWUGPZ5CQrlVbzAtX4Hl6rvDIi30WptyFF7m5AYNzt2GvsfoZIkTkn6J2xtBl6mEJMLbqrBTYypiIJrgJVNtrDOgTH/9ongnnv9oJg2Oh9Dyyoo113/1et6SUBKyZCLaiYS8D8PvHkT2Mi9JUgtDP82+wXa001uY8TPTF8C/hi9ifsI1gBJMRq4eTcmAdb gggqI1qj uIU3QnYDmD4eJPVRNSFehe3llx9TTpIvbzC/E65N7YAkfzk6Fqt9r6miR5aPUkKxcKRdcIP1++pC57XFNAy2Euwj5L+mKlt8wRbg8BvUi+WPFk/m9yyDdx/4QPp44SLtkEsRwUPODYP64SJtFQm300Obduc9DhTExm1QeOd7uqM6t7MZnREgzn3en/nvxB0sGMiAbPTbJbzLD5otjXIocirCUA3/6r4S6BhNISCH1IECnAg69QrkPwYpwqxBt8ezjw44RLKRgRV3pYqiETiz77gv3uQvkSnrfFQIaADWfY2AxbDc24TuYD5/GCNNFfrX1ca7qhiWNk2ksQP3lN/tNY9jdP5kaHYSs4b5Q6IrZkWdR69OMlpuuBdYLIaNMO+uuNuIN52KEUaZIeY4U7SVf83sU6Fdd+Hw6ogqBjjbFcTDyLOvh7UGUOgi5rixea7RhD2dKv8qRxyv1pGHPz1o8+WSUgQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.008264, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 9, 2023 at 2:24=E2=80=AFPM Alexander Potapenko wrote: > > On Wed, Sep 13, 2023 at 7:18=E2=80=AFPM wrot= e: > > > > From: Andrey Konovalov > > > > Make tag-based KASAN modes to evict stack traces from the stack depot > "Make tag-based KASAN modes evict stack traces from the stack depot" > (without "to") > > > Internally, pass STACK_DEPOT_FLAG_GET to stack_depot_save_flags (via > > kasan_save_stack) to increment the refcount when saving a new entry > > to stack ring and call stack_depot_put when removing an entry from > > stack ring. > > > > Signed-off-by: Andrey Konovalov > Reviewed-by: Alexander Potapenko > > (but see the two other comments) > > > --- a/mm/kasan/report_tags.c > > +++ b/mm/kasan/report_tags.c > > @@ -7,6 +7,7 @@ > > #include > > > > #include "kasan.h" > > +#include "../slab.h" > > Why? This belongs to the previous patch, will fix in v3, thanks!