From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE496C433F5 for ; Thu, 30 Dec 2021 19:11:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 546916B0072; Thu, 30 Dec 2021 14:11:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A8A46B0074; Thu, 30 Dec 2021 14:11:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 322DE6B0075; Thu, 30 Dec 2021 14:11:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 218DE6B0072 for ; Thu, 30 Dec 2021 14:11:41 -0500 (EST) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id D6B4887CA3 for ; Thu, 30 Dec 2021 19:11:40 +0000 (UTC) X-FDA: 78975404760.25.24640F8 Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by imf20.hostedemail.com (Postfix) with ESMTP id D93B01C0003 for ; Thu, 30 Dec 2021 19:11:32 +0000 (UTC) Received: by mail-io1-f41.google.com with SMTP id x6so30421240iol.13 for ; Thu, 30 Dec 2021 11:11:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GPu8b1zm5l26lxQv3Kupma6jp1vzEvVrzyOVnWiH1iE=; b=DYv3/L8m1C+//6z+gGBtZ/Gw6/jDkpDfeubB94WOXRybqSfTsUPpy5xIbr5IkDJ456 JFEINKg4J05U2tkD/QrPPlwFN+A7cQYH9E1BaXLUmK9J51tWxFid53hemXZN2ghKiy+X l0BCjUhBRNJFw/5xQU+n5iWpc7X05leuU7BVHLqtypKkSsYf2xmT9I1QSRpHgzTOJCI0 h5cfLuhqd47B9NjWP6vUfu0cUb6tgQ/cZ3Bhp4LzTqlpjPsfR0QRPdzkffYHgpEG6sp+ 89RT6aqi+aLmDulYeixtBoavmr8y8/Kcch00iAa4e2BQFPr9MpND5oxOXGVMaruY6eTL ec1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GPu8b1zm5l26lxQv3Kupma6jp1vzEvVrzyOVnWiH1iE=; b=zut3dn37HQdV8qo3sfIxYyOJjbgywADXAZkKqDdmlQ8aeVdJ38iBjp8hUQZoTb0Egc ko2DSLyooWfSMe0hWGDsD9RXBs6qdfXvaIrLgaGpjwlNVIx9YZLTo18YRRe6y3h9851n mdeqoudFpyP5bx//M+jawK5wCzI/ccT7HooQuGHrHmeCfTvV9bI5G0YuhjXF+GQtETEu TG4zzWEOZkD7cdJDU9HNJGvURaHfYjhx0Wkx1EyejjxlyPYRljyExUP5GGmdqu20wXLf rSgVVw8vttkXuaSPy2o/jTk7+1ozJlHCeyysIuCO1isa5mhptXr3Aq/6E7uwG4N8urVk CySw== X-Gm-Message-State: AOAM531kVkBwUV/27Glj4L0Qcp4nOLj6Pw4emwQZDqPJAt0M5HSXaFFO B4el0AsG03L7/0wuYpiZjSfz/BofgnXLEq90mYDK94pZ X-Google-Smtp-Source: ABdhPJyWzqTL/fogtFxden0UIQV4GZQcWfMzs9KPHNVuo+ldoHL4+1vn/FYeyBb2TQf6AkWo5N4E5H1RNdasgZpp5e0= X-Received: by 2002:a05:6602:26d0:: with SMTP id g16mr8170007ioo.56.1640891499870; Thu, 30 Dec 2021 11:11:39 -0800 (PST) MIME-Version: 1.0 References: <73a0b47ec72a9c29e0efc18a9941237b3b3ad736.1640036051.git.andreyknvl@google.com> In-Reply-To: From: Andrey Konovalov Date: Thu, 30 Dec 2021 20:11:29 +0100 Message-ID: Subject: Re: [PATCH mm v4 28/39] kasan, page_alloc: allow skipping unpoisoning for HW_TAGS To: Marco Elver Cc: andrey.konovalov@linux.dev, Alexander Potapenko , Andrew Morton , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="DYv3/L8m"; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.41 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D93B01C0003 X-Stat-Signature: sdcerawnme55th1rcokjcjbs3tdwcoxa X-HE-Tag: 1640891492-33688 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Dec 21, 2021 at 1:05 PM Marco Elver wrote: > > On Mon, Dec 20, 2021 at 11:02PM +0100, andrey.konovalov@linux.dev wrote: > [...] > > #ifdef CONFIG_KASAN_HW_TAGS > > #define __def_gfpflag_names_kasan \ > > - , {(unsigned long)__GFP_SKIP_KASAN_POISON, "__GFP_SKIP_KASAN_POISON"} > > + , {(unsigned long)__GFP_SKIP_KASAN_POISON, "__GFP_SKIP_KASAN_POISON"} \ > > + , {(unsigned long)__GFP_SKIP_KASAN_UNPOISON, \ > > + "__GFP_SKIP_KASAN_UNPOISON"} > > #else > > #define __def_gfpflag_names_kasan > > #endif > > Adhering to 80 cols here makes the above less readable. If you do a v5, > my suggestion is: > > diff --git a/include/trace/events/mmflags.h b/include/trace/events/mmflags.h > index f18eeb5fdde2..f9f0ae3a4b6b 100644 > --- a/include/trace/events/mmflags.h > +++ b/include/trace/events/mmflags.h > @@ -51,11 +51,10 @@ > {(unsigned long)__GFP_ZEROTAGS, "__GFP_ZEROTAGS"} \ > > #ifdef CONFIG_KASAN_HW_TAGS > -#define __def_gfpflag_names_kasan \ > - , {(unsigned long)__GFP_SKIP_ZERO, "__GFP_SKIP_ZERO"} \ > - , {(unsigned long)__GFP_SKIP_KASAN_POISON, "__GFP_SKIP_KASAN_POISON"} \ > - , {(unsigned long)__GFP_SKIP_KASAN_UNPOISON, \ > - "__GFP_SKIP_KASAN_UNPOISON"} > +#define __def_gfpflag_names_kasan , \ > + {(unsigned long)__GFP_SKIP_ZERO, "__GFP_SKIP_ZERO"}, \ > + {(unsigned long)__GFP_SKIP_KASAN_POISON, "__GFP_SKIP_KASAN_POISON"}, \ > + {(unsigned long)__GFP_SKIP_KASAN_UNPOISON, "__GFP_SKIP_KASAN_UNPOISON"} > #else > #define __def_gfpflag_names_kasan > #endif Will do in v5, thanks!