From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05037C433EF for ; Tue, 8 Mar 2022 15:31:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7370D8D0002; Tue, 8 Mar 2022 10:31:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6BE938D0001; Tue, 8 Mar 2022 10:31:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 560068D0002; Tue, 8 Mar 2022 10:31:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0200.hostedemail.com [216.40.44.200]) by kanga.kvack.org (Postfix) with ESMTP id 4233D8D0001 for ; Tue, 8 Mar 2022 10:31:02 -0500 (EST) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id F35931808E183 for ; Tue, 8 Mar 2022 15:31:01 +0000 (UTC) X-FDA: 79221607164.17.B59F39A Received: from mail-il1-f176.google.com (mail-il1-f176.google.com [209.85.166.176]) by imf13.hostedemail.com (Postfix) with ESMTP id EB5AA2001A for ; Tue, 8 Mar 2022 15:30:57 +0000 (UTC) Received: by mail-il1-f176.google.com with SMTP id h2so3939071ila.12 for ; Tue, 08 Mar 2022 07:30:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QL+ZtmXXGFLuTx2y9WXZomB2eATV+ikv3E06Gw8vFq0=; b=I68j85a6/qjvW0V3IavZmXBtBc8pD6pwX7yGYgP70N3qfY/KekXPn14gqHuXHQi3iz 45y3wjsfeAJoSBGDTb3kxwyUuzILLoXo2eFo4z3nCSjYHUU1aBHr+B04M3kP/DctZcqU FaE5+rdNtdNZSVsKxPIjL2TKvhOwT8EAqwk6x0LlVDTkAwSZt0rUy3ePzZmsgeFzrtgj IcJ9yy+JXS0yPZEfdAsbdDcR8t9w2+5GyzVroPUq4B5oDrMBfwsfDFPB6QqHpu/tXFOv cMBPSu+cM5zifvwDyOWdetr6U++L+xykJjh1Zou3iBXvPcrzyzw1BY2lrHkSovZ8zh++ GxXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QL+ZtmXXGFLuTx2y9WXZomB2eATV+ikv3E06Gw8vFq0=; b=KS5zRjAimpYWp5is+H+JHL2lALOh03McaSWzmCRWDK6x1CZwCNOjMw8TUqn322rG0C TPUD/Aa6vBzILeVRPB3dQEwzQT8E+uAtB4Uw0W3JoUIQqlfQOp18zoIQxeMX26OffTr1 dY96fAEJXBrPZXGRUs2Cxpq4pF/PCrudNxgqqhRi6K1byFD6Ki0gPwGo8o4S3kQWKjqO ntYlsWK3Gu1L8V0jmCkQBPN41QuWMbO+FxTvBfVqOdATuZ9aQJ0DVMtAQeBKkDoQjS4l g7bXAdUDhLdnDjmoQvdrkHfALjZrAW8YsHPEkdVYLORUnKXu7MxtYa8uy0+pspo1NCmg 46QQ== X-Gm-Message-State: AOAM530nKzMFZ+v8WVE8564CfWnbp0qm3y1n/A9GXS7T61AznqQ0OP2w xHoysGAss46uNnpJ63dX1SGedHG3n5RrxNlVJks= X-Google-Smtp-Source: ABdhPJyPwmIL/pO50iF8syyeci1IJTewvmDOYzdRSzAtoKHRP6OQjBCrXGlvhWl93W16Be715WB6xOEjeRlrzUnkWU8= X-Received: by 2002:a05:6e02:20c3:b0:2c2:9e23:8263 with SMTP id 3-20020a056e0220c300b002c29e238263mr16510481ilq.248.1646753456934; Tue, 08 Mar 2022 07:30:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Andrey Konovalov Date: Tue, 8 Mar 2022 16:30:46 +0100 Message-ID: Subject: Re: [PATCH v6 31/39] kasan, vmalloc: only tag normal vmalloc allocations To: Vasily Gorbik Cc: andrey.konovalov@linux.dev, Andrew Morton , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Andrey Ryabinin , kasan-dev , Linux Memory Management List , Vincenzo Frascino , Catalin Marinas , Will Deacon , Mark Rutland , Linux ARM , Peter Collingbourne , Evgenii Stepanov , LKML , Andrey Konovalov , Ilya Leoshkevich Content-Type: multipart/mixed; boundary="000000000000d579e505d9b6aa3d" X-Rspamd-Server: rspam10 X-Rspam-User: X-Stat-Signature: jezoyeif856tjkutw7ubrmwcrd41xppe Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=I68j85a6; spf=pass (imf13.hostedemail.com: domain of andreyknvl@gmail.com designates 209.85.166.176 as permitted sender) smtp.mailfrom=andreyknvl@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Queue-Id: EB5AA2001A X-HE-Tag: 1646753457-841536 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000d579e505d9b6aa3d Content-Type: text/plain; charset="UTF-8" On Tue, Mar 8, 2022 at 4:17 PM Vasily Gorbik wrote: > > On Mon, Jan 24, 2022 at 07:05:05PM +0100, andrey.konovalov@linux.dev wrote: > > From: Andrey Konovalov > > > > The kernel can use to allocate executable memory. The only supported way > > to do that is via __vmalloc_node_range() with the executable bit set in > > the prot argument. (vmap() resets the bit via pgprot_nx()). > > > > Once tag-based KASAN modes start tagging vmalloc allocations, executing > > code from such allocations will lead to the PC register getting a tag, > > which is not tolerated by the kernel. > > > > Only tag the allocations for normal kernel pages. > > > > Signed-off-by: Andrey Konovalov > > This breaks s390 and produce huge amount of false positives. > I haven't been testing linux-next with KASAN for while, now tried it with > next-20220308 and bisected false positives to this commit. > > Any idea what is going wrong here? Hi Vasily, Could you try the attached fix? Thanks! --000000000000d579e505d9b6aa3d Content-Type: application/octet-stream; name="s390-kasan-vmalloc.fix" Content-Disposition: attachment; filename="s390-kasan-vmalloc.fix" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l0iafuk20 ZGlmZiAtLWdpdCBhL21tL2thc2FuL3NoYWRvdy5jIGIvbW0va2FzYW4vc2hhZG93LmMKaW5kZXgg NzI3MmUyNDhkYjg3Li42OTM5NTRmNzcxZWMgMTAwNjQ0Ci0tLSBhL21tL2thc2FuL3NoYWRvdy5j CisrKyBiL21tL2thc2FuL3NoYWRvdy5jCkBAIC00OTIsNyArNDkyLDggQEAgdm9pZCAqX19rYXNh bl91bnBvaXNvbl92bWFsbG9jKGNvbnN0IHZvaWQgKnN0YXJ0LCB1bnNpZ25lZCBsb25nIHNpemUs CiAJICogRG9uJ3QgdGFnIGV4ZWN1dGFibGUgbWVtb3J5LgogCSAqIFRoZSBrZXJuZWwgZG9lc24n dCB0b2xlcmF0ZSBoYXZpbmcgdGhlIFBDIHJlZ2lzdGVyIHRhZ2dlZC4KIAkgKi8KLQlpZiAoIShm bGFncyAmIEtBU0FOX1ZNQUxMT0NfUFJPVF9OT1JNQUwpKQorCWlmIChJU19FTkFCTEVEKENPTkZJ R19LQVNBTl9TV19UQUdTKSAmJgorCSAgICAhKGZsYWdzICYgS0FTQU5fVk1BTExPQ19QUk9UX05P Uk1BTCkpCiAJCXJldHVybiAodm9pZCAqKXN0YXJ0OwogCiAJc3RhcnQgPSBzZXRfdGFnKHN0YXJ0 LCBrYXNhbl9yYW5kb21fdGFnKCkpOwo= --000000000000d579e505d9b6aa3d--